Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

Updated Pygments with pip to 2.17.2 und cut the time in half. So yeah, that's already an improvement.

Well, good to know that it is not something in the phorge codebase. Our server has pygmentize 2.14.0 - but the server itself is really not the best, so that could be an explanation. Maybe we could make some remarks about performance and keeping the versions fresh on the diviner page...

The word solution would solve it from the expecting side, you are right. Here in my company the search is used frequently and only as a plain text search. So we have to escape the special regex signs time and again. Just would be interested if this is seen as an issue by others who uses the feature.

Thanks for the clarification. I still think we should tackle the exception.

In T15728#15768, @valerio.bozzolan wrote:

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Just asking for a friend: Is there some progress on this?

Maybe this could be integrated in the Diagrams extension...? I mean: the entire infrastructure is there - you just have to decide, what lib you wanne use when creating a new diagram. @mturdus What do you think about this?

In T15673#15587, @valerio.bozzolan wrote:

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

https://video.fosdem.org/2024/h2215/fosdem-2024-3610-unpack-phabricator-welcome-phorge-forking-the-opinionated-open-source-project-manager.av1.webm

• Making @valerio.bozzolan happy

I really have struggled to find any device in our company that can't do await/async. I strongly bevlieve it is a non issue. Let us land this thing now and see if we get any feedback of an error.

• Changes the order of the variables and function calls

• Extends select behavior and only select content on first click

In D25536#15448, @valerio.bozzolan wrote:

Again, non-blocking opinion:

Are we aware that the "async" keyword (that was never used in Phorge) may just cause a crash by syntax error (almost-immediately even without clicking?) by that kind of browsers, so, breaking the page, just because we want to provide a copy function and we want to avoid .then()?

I think we can introduce breaking changes, but it's strange to do that, now, with this minor feature.

If we are aware of this minor risk, indeed let's land.

In D25536#15446, @valerio.bozzolan wrote:

Additional non-blocking thing:

Maybe should be copy(text) with var data defined outside

Bonus point: copy() not defined during every call of JX.Stratcom.listen, but outside (?)

In D25536#15437, @valerio.bozzolan wrote:

Yes, we can avoid async.

So, this is just a tip, to avoid async and also to have everything a little more modular for no reason:

1. remove async from copy()
2. rename copy() to copyWithoutFeedback() and have the function that always return a Promise
   • so copyWithoutFeedback() has return navigator.clipboard.writeText(text); to always return a Promise
   • so copyWithoutFeedback() can use copyWithFeedback() but after that it return Promise.resolve(true) to always return a Promise
   • so copyWithoutFeedback() can fail with just return Promise.reject() to always return a Promise
3. so we can create the function with feedback, copyWithFeedback(), that just calls the previous one, so, copyWithoutFeedback().then(function() { show_success_message() } ); with also a chained .fail( function() { show_error_message(); } ) or something similar

• Updates map

• Ignores async jshint

In D25536#15422, @avivey wrote:

I'll try to see if there's config for the jshint to allow async.

Well, now I have tried to satisfy every wish.

• use async/await for copy promise hell
• make the io button to just a type icon
• select entire text when clicking inside the input field
• patch JsShrink to shrink await/async syntax

(This Quickfix would help: https://github.com/vrana/JsShrink/pull/6/commits/5b2dd500d25b29ace2fbd76fc95b4518ef22abfc 😆 )

await/async won't go through the shrink process without destroying the entire syntax. And if it will go through this jsxmin binary, who can know? Note for the future: Maybe replace the entire shrink process with a new and used php shrinker like JShrink.

@avivey worst case is a syntax error because the operators are not known. Even that could be wrapped inside a try/catch.
@valerio.bozzolan could be done with the current behavior but this kind of implicit actions seems not the phorge way...?

In D25536#15395, @avivey wrote:

Yes, I insist on using the absolute required minimum of Promise-style coding.

I have to wait for the success or failure of the copy action, so I think this ui example makes no sense for my case. The notification should not be triggered by a button click.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

The overwriting of variables with media queries could be configured inside the theming class. So possible breakpoints can be part of a theming API.

And my general approach is: when the client can do something (and that even better), why should the server do it?

@avivey CSS vars are a vital part of modern modularized theming. They are versatile, can be overwritten with media queries or per class/element basis. They are editable in browser dev tools. If you would ask me: this step is pretty important.

In T15736#15726, @avivey wrote:

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

In T15039#1358, @bekay wrote:

The clone repo modal could really use some copy buttons.

Preferably replacing the Read / Write Button.

I don't know if that is part of this task, but the global typeahead search should hide all disabled users, wikis and repos, shouldn't it? This is nothing you want as a fast suggestion...

Just as a reminder for me: Using a css variable for the height of the tags would be best. I could be overwritten at any point.

Well, my idea would be:

• Updates map

• Fixes some js linting warnings

In T15630#15618, @aklapper wrote:

For consideration of the bigger picture, I'd like to mention https://collinmbarrett.com/block-web-fonts (performance etc) and for example Firefox 118+ blocking font fingerprinting in private windows (yes, private only, but I can vaguely imagine expansion).

Broader CSS discussion: T15734

I am honestly surprised by the notion, the user base of phorge is still using old, small or low resolution screens. I always thought this project was catered towards tech-savvy devs and/or corporations and will be used in contexts where a FullHD screen is the default case. Maybe we should sharpen our target audience 😅

In T15630#15566, @aklapper wrote:

In T15630#15561, @bekay wrote:

Times have changed and we all have very big screens.

Absolutely not. Maybe in some richer countries to some extent, but not on my mobile phone. (And even if that was true, scaling exists for a reason.)

And on another note: Times have changed and we all have very big screens. I think we should increase the default font size of 13px to 14px. It is about time...

In T15630#15553, @sirocyl wrote:

Of these, I like 1 and 3 (Noto and Inter) better. How does Atkinson look? (I haven't gotten around to changing the font on my end yet, heh)

Here you can see the fonts with Phorge itself. For me the clear winner is Noto Sans. It can add some real modern style to the site.

I like the first three the most.

Maybe I should create a slowvote poll to reach a decision?

Or what about Inter? It is open source and looks very readable: https://rsms.me/inter/

I have landed my solution.

The new font family styles does look not very nice on macOS, look at the bold texts...