Page MenuHomePhorge
Feed All Stories

Jan 15 2024

aklapper added a subtask for T15123: Javelin Support stuff: T15669: Document how to install javelinsymbols.
Jan 15 2024, 09:29
aklapper added a parent task for T15669: Document how to install javelinsymbols: T15123: Javelin Support stuff.
Jan 15 2024, 09:29
aklapper renamed T15123: Javelin Support stuff from Javeline Support stuff to Javelin Support stuff.
Jan 15 2024, 09:28
valerio.bozzolan awarded T15711: Ponder: "New Answer" input box should be hidden for those without permissions. a Grey Medal token.
Jan 15 2024, 09:22 · Ponder, Bug Reports, UX
valerio.bozzolan updated the answer details for Q103: Ponder: "New Answer" input box should be hidden for those without permissions. (Answer 131).
Jan 15 2024, 09:22
sirocyl added a comment to Q103: Ponder: "New Answer" input box should be hidden for those without permissions. (Answer 131).

Done; see T15711.

Jan 15 2024, 05:45
sirocyl closed Q103: Ponder: "New Answer" input box should be hidden for those without permissions. as resolved.
Jan 15 2024, 05:45 · UX
sirocyl created T15711: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 15 2024, 05:41 · Ponder, Bug Reports, UX

Jan 14 2024

aklapper added a comment to D25484: fix PHP 8 "strlen(null)" when moving paths with missing options.

@jeanguyomarch: Hi, would you like to arc land your accepted patch?

Jan 14 2024, 23:41
aklapper added a comment to T15659: Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception).

My initial choice of words was wrong: It's not "duplicated". SELECT * FROM differential_difftransaction WHERE dateCreated > 1705224003; shows two transactions differing in id, phid and transactionType (differential:diff:create versus core:view-policy).

Jan 14 2024, 23:35
aklapper requested review of D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Jan 14 2024, 23:33
aklapper added a revision to T15659: Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception): D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Jan 14 2024, 23:33
aklapper updated the task description for T15659: Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception).
Jan 14 2024, 17:41
aklapper renamed T15659: Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception) from Duplicated Transaction log entry for Diff creation (and PHP 8.1 exception) to Transaction log entries for policy of manually created Diff lack label in Feed (which triggers a PHP 8.1 exception).
Jan 14 2024, 17:35
aklapper added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

I'm just unsure between implode() or phutil_implode_html()

Jan 14 2024, 17:05 · UX
valerio.bozzolan closed D25507: Config User Extra Fields: link to the doc (like Maniphest).
Jan 14 2024, 14:40
valerio.bozzolan committed rP5de10185ce5b: Config User Extra Fields: link to the doc (like Maniphest).
Config User Extra Fields: link to the doc (like Maniphest)
Jan 14 2024, 14:40
valerio.bozzolan added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

I'm just unsure between implode() or phutil_implode_html()

Jan 14 2024, 14:35 · UX
valerio.bozzolan added a comment to D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.

Thanks again for this change. Please try "landing" with these two commands:

Jan 14 2024, 14:29
speck accepted D25516: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types.
Jan 14 2024, 13:43
valerio.bozzolan awarded T15656: Clicking "Clone" in a Diffusion repo gives an error a Like token.
Jan 14 2024, 11:49 · PHP 8 support, Diffusion
aklapper closed T15656: Clicking "Clone" in a Diffusion repo gives an error, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Jan 14 2024, 11:48 · PHP 8 support
aklapper closed T15656: Clicking "Clone" in a Diffusion repo gives an error as Resolved.

https://we.phorge.it/source/phorge/browse/master/src/applications/repository/storage/PhabricatorRepository.php$348 got fixed by rP222a6fea0a1d9318198fe73a0501cf6444420ce3 in T15658, thus resolving

Jan 14 2024, 11:48 · PHP 8 support, Diffusion
aklapper added a comment to D25515: Avoid exception setting project profile image when GD not installed.

Do we have a setup-warning about the gd extension being missing?

Jan 14 2024, 11:24
aklapper requested review of D25516: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types.
Jan 14 2024, 11:18
aklapper added a revision to T15710: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types: D25516: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types.
Jan 14 2024, 11:18 · PHP 8 support
aklapper created T15710: preg_match() null exception setting custom user profile image with empty files.viewable-mime-types.
Jan 14 2024, 11:17 · PHP 8 support
aklapper added a comment to T15669: Document how to install javelinsymbols.

(see also https://secure.phabricator.com/T2378 which links D5561, D5968, D5670 for those not logged in.)

Jan 14 2024, 10:41
aklapper accepted D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

I believe I had some weird aggressive local browser cache pollution with rPaa8af1d79e8bfeb09e72d5e3b9330780e78b7aeb as I cannot reproduce the wordmark problem anymore, so: LGTM

Jan 14 2024, 09:13 · UX
aklapper closed T15666: Align logo image and text in site header as Resolved.

As the patch was merged I assume that this issue is resolved. If not, then please reopen - thanks!

Jan 14 2024, 09:10 · Phorge
avivey accepted D25515: Avoid exception setting project profile image when GD not installed.

Do we have a setup-warning about the gd extension being missing?

Jan 14 2024, 08:32

Jan 13 2024

aklapper closed T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark as Resolved by committing rARC6c7caf3572f4: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 21:05 · Differential
aklapper closed D25514: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 21:05
aklapper committed rARC6c7caf3572f4: Correct manual upload of Differential patch with a leading BOM.
Correct manual upload of Differential patch with a leading BOM
Jan 13 2024, 21:05
aklapper requested review of D25515: Avoid exception setting project profile image when GD not installed.
Jan 13 2024, 20:54
aklapper added a revision to T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring(): D25515: Avoid exception setting project profile image when GD not installed.
Jan 13 2024, 20:54 · Files, PHP 8 support
speck accepted D25514: Correct manual upload of Differential patch with a leading BOM.

Thanks - I did mean as an inline comment in the code but either is good.

Jan 13 2024, 19:58
aklapper updated the summary of D25514: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 18:49
aklapper added a comment to D25514: Correct manual upload of Differential patch with a leading BOM.

Is the input to parseDiff guaranteed to be UTF-8 encoded?

Jan 13 2024, 18:45
valerio.bozzolan added inline comments to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Jan 13 2024, 17:54
speck added a comment to D25514: Correct manual upload of Differential patch with a leading BOM.

Is the input to parseDiff guaranteed to be UTF-8 encoded? I don’t have the code on-hand to look up but it’s possible encoding is handled elsewhere — or arc might have a hard requirement for all input to be UTF-8. All mercurial commands run by arcanist are done with a flag to enforce UTF-8.

Jan 13 2024, 15:51
speck added a comment to T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

Jan 13 2024, 15:42 · Differential
aklapper updated the task description for T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().
Jan 13 2024, 14:32 · Files, PHP 8 support
aklapper added a comment to T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.

I'm tempted to just change that one line to $left = idx($view_data, 'left', 0); so there shoud not be a crash at this stage anymore but instead the default value 0 is passed to the DifferentialDiffQuery and to the new DifferentialTransactionView... but I lack a reproducer to check if all other code is fine with this.

Jan 13 2024, 13:35
aklapper closed T15511: Do not require the real name during registration as Invalid.

PHP 8.2.14, Phorge at cc964550f945b08c64970c01a34b55314e8ef0aa

  1. As an admin, check that /config/edit/user.require-real-name/ is set to Make real names optional
  2. Log out of Phorge
  3. Go to http://phorge.localhost/auth/register/
  4. See that the Real Name field does not state Required on the right
  5. Enter values into the fields Username, Password, Confirm Password, Email
  6. Click the Register Account button
Jan 13 2024, 11:46 · Auth
avivey added a comment to T15565: Phorge Extension for Phorge.it.

I've created R10 PhorgeIt Extension for this, with a little bit of content. I'll load it to the server shortly.

Jan 13 2024, 11:27 · Phorge Development Tools, phorge.it install
avivey committed R10:86dda1c5bb63: Start phorge.it extension.
Start phorge.it extension
Jan 13 2024, 11:27
aklapper added a comment to T15511: Do not require the real name during registration.

Reference: rPdfcccd4cb882a171d10ba8a5c2763dcc73654256

Jan 13 2024, 10:55 · Auth
aklapper added a revision to T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark: D25514: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 10:21 · Differential
aklapper requested review of D25514: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 10:21
avivey added a comment to T15701: Clarify that a Project is just a "Tag".

+lots for removing the words "storage containers" - projects are very much not "storage".
A better metaphor is "labels" or "index" (like in a printed book? Is that something young people know about?).

Jan 13 2024, 10:21 · UX, Projects
avivey added a project to T15582: Allow blocking users: Clarification Needed.
Jan 13 2024, 10:14 · Clarification Needed
avivey added a comment to T15705: Lower the search ranking of disabled user accounts.

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.

Jan 13 2024, 10:12 · UX
avivey created T15709: modernize the "add item to menu" flow to deprecate EventListener.
Jan 13 2024, 10:11
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

+1 on Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses.

Jan 13 2024, 03:06 · Discussion Needed, Governance
aklapper added a comment to T15582: Allow blocking users.

clarify why the Disable User button [...] not sufficient for this purpose.

Jan 13 2024, 03:01 · Clarification Needed
aklapper added a comment to T15701: Clarify that a Project is just a "Tag".

I'd like to keep this boring:
Projects are hashtags are tags. You can use them for code bases, teams, or anything you need to group.

Jan 13 2024, 02:54 · UX, Projects
aklapper renamed T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark from Differntial drops a diff's first hunk if the file starts with a Byte-order-Mark to Differential drops a diff's first hunk if the file starts with a Byte-order-Mark.
Jan 13 2024, 02:50 · Differential
aklapper updated aklapper.
Jan 13 2024, 02:43
aklapper accepted D25507: Config User Extra Fields: link to the doc (like Maniphest).
Jan 13 2024, 02:37
aklapper closed T15707: Long labels overlap in Add Action area as Resolved by committing rPcc964550f945: Ellipsize long labels in Add Action area to avoid text overlap.
Jan 13 2024, 02:30
aklapper closed D25511: Ellipsize long labels in Add Action area to avoid text overlap.
Jan 13 2024, 02:30
aklapper committed rPcc964550f945: Ellipsize long labels in Add Action area to avoid text overlap.
Ellipsize long labels in Add Action area to avoid text overlap
Jan 13 2024, 02:30

Jan 12 2024

speck added inline comments to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Jan 12 2024, 22:51
valerio.bozzolan updated the test plan for D25504: Fix "Map omits required key" exception by comparing result order against modern field keys.
Jan 12 2024, 22:14
valerio.bozzolan awarded T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field a Yellow Medal token.
Jan 12 2024, 22:12 · Affects-Wikimedia, Bug Reports
valerio.bozzolan accepted D25511: Ellipsize long labels in Add Action area to avoid text overlap.

Do you mean "action"? If yes, I can reproduce

Jan 12 2024, 22:00
valerio.bozzolan updated the test plan for D25511: Ellipsize long labels in Add Action area to avoid text overlap.
Jan 12 2024, 22:00
valerio.bozzolan accepted D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

Indeed this fixes the problem. Premising there is still some mystery here that may deserve additional eyes.

Jan 12 2024, 21:54
valerio.bozzolan added inline comments to rPed7a5078f954: Add "user" and "users" standard custom fields.
Jan 12 2024, 21:53
valerio.bozzolan updated the diff for D25507: Config User Extra Fields: link to the doc (like Maniphest).

Sentence case <3

Jan 12 2024, 21:45
valerio.bozzolan abandoned D25078: Trigger: Capitalize most Buzzwords in our Weird Way as usual.

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

Jan 12 2024, 21:44
valerio.bozzolan closed T15692: Allow to see your own public revoked key as Resolved by committing rP549a26d0879c: Auth SSH Details: show Public Key (not just Type).
Jan 12 2024, 21:34 · UX, User-valerio.bozzolan, Auth
valerio.bozzolan closed D25495: Auth SSH Details: show Public Key (not just Type).
Jan 12 2024, 21:34
valerio.bozzolan committed rP549a26d0879c: Auth SSH Details: show Public Key (not just Type).
Auth SSH Details: show Public Key (not just Type)
Jan 12 2024, 21:34
valerio.bozzolan added a member for Trusted Contributors: Harej.
Jan 12 2024, 21:06
doommius added a comment to T15708: Discord as auth method.

Sounds easy enough to implement.

Jan 12 2024, 18:44 · Auth
avivey added inline comments to D25513: Work in progress discord auth.
Jan 12 2024, 17:16
avivey added a comment to T15708: Discord as auth method.

Doc(s) on new extensions: I remember having a chapter under /book/contrib/, but I can't find it now. We should build a guide under T15030.
Short answer: create a new repo, make an src dir with all the code, and run arc liberate to create a "library" (including __phutil_library_init__.php and __phutil_library_map__.php), and then add the path of the extension to load-libraries in conf.json.

Jan 12 2024, 17:02 · Auth
mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

I copy/pasted the keys of the getStyleMap() function dictionary into chatgpt with some remark that they were part of a syntax highlighting mechanism.
I asked it to translate them into something more readable.

Jan 12 2024, 16:25
doommius added a comment to T15708: Discord as auth method.

I'd like to see this as an Extension rather then go into the rP, just because we want to have more stuff as extensions; I think this area is abstracted enough so that it can easily be made that way.

That could be a good target as well for this, Is there docs on how extensions should be made?

Jan 12 2024, 14:21 · Auth
avivey added a comment to T15708: Discord as auth method.

I'd like to see this as an Extension rather then go into the rP, just because we want to have more stuff as extensions; I think this area is abstracted enough so that it can easily be made that way.

Jan 12 2024, 14:12 · Auth
valerio.bozzolan accepted D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.

Double-accept yeah

Jan 12 2024, 13:58
doommius updated the summary of D25513: Work in progress discord auth.
Jan 12 2024, 13:43
doommius updated the summary of D25513: Work in progress discord auth.
Jan 12 2024, 13:42
doommius updated subscribers of T15708: Discord as auth method.

@valerio.bozzolan & @avivey What is the best practice for setting up the role/server check when new users attempt to auth via the oauth, you can't set limits on the oauth from discords side of view so you'd need to set them up on phorge, I've put down some ideas in the above comment.

Jan 12 2024, 13:33 · Auth
doommius added a comment to D25513: Work in progress discord auth.

Also, apart from the linter results, this patch should not include the changes from D25512

Jan 12 2024, 13:29
speck accepted D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Jan 12 2024, 13:23
doommius added a comment to T15708: Discord as auth method.

How would i go about implementing it such that for a user to sign in with discord they need to have certain roles.

Jan 12 2024, 13:13 · Auth
doommius added a comment to D25513: Work in progress discord auth.

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

Jan 12 2024, 12:52
valerio.bozzolan awarded D25513: Work in progress discord auth a Grey Medal token.
Jan 12 2024, 12:49
valerio.bozzolan added a comment to D25513: Work in progress discord auth.

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

Jan 12 2024, 12:48
aklapper added a comment to D25513: Work in progress discord auth.

Also, apart from the linter results, this patch should not include the changes from D25512

Jan 12 2024, 12:26
aklapper updated the diff for D25503: Allow to uninstall (hide) Audit application.

Also hide "Buckets" search field on diffusion/commit/query/advanced/ when Audit is uninstalled

Jan 12 2024, 12:25
aklapper added a comment to D25507: Config User Extra Fields: link to the doc (like Maniphest).

Yeah I honestly don't know if uppercase or lowercase.

Jan 12 2024, 12:12
aklapper updated the diff for D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

manual rebase

Jan 12 2024, 12:07
aklapper accepted D25495: Auth SSH Details: show Public Key (not just Type).

LGTM. Tested locally and works as expected, use case also makes sense, plus this is only about public keys.

Jan 12 2024, 12:03
aklapper retitled D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML from Fixed get title error when opening auth page, see T15706
Jan 12 2024, 11:58
doommius added a revision to T15708: Discord as auth method: D25513: Work in progress discord auth.
Jan 12 2024, 11:55 · Auth
doommius added a task to D25513: Work in progress discord auth: T15708: Discord as auth method.
Jan 12 2024, 11:55