Page MenuHomePhorge
Feed Advanced Search

Jan 13 2024

avivey added a comment to T15705: Lower the search ranking of disabled user accounts.

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.

Jan 13 2024, 10:12 · Spam mitigation, UX
avivey created T15709: modernize the "add item to menu" flow to deprecate EventListener.
Jan 13 2024, 10:11

Jan 12 2024

avivey added inline comments to D25513: Work in progress discord auth.
Jan 12 2024, 17:16 · Auth
avivey added a comment to T15708: Discord as auth method.

Doc(s) on new extensions: I remember having a chapter under /book/contrib/, but I can't find it now. We should build a guide under T15030.
Short answer: create a new repo, make an src dir with all the code, and run arc liberate to create a "library" (including __phutil_library_init__.php and __phutil_library_map__.php), and then add the path of the extension to load-libraries in conf.json.

Jan 12 2024, 17:02 · Auth
avivey added a comment to T15708: Discord as auth method.

I'd like to see this as an Extension rather then go into the rP, just because we want to have more stuff as extensions; I think this area is abstracted enough so that it can easily be made that way.

Jan 12 2024, 14:12 · Auth

Jan 10 2024

avivey awarded T15705: Lower the search ranking of disabled user accounts a Evil Spooky Haunted Tree token.
Jan 10 2024, 14:37 · Spam mitigation, UX
avivey updated subscribers of Q91: How can I tell phorge to use a different local.json file at runtime? (Answer 114).

@fgaz - did you find a solution for this?
For the "make Phorge extensions easy to install" feature (which I can't find the ticket for), I have a vague plan of adding another file describing available/installed extensions. I'd like to make packaging harder if I can avoid it, so possibly whatever solves local.json can solve this file too.

Jan 10 2024, 04:59

Jan 8 2024

avivey accepted D25508: Add support for FIDO2-backed SSH keys.

notmyfault

Jan 8 2024, 14:28

Jan 7 2024

avivey added a comment to D25505: Improve handling queries with "Current Viewer" set while not logged in.

Alternatively, maybe catch the existing exception and show a nice error message + the form?

Jan 7 2024, 09:57
avivey added a comment to D25505: Improve handling queries with "Current Viewer" set while not logged in.

the simplest other-solution would be to extract the exception thrown to its own method, and override that method in the child-class:

Jan 7 2024, 07:17
avivey added a comment to D25505: Improve handling queries with "Current Viewer" set while not logged in.

How about other functions that might require a logged-in user? "current Viewer's Projects" for example?

Jan 7 2024, 07:12

Jan 5 2024

siepkes awarded Blog Post: Winter Solstice 2023 Release a Party Time token.
Jan 5 2024, 16:13

Jan 4 2024

fgaz awarded Blog Post: Winter Solstice 2023 Release a Party Time token.
Jan 4 2024, 16:18

Jan 2 2024

avivey edited the content of Change Log.
Jan 2 2024, 19:42
avivey created Blog Post: Winter Solstice 2023 Release.
Jan 2 2024, 19:42
avivey renamed 2023 week 49 from 2023 week 49 RC to 2023 week 49.
Jan 2 2024, 19:41
avivey committed rARCca72430916af: Promote 2023.49 to Stable.
Promote 2023.49 to Stable
Jan 2 2024, 19:31
avivey committed rP43c969cd27d4: Promote 2023.49 to stable.
Promote 2023.49 to stable
Jan 2 2024, 19:28

Dec 27 2023

avivey created T15700: An "Integer" search field.
Dec 27 2023, 10:39
avivey added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

unknown magic accepts any kind of input (e.g. letters) and converts it into a 0.

Dec 27 2023, 10:35

Dec 24 2023

avivey added a comment to T15699: Inaccessible task: "Matched token key "3Z" while processing remarkup block, but this token does not exist in the token map.".

probably "low", but might be interesting to investigate.

Dec 24 2023, 10:31

Dec 23 2023

avivey added inline comments to D25479: Display default "Page Size" value in Maniphest Advanced Search form.
Dec 23 2023, 19:59
avivey accepted D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Yeah, looks like IntField isn't doing much now (yet?)

Dec 23 2023, 10:03

Dec 21 2023

avivey updated subscribers of T15698: Do not expose "Packages" field as Audit query form field when Packages application uninstalled.

@20after4 suggested an "is-application-installed"-aware class-finder recently - I wonder if that would also handle this?

Dec 21 2023, 07:32

Dec 18 2023

avivey added a comment to T15695: Maintain Arcanist in Debian.

Phacility was very much against this kind of things, but I actually favor supporting some packages, at least for Arcanist on the big package-managers - if nothing else, it would allow us to make sure the package with the right name is doing the right thing.

Dec 18 2023, 17:14 · Arcanist, Phorge
avivey added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

I keep arcanist cloned in /home/kuba/bin/arcanist. /home/kuba/bin/arc is this executable file:

Dec 18 2023, 10:22

Dec 16 2023

avivey added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

also, arc get-config hosts --verbose - but note that it will actually print out the tokens, hide those.

Dec 16 2023, 17:55
avivey added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

That's odd...

  • do you have an entry for "https://we.phorge.it/api/" in your ~/.arcrc ?
  • I'm also confused about the --trace not including any comment about loading any configuration source - that's probably a bug
  • how about echo {} | arc --trace call-conduit -- user.whoami ? in the phorge dir and in other dirs?
  • I'm assuming /home/kuba/bin/arc is a symlink to arc that's in ~/Downloads/arc?
Dec 16 2023, 17:47

Dec 15 2023

avivey added a comment to T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.

The highlighting process could track elapsed time and stop highlighting any further documents after a fixed amount of time elapses...

Dec 15 2023, 08:51
avivey awarded T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork a Like token.
Dec 15 2023, 08:51
avivey closed Q93: The latest changes aren't reflected in the Setup Guide as resolved.
Dec 15 2023, 08:48

Dec 14 2023

avivey added a comment to T15692: Allow to see your own public revoked key.

Since we already show the full (public) key when editing, then I don't see a reason not to show it after it's revoked.

Dec 14 2023, 09:03 · UX, User-valerio.bozzolan, Auth

Dec 12 2023

avivey added Q100: Undefined method when using celelery map on commit 2295bcda (Answer 127).
Dec 12 2023, 19:31

Dec 10 2023

avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).

1b. Did you restart FastCGI after updating the code?

Dec 10 2023, 14:56
avivey closed Q99: permission to report a bug as resolved.
Dec 10 2023, 14:47
avivey added Q99: permission to report a bug (Answer 125).
Dec 10 2023, 14:46
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
  1. Yes, you should have D25387 - which makes it very strange that you're getting an exception.
  2. That's the trace, yes.
  3. I've added you to Trusted Contributors, so you can file bugs in maniphest, etc.
Dec 10 2023, 14:46
avivey added a member for Trusted Contributors: adrelanos.
Dec 10 2023, 14:46

Dec 9 2023

avivey marked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123) as hidden.
Dec 9 2023, 08:46
avivey accepted D25424: Curtain: add Hovercard support.
Dec 9 2023, 08:44

Dec 8 2023

avivey renamed 2023 week 49 from 2023.49 RC to 2023 week 49 RC.
Dec 8 2023, 17:38
avivey edited the content of Change Log.
Dec 8 2023, 17:38
avivey closed T15554: Handling PHP deprecations: convert to Setup Issues as Resolved.

Unless something broke, this task is now complete.

Dec 8 2023, 17:37 · Phorge
avivey renamed 2023 week 49 from Next Up to 2023.49 RC.
Dec 8 2023, 17:36
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Dec 8 2023, 16:05
avivey created T15690: PhutilErrorHandler - add try/catch around `call_user_func`.
Dec 8 2023, 16:04
avivey closed D25440: Show Deprecation Warnings as Setup Warnings.
Dec 8 2023, 15:56
avivey committed rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings.
Show Deprecation Warnings as Setup Warnings
Dec 8 2023, 15:56
avivey created T15689: built in exception display is missing top line.
Dec 8 2023, 15:54 · Phorge Development Tools
avivey edited the content of Report Warnings.
Dec 8 2023, 15:42
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • add PHP version
  • rebase
Dec 8 2023, 15:41
avivey added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).
Dec 8 2023, 08:36

Dec 6 2023

avivey updated the answer details for Q96: Support for FIDO2-backed SSH keys (Answer 120).
Dec 6 2023, 16:10
avivey added Q96: Support for FIDO2-backed SSH keys (Answer 120).
Dec 6 2023, 16:01
avivey awarded Q96: Support for FIDO2-backed SSH keys a Orange Medal token.
Dec 6 2023, 15:55
avivey added Q97: Unable to submit patch via arc diff (Answer 119).
Dec 6 2023, 15:50
avivey added Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 118).
Dec 6 2023, 08:21

Dec 5 2023

avivey added a member for Trusted Contributors: kuba-orlik.
Dec 5 2023, 21:42
avivey added Q92: Cannot submit a revision - mysql problems? (Answer 116).
Dec 5 2023, 21:42
avivey added Q93: The latest changes aren't reflected in the Setup Guide (Answer 115).
Dec 5 2023, 21:36

Dec 3 2023

avivey planned changes to D25440: Show Deprecation Warnings as Setup Warnings.

add PHP version information to the view.

Dec 3 2023, 07:31

Dec 1 2023

avivey added a comment to D25472: Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use junit output rather than json..

I'm just glossing over this - is ArcanistPhpunitTestResultParser now learning to parse generic "junit style xml" format?

Dec 1 2023, 20:57
avivey added Q91: How can I tell phorge to use a different local.json file at runtime? (Answer 114).
Dec 1 2023, 09:34
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Dec 1 2023, 09:05
fgaz awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Dec 1 2023, 08:09 · Differential, Feature Requests

Nov 30 2023

avivey removed a reviewer for D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider: Matthew.
Nov 30 2023, 07:39

Nov 29 2023

avivey added a comment to Q90: Phorge storage upgrade error coming from Phabricator.

If you can hop on IRC/Conpherence in about 4 hours (around 20:00 UTC), I can try debugging this interactively.

Nov 29 2023, 16:17 · Phorge
avivey updated the question details for Q90: Phorge storage upgrade error coming from Phabricator.
Nov 29 2023, 16:09 · Phorge
avivey added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

maybe use an PhabricatorSearchIntField with a default provided in the buildCustomSearchFields() ?

Nov 29 2023, 16:06
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

mmm, ok.

Nov 29 2023, 16:03
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

What kind of operation are you doing that involves loading all tasks in a browser?

Nov 29 2023, 14:19
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

If this is the only place where we have a "limit"/"page size" field, maybe just remove it?

Nov 29 2023, 08:50

Nov 27 2023

avivey added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Is this the only place where we have a "Page size" exposed in the search?

Nov 27 2023, 18:40
avivey accepted D25480: Remove Chatlog entirely.

Let the Purge begin!

Nov 27 2023, 18:34
avivey added inline comments to D25440: Show Deprecation Warnings as Setup Warnings.
Nov 27 2023, 18:32
avivey closed D25388: PhutilErrorHandler: support multiple error listeners.
Nov 27 2023, 18:32
avivey committed rARC25611ba24add: PhutilErrorHandler: support multiple error listeners.
PhutilErrorHandler: support multiple error listeners
Nov 27 2023, 18:32
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • rm commented out code
Nov 27 2023, 18:16
avivey added a comment to D25388: PhutilErrorHandler: support multiple error listeners.

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

Nov 27 2023, 18:06
avivey created T15677: Probably delete Log Write Check code.
Nov 27 2023, 18:04

Nov 25 2023

avivey added a comment to T15671: Allow to import Picture from Gravatar.

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Nov 25 2023, 14:49 · User-valerio.bozzolan, People
avivey requested changes to D25477: Visually indicate new user accounts.

I aslo don't see the point of this feature, but that's another issue.

Nov 25 2023, 14:24
avivey added a comment to T15675: Visually indicate new user accounts.

I don't see the point in having this feature. What is it for?

Nov 25 2023, 14:21 · Feature Requests

Nov 24 2023

avivey renamed Report Warnings from Report-warnings to Report Warnings.
Nov 24 2023, 18:27
avivey created Deprecation Notice.
Nov 24 2023, 18:16
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • update some copy
Nov 24 2023, 17:46
avivey updated the diff for D25388: PhutilErrorHandler: support multiple error listeners.
  • cleanup
Nov 24 2023, 17:12
avivey updated the test plan for D25388: PhutilErrorHandler: support multiple error listeners.
Nov 24 2023, 17:10
avivey updated the title for P26 test-logs-multilistener.php from Command-Line Input to test-logs-multilistener.php.
Nov 24 2023, 17:09
avivey created P26 test-logs-multilistener.php.
Nov 24 2023, 17:09

Nov 19 2023

avivey added a comment to Q84: Unable to receive verification email from we.phorge.it.

@l2dy are you using an Outlook.com address? we have T15059 which is hard to nail down.

Nov 19 2023, 09:18
avivey reopened T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers as "Open".
Nov 19 2023, 09:14 · Diffusion, Discussion Needed
avivey added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

From a product POV, I agree with @valerio.bozzolan - there is (sometimes) some information on commits that would be nice to index in a search engine - comments, mostly.

Nov 19 2023, 09:01 · Diffusion, Discussion Needed

Nov 5 2023

avivey awarded Q81: Documentation for "Restarting Phabricator" is missing a Grey Medal token.
Nov 5 2023, 07:42 · Phorge

Nov 2 2023

avivey added Q79: Is arc.land.onto.default configuration deprecated? (Answer 107).
Nov 2 2023, 19:49

Oct 27 2023

avivey accepted D25451: Remove unused variable $info in DiffusionCloneController.php.
Oct 27 2023, 08:12

Oct 26 2023

avivey resigned from D25118: Remarkup: make less internal links open in new tabs.

I don't have much of an attention span these days, sorry.

Oct 26 2023, 11:32

Oct 16 2023

avivey accepted D25447: Dashboard Panel: fix first tab sometime not opened anymore.
Oct 16 2023, 06:19

Oct 12 2023

avivey closed D25446: only update cache file if something changed.
Oct 12 2023, 16:22
avivey committed rARC98d16d27cf3e: only update cache file if something changed.
only update cache file if something changed
Oct 12 2023, 16:22