Paths

Table of Contentst

-
src/applications/audit/query/
-
applications/
-
audit/
-
query/
-
PhabricatorCommitSearchEngine.php

Differential D25506

Hide "Packages" field in Diffusion Commits query form when application uninstalled
ClosedPublic
Actions

Authored by aklapper on Jan 4 2024, 12:00.

Details

Reviewers

20after4

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15698: Do not expose "Packages" field as Audit query form field when Packages application uninstalled

Commits

rPd92ed9ce0c0c: Hide "Packages" field in Diffusion Commits query form when application…

Summary

Fixes T15698

Test Plan

Uninstall Packages via /applications/view/PhabricatorPackagesApplication/
Go to /diffusion/commit/, expand the Query form, and see that Packages is not shown anymore

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jan 4 2024, 12:00

Owners added a reviewer: O1: Blessed Committers.Jan 4 2024, 12:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 4 2024, 12:00

aklapper requested review of this revision.Jan 4 2024, 12:00

Harbormaster completed remote builds in B1003: Diff 1611.Jan 4 2024, 12:00

20after4 accepted this revision.Jan 5 2024, 02:01

This revision is now accepted and ready to land.Jan 5 2024, 02:01

Closed by commit rPd92ed9ce0c0c: Hide "Packages" field in Diffusion Commits query form when application…. · Explain WhyJan 6 2024, 15:26

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPd92ed9ce0c0c: Hide "Packages" field in Diffusion Commits query form when application….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

audit/

query/

PhabricatorCommitSearchEngine.php

3 lines

O1: Blessed Committers

Diff 1612

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines	protected function buildQueryFromParameters(array $map) {
if ($map['identifiers']) {		if ($map['identifiers']) {
$query->withIdentifiers($map['identifiers']);		$query->withIdentifiers($map['identifiers']);
}		}

return $query;		return $query;
}		}

protected function buildCustomSearchFields() {		protected function buildCustomSearchFields() {
		$show_packages = PhabricatorApplication::isClassInstalled(
		'PhabricatorPackagesApplication');
return array(		return array(
id(new PhabricatorSearchDatasourceField())		id(new PhabricatorSearchDatasourceField())
->setLabel(pht('Responsible Users'))		->setLabel(pht('Responsible Users'))
->setKey('responsiblePHIDs')		->setKey('responsiblePHIDs')
->setConduitKey('responsible')		->setConduitKey('responsible')
->setAliases(array('responsible', 'responsibles', 'responsiblePHID'))		->setAliases(array('responsible', 'responsibles', 'responsiblePHID'))
->setDatasource(new DifferentialResponsibleDatasource())		->setDatasource(new DifferentialResponsibleDatasource())
->setDescription(		->setDescription(
Show All 32 Lines	return array(
->setDatasource(new DiffusionRepositoryFunctionDatasource())		->setDatasource(new DiffusionRepositoryFunctionDatasource())
->setDescription(pht('Find commits in particular repositories.')),		->setDescription(pht('Find commits in particular repositories.')),
id(new PhabricatorSearchDatasourceField())		id(new PhabricatorSearchDatasourceField())
->setLabel(pht('Packages'))		->setLabel(pht('Packages'))
->setKey('packagePHIDs')		->setKey('packagePHIDs')
->setConduitKey('packages')		->setConduitKey('packages')
->setAliases(array('package', 'packages', 'packagePHID'))		->setAliases(array('package', 'packages', 'packagePHID'))
->setDatasource(new PhabricatorOwnersPackageDatasource())		->setDatasource(new PhabricatorOwnersPackageDatasource())
		->setIsHidden(!$show_packages)
->setDescription(		->setDescription(
pht('Find commits which affect given packages.')),		pht('Find commits which affect given packages.')),
id(new PhabricatorSearchThreeStateField())		id(new PhabricatorSearchThreeStateField())
->setLabel(pht('Unreachable'))		->setLabel(pht('Unreachable'))
->setKey('unreachable')		->setKey('unreachable')
->setOptions(		->setOptions(
pht('(Show All)'),		pht('(Show All)'),
pht('Show Only Unreachable Commits'),		pht('Show Only Unreachable Commits'),
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines

Hide "Packages" field in Diffusion Commits query form when application uninstalledClosedPublicActions