Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

In D25488#14099, @aklapper wrote:

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

Tested. No nuclear implosions :) Thanks!

If the patch was written by 20after4 we can probably set git commit --amend --author="Mukunda Modell". Can I help in this?

I think that the value may be an int, so, causing a nuclear implosion. Probably nice to check for a concrete populated example, and eventually do line 27 or similar ones.

In the future it may be nice to also have a getArgStr() that always return a string, never NULL. So, we can just if ( $to === '' )

Nobody seems interested in my concern, so, hard approve :) Thanks

Thanks for your help @valerio.bozzolan, It appears I had missed that part!..oops...I'll give that a try over the weekend.

My steps to reproduce are wrong / unclear / not always happening.

This partially fixes the problem:

In D25374#10923, @Matthew wrote:

Please fix unit errors

Probably this happens while creating a new project and doing that thing again 🤔

Nobody replied for months. I basically like the disclaimer and I basically trust your test in your production. Thanks.

I suggest to accept with "whatcouldgowrong" \o/

Thanks bob. Just to say that I care about your code proposals and sorry if this needed extra time.

(Indeed I agree we cannot bulk edit things - PHP 8.1 is a nightmare - see T15190)

Interestingly, Gerrit does similar things, and does not mention the problematic URI value in case it's somehow already clear:

Cool. Two things:

(maybe this happens if you have just one provider and it's an OAuth)

Interestingly this cannot be reproduced in any public Phorge:

Other edges have probably been eliminated in the past. For example this one:

I sincerely thought that "Obsolete" was the good one semantically.

I think a dedicated policy for "Can send messages" would be better, to cover more cases. It would be strange that all participants must also be allowed to edit all settings.

Is this only related to the "Authored on ..." field, as far as you can see?

I cannot reproduce anymore. This does not happen anymore in latest master.

Sorry if I've found two additional interesting things:

I'm not an important stakeholder, but I would like to share that in my installation https://gitpull.it I would like to have commits indexed as default as it happened as default and as it happens in GitHub and GitLab. So I'm now sincerely trying to understand how to restore the old behavior without keeping my own fork of Phorge if needed.

Thanks for the deep inspection! Tested and I agree

Side note, we are introducing the possibility to share this kind of very creative and confusing URLs (that are safe from the point of view of XSS but) that could be an attracting point for lamers to generate confusing user messages inside Phorge itself, like:

Thanks for landing!

This is something that may be not appreciated by some people.

Happy you fixed!

JavaScript: ✅ I damn like your proposal and I think it is very OK, non-plus-ultra

So this is the only blocking Test that is failing:

We have just a minor issue but with a potentially working fix, and it's ready to land

I don't know. Let's see :)

avoid micro-optimizations that make this unreadable