I went to https://we.phorge.it/D25018 and that URL says:
Received unexpected type for href: PhutilURI. Please paste this log as comment in https://we.phorge.it/T15316

Thanks for finding that! Yes, makes a lot of sense to reduce that scope

Make change less intrusive/dangerous by reducing CSS scope to "type=file" input

I currently don't have time to work on this so feel free to improve the diff (via arcanist/bin/arc patch D25296 / arcanist/bin/arc diff --update D25296).

ran ./bin/celerity map

Ran ./bin/celerity map

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.

In T15547#11813, @avivey wrote:

Is there anything that generates this URL? Is there a broken link generated anywhere?

Found a related old upstream: https://secure.phabricator.com/T10326

Strawman proposal:

• Rename "Additional Hashtags" to "Project Name Aliases"
• Rename "Hashtags" to "Project Name Aliases"
• Rename "Tags" to "Projects"

In T15498#11487, @valerio.bozzolan wrote:

OK I can reproduce now. I was missing the php-gd extension for some reasons.

Good content but unfortunately undiscoverable if not linked from a form preamble

Remove already implemented text parts

1. This is a feature request, it should be defined using Feature Request pattern, not Bug Report pattern.

I'd say "This account has been disabled" is way clearer than... nothing? :P

Looks like a mid-air collision, heh :)

Looks like a mid-air collision, heh :)

I don't get the code.
src/applications/diffusion/controller/DiffusionIdentityViewController.php (note the View in its name) includes stuff like
$edit_uri = $this->getApplicationURI("identity/edit/{$id}/") defining ->setName(pht('Edit Identity')) (note the Edit here).
Also, this mashes up Diffusion and Repositories to add confusion (DiffusionIdentityEditController calls PhabricatorRepositoryIdentityEditEngine?).
I think I give up.

Hopefully fix unit test by running arc liberate locally first

In D25321#9358, @Cigaryno wrote:

The assertion for Harbormaster Unit 10862 has failed. Does anyone know why?

In T15129#11054, @Cigaryno wrote:

.. and vice versa

In T15326#11073, @Cigaryno wrote:

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

Patch in P13 is incomplete, policy does not cover going to /diffusion/identity/edit/1/ and setting Assigned To to another user but should.

In T15443#9918, @avivey wrote:

It also might make sense to hide the actual list from the general public (it's a mapping of emails to users).

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

Eh, grep'ing the source, src/applications/metamta/engine/PhabricatorMailSMSEngine.php seems to be the only place reading those values.

In D25300#8786, @Sten wrote:

IMHO we should just do a global replacement on all 'if (strlen(<someVar>)) and have done with it. I have done this on my phabricator copy to get it working.

I've tested the new revision with the soft error and this is a way better UX - thanks!

Then let's decline this ticket to reflect the status.

fix capitalization