Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Yesterday

aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

In T15640#19898, @valerio.bozzolan wrote:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Tue, Dec 17, 17:24 · Affects-Wikimedia

Wed, Dec 11

aklapper requested review of D25855: JSON rendering: Avoid exception iterating on non-iterable objects.

Wed, Dec 11, 20:14

aklapper accepted D25854: Phriction: fix issue with icons in table of contents on wide screens.

Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.

Wed, Dec 11, 19:16

aklapper added a comment to D25673: Fix error in Mercurial when no offset is specified.

@jeffrey: Would you like to arc land your patch to get it merged?

Wed, Dec 11, 10:48

aklapper added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.

@bekay: Would you like to merge this?

Wed, Dec 11, 10:46

aklapper accepted D25850: Allow customizing default Phurl view and edit policies.

Wed, Dec 11, 10:38

Tue, Dec 10

aklapper added a project to T15074: Hide profile pictures and descriptions of disabled users: Spam mitigation.

Tue, Dec 10, 14:35 · Spam mitigation, Security

aklapper added a comment to D25775: Do not re-subscribe @mentions when editing task description.

In D25775#21206, @valerio.bozzolan wrote:

More understanding on the root cause is needed. Probably the root cause is "just" that getOldValue() returns an empty string. In that case we should probably at least understand what object is that (sub-class of PhabricatorTransactionRemarkupChange?) and we probably we need something like a generateOldValue() or something similar.

Tue, Dec 10, 11:59

aklapper updated the summary of D25774: Strike through archived projects in navigation crumbs.

Tue, Dec 10, 11:11

aklapper accepted D25846: Fix Diffusion commands in non-English environments.

After installing subversion and setting LC_ALL instead of LANG I can finally reproduce on a Fedora 40 system:

Tue, Dec 10, 09:52

aklapper updated the test plan for D25846: Fix Diffusion commands in non-English environments.

Tue, Dec 10, 09:46

aklapper requested changes to D25850: Allow customizing default Phurl view and edit policies.

Oh true, got it. Have to replace PhabricatorPolicyCapability::POLICY_ADMIN, with 'capability' => PhabricatorPolicies::POLICY_ADMIN, here

Tue, Dec 10, 09:31

aklapper updated the test plan for D25850: Allow customizing default Phurl view and edit policies.

Tue, Dec 10, 09:30

aklapper added inline comments to D25850: Allow customizing default Phurl view and edit policies.

Tue, Dec 10, 09:24

Mon, Dec 9

aklapper closed T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data as Resolved by committing rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Mon, Dec 9, 11:00

aklapper committed rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data

Mon, Dec 9, 11:00

aklapper closed D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Mon, Dec 9, 11:00

Fri, Dec 6

aklapper closed T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Fri, Dec 6, 12:17 · PHP 8 support

aklapper closed D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Fri, Dec 6, 12:17

aklapper closed T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails as Resolved by committing rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Fri, Dec 6, 12:17 · PHP 8 support

aklapper committed rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test

Fri, Dec 6, 12:17

aklapper updated the diff for D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Right... one day I may get used to all those Phorge shortcuts, thanks

Fri, Dec 6, 11:58

aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Oops, no for real

Fri, Dec 6, 11:49

aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Uhm, right, heh

Fri, Dec 6, 11:48

Thu, Dec 5

aklapper added a revision to T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data: D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Thu, Dec 5, 22:38

aklapper requested review of D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Thu, Dec 5, 22:38

aklapper created T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data.

Thu, Dec 5, 22:28

aklapper added a revision to T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails: D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Thu, Dec 5, 18:04 · PHP 8 support

aklapper requested review of D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Thu, Dec 5, 18:04

aklapper accepted D25847: Fix regression in Remarkup unit tests and harden.

I applied this patch locally on top of git master and output does not complain anymore about 'link-brackets.txt' (thus it's correct) but fails in link-edge-cases.txt now (thus it's likely not complete):

Thu, Dec 5, 17:38

aklapper created T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails.

Thu, Dec 5, 17:25 · PHP 8 support

Tue, Dec 3

aklapper updated the test plan for D25790: Show table of contents by default on wide screens.

Tue, Dec 3, 23:07

aklapper accepted D25790: Show table of contents by default on wide screens.

@mturdus: Thanks! LGTM

Tue, Dec 3, 23:06

aklapper added a comment to D25835: Strip surrounding whitespace from project and task titles.

@valerio.bozzolan: Feel free to give this revised version another review :)

Tue, Dec 3, 23:02

aklapper accepted D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Big thanks for digging deep into that regex (on which I gave up).

Tue, Dec 3, 22:43

aklapper accepted D25844: Add first unit test for mimemailparser headers.

Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

Tue, Dec 3, 22:24

aklapper updated the test plan for D25844: Add first unit test for mimemailparser headers.

Tue, Dec 3, 21:20

aklapper closed T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them as Resolved by committing rPc589529155d6: Fix parsing of incoming mail with UTF-8 encoded headers.

Tue, Dec 3, 12:39 · Bug Reports

aklapper closed D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

Tue, Dec 3, 12:39

aklapper committed rPc589529155d6: Fix parsing of incoming mail with UTF-8 encoded headers.

Fix parsing of incoming mail with UTF-8 encoded headers

Tue, Dec 3, 12:39

Mon, Dec 2

aklapper closed D25841: Account registration: Restrict Real Name length.

Mon, Dec 2, 19:36

aklapper closed T15962: Account registration: Handle too long Real Name more gracefully as Resolved by committing rPeb380f922c9a: Account registration: Restrict Real Name length.

Mon, Dec 2, 19:36

aklapper committed rPeb380f922c9a: Account registration: Restrict Real Name length.

Account registration: Restrict Real Name length

Mon, Dec 2, 19:36

aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Open.

Mon, Dec 2, 09:28 · PHP 8 support

aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated as Open by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Mon, Dec 2, 09:28 · PHP 8 support

aklapper closed T15963: LDAP over TLS is broken as Resolved by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Mon, Dec 2, 09:28 · Bug Reports, Auth

aklapper closed D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".

Mon, Dec 2, 09:28

aklapper added a reverting change for D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Mon, Dec 2, 09:28

aklapper committed rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…

Mon, Dec 2, 09:28

aklapper added a reverting change for rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Mon, Dec 2, 09:28

aklapper requested review of D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".

Mon, Dec 2, 00:28

aklapper added a reverting change for rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".

Mon, Dec 2, 00:28

aklapper added a reverting change for D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".

Mon, Dec 2, 00:28

aklapper added a revision to T15963: LDAP over TLS is broken: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".

Mon, Dec 2, 00:28 · Bug Reports, Auth

Sat, Nov 30

aklapper updated the diff for D25841: Account registration: Restrict Real Name length.

Simplify return of validateRealName() as proposed by Valerio

Sat, Nov 30, 12:17

Fri, Nov 29

aklapper updated the diff for D25841: Account registration: Restrict Real Name length.

Thanks for catching that! Amend in new PhutilNumber()

Fri, Nov 29, 14:33

aklapper updated the summary of D25841: Account registration: Restrict Real Name length.

Fri, Nov 29, 14:30

aklapper requested review of D25841: Account registration: Restrict Real Name length.

Fri, Nov 29, 14:22

aklapper added a revision to T15962: Account registration: Handle too long Real Name more gracefully: D25841: Account registration: Restrict Real Name length.

Fri, Nov 29, 14:22

aklapper created T15962: Account registration: Handle too long Real Name more gracefully.

Fri, Nov 29, 13:54

aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Finally got a reproducer URI in downstream:

Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).

Fri, Nov 29, 12:36 · Affects-Wikimedia

Thu, Nov 28

aklapper awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.

Thu, Nov 28, 16:55 · Phorge Development Tools, Discussion Needed

aklapper closed T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)" as Resolved by committing rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Thu, Nov 28, 11:41 · Herald

aklapper closed D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Thu, Nov 28, 11:41

aklapper committed rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Avoid "Unknown Object (????)" for custom Select field values in Herald editor

Thu, Nov 28, 11:41

aklapper added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

In D25696#22447, @valerio.bozzolan wrote:

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Thu, Nov 28, 11:40

Tue, Nov 26

aklapper updated the task description for T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".

Tue, Nov 26, 18:39 · Herald

aklapper closed T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime() as Resolved by committing rP89be7a51d8c8: Validate some user provided calendar query range dates.

Tue, Nov 26, 14:12 · Calendar

aklapper committed rP89be7a51d8c8: Validate some user provided calendar query range dates.

Validate some user provided calendar query range dates

Tue, Nov 26, 14:12

aklapper closed D25825: Validate some user provided calendar query range dates.

Tue, Nov 26, 14:12

aklapper closed D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.

Tue, Nov 26, 14:02

aklapper committed rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.

mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4

Tue, Nov 26, 14:02

aklapper updated the diff for D25825: Validate some user provided calendar query range dates.

Also update the PhpDoc accordingly

Tue, Nov 26, 14:01

aklapper updated the diff for D25825: Validate some user provided calendar query range dates.

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

Tue, Nov 26, 13:59

aklapper requested review of D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.

Tue, Nov 26, 13:53

aklapper added a comment to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them.

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)

Tue, Nov 26, 13:48 · Bug Reports

aklapper requested review of D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

Tue, Nov 26, 13:47

aklapper added a revision to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them: D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

Tue, Nov 26, 13:47 · Bug Reports

aklapper edited the content of Next Up.

Tue, Nov 26, 13:12

aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.

Tue, Nov 26, 13:08 · Discussion Needed, Affects-Wikimedia

aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title as Resolved by committing rP6ec5c88bee24: Make maniphest.gettasktransactions include metadata and title.

Tue, Nov 26, 13:08 · Maniphest, Affects-Wikimedia

aklapper committed rP6ec5c88bee24: Make maniphest.gettasktransactions include metadata and title.

Make maniphest.gettasktransactions include metadata and title

Tue, Nov 26, 13:08

aklapper closed D25777: Make maniphest.gettasktransactions include metadata and title.

Tue, Nov 26, 13:08

aklapper closed D25827: Allow zooming on pages.

Tue, Nov 26, 13:07

aklapper closed T15945: Allow zooming Phorge pages on mobile as Resolved by committing rP828ea9bca030: Allow zooming on pages.

Tue, Nov 26, 13:07 · Accessibility

aklapper committed rP828ea9bca030: Allow zooming on pages.

Allow zooming on pages

Tue, Nov 26, 13:07

aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Tue, Nov 26, 13:05 · PHP 8 support

aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated as Resolved by committing rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

Tue, Nov 26, 13:05 · PHP 8 support

aklapper closed D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

Tue, Nov 26, 13:05

aklapper committed rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception

Tue, Nov 26, 13:05

aklapper requested review of D25835: Strip surrounding whitespace from project and task titles.

Tue, Nov 26, 13:03

aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

Handle whitespace-only task and project titles correctly

Tue, Nov 26, 13:02

aklapper updated the test plan for D25835: Strip surrounding whitespace from project and task titles.

Tue, Nov 26, 13:00

aklapper planned changes to D25835: Strip surrounding whitespace from project and task titles.

This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)

Tue, Nov 26, 12:52

aklapper closed D25837: Fix a typo in documentation.

Tue, Nov 26, 10:44

aklapper committed rPc0ebc7b405c2: Fix a typo in documentation.

Fix a typo in documentation

Tue, Nov 26, 10:44