git rebase master
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
no no I rock like a grapstar
Uh right, thanks! Let's do as mainframe98 says
In D26007#26996, @aklapper wrote:@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
Thu, May 22
You're right, thank you (as usual)!
git rebase master
Wed, May 21
Tue, May 20
Thanks! Confirming; tested, also works as expected with other epoch values.
I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/
In D26000#27460, @valerio.bozzolan wrote:Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?
indentation is arrsome
oh true
Hmm could you share why it's a "legacy feature"? I guess I'm clueless
Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph
good points <3
Proposed behavior: Add additional text when setting up a second MFA.
Mon, May 19
...and now even in the correct order of parameters, sigh
You are correct. (And I am disappointed by PHPStan to not realize that.)
Make PhabricatorDifferentialRevisionTestDataGenerator::generateDescription() have more than one sentence
Sun, May 18
git rebase master
Sigh, I swear I grep'ed for isArray before but I was in a parallel CamelCase world in that moment
Sat, May 17
remove some unneeded brackets in regex
Right...hmm, now I also wonder. :)
Should probably be iPhone|iPod|Android.*(Chrome/[.0-9]* Mobile|Mobile.*Firefox/[.0-9]*) (it's still that Firefox on Android has that Android string first, thus the brackets).
or with slash and version:
We shall keep version. There"s a good number of user-agent strings out there concatenating random browser names while not being these browsers.
git rebase master
git rebase master
Fri, May 16
wrap long string to make lint happy
but in Firefox seems easier, we can just match "Mobile.*Firefox" probably
Per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent/Firefox (and other pages like https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox ), the current regex check in Phorge requiring the string Chrome won't even try to match Firefox browsers on mobile (e.g. Mozilla/5.0 (Android 15; Mobile; rv:138.0) Gecko/138.0 Firefox/138.0).
Reverting rARC29575b4f91876bf0a95739eba50f792e2aa78c0c and rP6619fef2ff977ea81092b970e58abbb33e78f644 makes Phorge throw errors again:
Firefox says This page is in Quirks Mode. Page layout may be impacted.,
Chromium says net::ERR_CONTENT_DECODING_FAILED 200 (OK)),
both because the deprecation warning is added before the usual HTML header created by AphrontPageView, as curl shows:
[acko@foo phorge (master *$|u=)]$ curl 'http://phorge.localhost' <br /> <b>Deprecated</b>: Constant E_STRICT is deprecated in <b>/var/www/html/phorge/phorge/support/startup/PhabricatorStartup.php</b> on line <b>391</b><br /> <!DOCTYPE html><html data-developer-mode="1"><head><meta charset="UTF-8" /><title>Home</title><meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" /><link rel="mask-icon" color="#3D4B67" [...]
We don't end up calling PhutilErrorHandler::handleError() or PhutilErrorLog::onError() or PhutilSystem::writeStderr() here.
seems manually uploaded by an user, but it's not
Thu, May 15
Wed, May 14
git rebase master
git rebase master