Page MenuHomePhorge
Feed Advanced Search

Fri, Nov 1

aklapper edited the content of Next Up.
Fri, Nov 1, 08:00
aklapper closed T15940: Update copy of external mimemailparser library as Resolved by committing rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4.
Fri, Nov 1, 07:59
aklapper committed rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4.
Update mimemailparser from May 2011 version to 8.0.4
Fri, Nov 1, 07:59
aklapper closed D25829: Update mimemailparser from May 2011 version to 8.0.4.
Fri, Nov 1, 07:59
aklapper added a comment to D25829: Update mimemailparser from May 2011 version to 8.0.4.

This very patch got deployed on our rather active downstream instance 10 days ago. I have not heard complaints and I've seen tasks and task comments (replies) created via email, so I'm now pretty confident that it does what it should. Thus I'm going to merge it to reduce technical debt a bit more in Phorge.

Fri, Nov 1, 07:59

Tue, Oct 29

aklapper added a revision to T15950: Update copy of external xhprof library: D25836: Update xhprof to latest upstream version 2.3.10.
Tue, Oct 29, 14:42
aklapper requested review of D25836: Update xhprof to latest upstream version 2.3.10.
Tue, Oct 29, 14:42
aklapper updated the task description for T15950: Update copy of external xhprof library.
Tue, Oct 29, 14:31
aklapper added a comment to D25743: Fix stripping headers from proxy requests to other cluster nodes.

@avivey: Would you like to give this another review, once you find some spare time? TIA!

Tue, Oct 29, 11:11
aklapper updated the test plan for D25835: Strip surrounding whitespace from project and task titles.
Tue, Oct 29, 10:40
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

Restore an empty line

Tue, Oct 29, 10:38
aklapper requested review of D25835: Strip surrounding whitespace from project and task titles.
Tue, Oct 29, 10:34

Sun, Oct 27

aklapper accepted D25834: DarkConsole: Fix "strlen(null)" but for the "tab" query parameter.
Sun, Oct 27, 22:12

Fri, Oct 25

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Fri, Oct 25, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Thu, Oct 24

aklapper closed D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Thu, Oct 24, 15:33
aklapper committed rPd643ca4c4c53: ManiphestReportController: Separate legacy and synthetic data handling.
ManiphestReportController: Separate legacy and synthetic data handling
Thu, Oct 24, 15:33
aklapper closed D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Thu, Oct 24, 15:19
aklapper committed rP5f4587bb88dd: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Thu, Oct 24, 15:19
aklapper committed rARC29ca3df1122b: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Thu, Oct 24, 15:16
aklapper closed D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Thu, Oct 24, 15:16

Wed, Oct 23

aklapper closed T15949: Herald comment attributed to the wrong user in email notifications as Invalid.
Wed, Oct 23, 14:09 · Herald, Maniphest
aklapper requested review of D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 10:14
aklapper requested review of D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 09:57
aklapper closed D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 09:10
aklapper committed rPf3d49f740737: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Wed, Oct 23, 09:10
aklapper closed D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 09:09
aklapper committed rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Wed, Oct 23, 09:09
aklapper closed D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 09:08
aklapper committed rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Wed, Oct 23, 09:08

Tue, Oct 22

aklapper added a comment to D25829: Update mimemailparser from May 2011 version to 8.0.4.

For testing, I deployed the latest revision of this proposed patch in our downstream instance and created a task via incoming plain text mail with attachments - seems to still work as expected so no obvious breakage (yet): https://phabricator.wikimedia.org/T377859

Tue, Oct 22, 15:16
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

Fix typo

Tue, Oct 22, 11:51
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

mimemailparser: Check that PHP mailparse extension is installed

Tue, Oct 22, 11:50
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Tue, Oct 22, 08:35 · PHP 8 support
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter as Resolved by committing rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Tue, Oct 22, 08:35 · PHP 8 support
aklapper closed D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Tue, Oct 22, 08:35
aklapper committed rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
Tue, Oct 22, 08:35

Mon, Oct 21

aklapper requested review of D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Mon, Oct 21, 18:08
aklapper added a revision to T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter: D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Mon, Oct 21, 18:08 · PHP 8 support
aklapper created T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Mon, Oct 21, 18:05 · PHP 8 support
aklapper closed T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Mon, Oct 21, 16:52 · PHP 8 support
aklapper closed T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests as Resolved.
Mon, Oct 21, 16:52 · PHP 8 support
aklapper added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

The email body says Herald added a comment.
The email subject line header says [Changed Project Column] (not [Commented On]).
So I wouldn't say it is incorrectly attributed.
AFAIK there are no Herald rules which trigger a separate email notification on its own (but I agree that the described behavior also has confused me in the past) as Herald rules are always triggered by some other previous action.

Mon, Oct 21, 16:50 · Herald, Maniphest
aklapper updated the diff for D25828: ManiphestReportController: Separate legacy and synthetic data handling.

Try to make this a separate branch

Mon, Oct 21, 14:31
aklapper added inline comments to D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Mon, Oct 21, 08:32
aklapper created T15950: Update copy of external xhprof library.
Mon, Oct 21, 08:24

Sun, Oct 20

aklapper added a comment to T15766: Cleanup a bit MimeMailParser.

@valerio.bozzolan Proposing to decline in favor of T15940: Update copy of external mimemailparser library / D25829: Update mimemailparser from May 2011 version to 8.0.4.
Let's not increase the diff to upstream (13 years difference) even more.

Sun, Oct 20, 17:26 · Good Starter Task
aklapper requested review of D25829: Update mimemailparser from May 2011 version to 8.0.4.
Sun, Oct 20, 17:22
aklapper added a revision to T15940: Update copy of external mimemailparser library: D25829: Update mimemailparser from May 2011 version to 8.0.4.
Sun, Oct 20, 17:22

Sat, Oct 19

aklapper updated the task description for T15940: Update copy of external mimemailparser library.
Sat, Oct 19, 15:12
aklapper added a comment to D25828: ManiphestReportController: Separate legacy and synthetic data handling.

ARRRGH, I locally did this on master branch instead of a dedicated branch. Sorry, it's been a while!

Sat, Oct 19, 11:00
aklapper added a comment to D25828: ManiphestReportController: Separate legacy and synthetic data handling.

For context, the ManiphestTransaction table in my installation has >10mio entries so some charts do not render but time out. One approach could be Materialized Views but I don't see how that's feasible given the "Project" tag parameter coming into play (and having thousands of project tags in my installation), so my vague followup idea for my installation is to completely disable the code which handles the legacy data only (as creating the modern data does not rely on querying the ManiphestTransaction table), and thus deliberately ignore ancient legacy data from before 2018 for the sake of performance. That's easier to achieve when the upstream spaghetti code doesn't constantly switch between handling legacy and modern/synthetic data.

Sat, Oct 19, 10:49
aklapper requested review of D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Sat, Oct 19, 10:47

Fri, Oct 18

aklapper edited the content of Next Up.
Fri, Oct 18, 12:20
aklapper closed T15047: Officially raise minimum required PHP version to 7.2 as Resolved by committing rP23a49eb403c9: Bump PHP version requirement from 5.2.3 to 7.2.25.
Fri, Oct 18, 12:20 · Phorge
aklapper closed T15047: Officially raise minimum required PHP version to 7.2, a subtask of T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated, as Resolved.
Fri, Oct 18, 12:20 · PHP 8 support
aklapper closed D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Fri, Oct 18, 12:20
aklapper committed rP23a49eb403c9: Bump PHP version requirement from 5.2.3 to 7.2.25.
Bump PHP version requirement from 5.2.3 to 7.2.25
Fri, Oct 18, 12:20

Oct 9 2024

aklapper created T15947: Add method to query if user is member of a list of projects.
Oct 9 2024, 09:46 · Feature Requests
aklapper closed T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view as Resolved by committing rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit….
Oct 9 2024, 09:19
aklapper closed D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 9 2024, 09:19
aklapper committed rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit….
Avoid RuntimeException passing bogus "service" parameter to Diffusion commit…
Oct 9 2024, 09:19
aklapper added a comment to T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view.

No clue :)

Oct 9 2024, 09:17
20after4 awarded D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view a Yellow Medal token.
Oct 9 2024, 08:07
20after4 awarded D25827: Allow zooming on pages a Yellow Medal token.
Oct 9 2024, 08:06

Oct 2 2024

aklapper updated the summary of D25827: Allow zooming on pages.
Oct 2 2024, 12:45
aklapper requested review of D25827: Allow zooming on pages.
Oct 2 2024, 12:44
aklapper added a revision to T15945: Allow zooming Phorge pages on mobile: D25827: Allow zooming on pages.
Oct 2 2024, 12:44 · Accessibility

Oct 1 2024

aklapper created T15945: Allow zooming Phorge pages on mobile.
Oct 1 2024, 18:17 · Accessibility
aklapper added inline comments to D25825: Validate some user provided calendar query range dates.
Oct 1 2024, 15:19
aklapper added a comment to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.

Stumbled upon https://we.phorge.it/rP95e179d9a4f31b8c5c2cbb4db8f7fa9f2d3867d6 which also mentions

We may not have a commit object for a given identifier if the commit has not imported yet.

So this can indeed happen.

Oct 1 2024, 15:12
aklapper requested review of D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 1 2024, 15:10
aklapper added a revision to T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view: D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 1 2024, 15:10
aklapper created T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view.
Oct 1 2024, 14:35

Sep 30 2024

aklapper closed T15836: ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList as Resolved by committing rARC285e31f4c743: Fix invalid constructor call for ArcanistHardpointFutureList.
Sep 30 2024, 13:36 · Arcanist
aklapper closed D25708: Fix invalid constructor call for ArcanistHardpointFutureList.
Sep 30 2024, 13:36
aklapper committed rARC285e31f4c743: Fix invalid constructor call for ArcanistHardpointFutureList.
Fix invalid constructor call for ArcanistHardpointFutureList
Sep 30 2024, 13:36

Sep 24 2024

Wikivu awarded rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier a Orange Medal token.
Sep 24 2024, 05:35

Sep 20 2024

aklapper closed T15936: PHP8.1 strlen(): Passing null to parameter is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 20 2024, 06:49 · PHP 8 support
aklapper closed T15936: PHP8.1 strlen(): Passing null to parameter is deprecated as Resolved by committing rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.
Sep 20 2024, 06:49 · PHP 8 support
aklapper closed D25821: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.
Sep 20 2024, 06:49
aklapper committed rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.
Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier
Sep 20 2024, 06:49

Sep 18 2024

aklapper retitled D25825: Validate some user provided calendar query range dates from Validate user provided calendar query range dates
Sep 18 2024, 13:21
aklapper updated the summary of D25825: Validate some user provided calendar query range dates.
Sep 18 2024, 13:20
aklapper requested review of D25825: Validate some user provided calendar query range dates.
Sep 18 2024, 13:01
aklapper added a revision to T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime(): D25825: Validate some user provided calendar query range dates.
Sep 18 2024, 13:01 · Calendar
aklapper created T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime().
Sep 18 2024, 12:49 · Calendar

Sep 17 2024

aklapper added a comment to D25708: Fix invalid constructor call for ArcanistHardpointFutureList.

Basically, premising that the constructor of newFromFutures() seems legit, it's not clear to me why its return result should make sense and be compatible with the expected one. If somebody can clarify this, maybe it's at least something more.

Sep 17 2024, 13:42
aklapper added a comment to D25708: Fix invalid constructor call for ArcanistHardpointFutureList.

So this patch which changes (and hopefully also fixes) definitely broken code will be blocked for good due to lack of a test plan (which I won't be able to figure out)?
Or does anyone can come up with any other option?

Sep 17 2024, 11:09
aklapper abandoned D25753: Fix call to undefined method PhabricatorInlineCommentController::canEditInlineComment().

Going to abandon for now as I'm not convinced either that this is something worth to change only to make PHPStan happier.
Note that https://we.phorge.it/book/libphutil/function/assert_instances_of/ might be an option when/if I want to look into this again at some future point.

Sep 17 2024, 11:03
aklapper closed T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 17 2024, 07:20 · PHP 8 support
aklapper closed T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef as Resolved by committing rP85f51c54303f: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 17 2024, 07:20 · PHP 8 support
aklapper closed D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 17 2024, 07:20
aklapper committed rP85f51c54303f: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef
Sep 17 2024, 07:20

Sep 16 2024

aklapper edited the content of Next Up.
Sep 16 2024, 17:00
aklapper updated the summary of D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 16 2024, 16:59
aklapper updated the summary of D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Sep 16 2024, 16:59
aklapper updated the diff for D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Don't create an empty title array when there is no $query_text

Sep 16 2024, 16:56
aklapper added a comment to D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Uhhh you found the place where the empty array comes from! <3 I failed!

Sep 16 2024, 16:55
aklapper closed T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 16 2024, 16:27 · PHP 8 support
aklapper closed T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php as Resolved by committing rARC0358ff7ee314: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.
Sep 16 2024, 16:27 · PHP 8 support