Page MenuHomePhorge
Feed Advanced Search

Yesterday

aklapper updated the diff for D26007: Remove unused CSS file aphront/panel-view.css.

git rebase master

Fri, May 23, 21:44
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

no no I rock like a grapstar

Fri, May 23, 17:32
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Uh right, thanks! Let's do as mainframe98 says

Fri, May 23, 17:28
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 23, 17:21
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 23, 17:21
aklapper closed D25995: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08
aklapper committed rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08

Thu, May 22

aklapper added a comment to D26030: Fix project typeahead query with columns when string is not name prefix.

You're right, thank you (as usual)!

Thu, May 22, 17:13
aklapper updated the test plan for D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 17:13
aklapper updated the diff for D25995: Remove orphan CSS selectors in PHUIFormView.

git rebase master

Thu, May 22, 16:35
aklapper closed D25978: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
aklapper committed rPb174cce279aa: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
aklapper updated the summary of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:13
aklapper requested review of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10
aklapper added a revision to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10 · Bug Reports
aklapper closed D26006: Remove unused FatCow icon files.
Thu, May 22, 06:53
aklapper committed rP947b70441184: Remove unused FatCow icon files.
Thu, May 22, 06:53

Wed, May 21

aklapper added inline comments to D26026: Add a Before-Destruction Engine.
Wed, May 21, 12:59

Tue, May 20

aklapper accepted D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.

Thanks! Confirming; tested, also works as expected with other epoch values.

Tue, May 20, 16:21
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/

Tue, May 20, 13:13
aklapper added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Tue, May 20, 13:02
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

indentation is arrsome

Tue, May 20, 12:44
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

oh true

Tue, May 20, 12:42
valerio.bozzolan awarded D26000: Remove orphan CSS selectors in calendar/phui-calendar.css a Yellow Medal token.
Tue, May 20, 12:38
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Hmm could you share why it's a "legacy feature"? I guess I'm clueless

Tue, May 20, 12:31
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph

Tue, May 20, 12:21
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

good points <3

Tue, May 20, 12:20
aklapper added a revision to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them: D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper requested review of D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper added a comment to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.

Proposed behavior: Add additional text when setting up a second MFA.

Tue, May 20, 12:05
aklapper created T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.
Tue, May 20, 12:01
aklapper added inline comments to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 10:14
aklapper edited the content of Next Up.
Tue, May 20, 06:36
aklapper edited the content of Next Up.
Tue, May 20, 06:35
aklapper closed D26021: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33
aklapper closed T16071: Avoid large layout shifts while page loading on mobile as Resolved by committing rPf4d3c968461e: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33
aklapper committed rPf4d3c968461e: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33

Mon, May 19

aklapper closed D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 18:44
aklapper committed rP361b512bd532: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 18:44
aklapper updated the diff for D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().

...and now even in the correct order of parameters, sigh

Mon, May 19, 17:52
aklapper requested review of D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 17:46
aklapper updated the summary of D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 15:03
aklapper updated the diff for D25978: Fix wrong argument count in numerous calls' signatures.

You are correct. (And I am disappointed by PHPStan to not realize that.)

Mon, May 19, 14:05
aklapper updated the summary of D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 14:05
aklapper requested review of D26024: Make long phui-tag-view object titles wrap in Remarkup context.
Mon, May 19, 11:54
aklapper added a revision to T16077: Referenced long object titles ({X123}) should wrap in descriptions/comments: D26024: Make long phui-tag-view object titles wrap in Remarkup context.
Mon, May 19, 11:54
aklapper created T16077: Referenced long object titles ({X123}) should wrap in descriptions/comments.
Mon, May 19, 11:47
aklapper updated the diff for D25978: Fix wrong argument count in numerous calls' signatures.

Make PhabricatorDifferentialRevisionTestDataGenerator::generateDescription() have more than one sentence

Mon, May 19, 09:54
aklapper closed D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Mon, May 19, 05:19
aklapper committed rP7e4c1e93b55b: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Mon, May 19, 05:19

Sun, May 18

aklapper added inline comments to D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Sun, May 18, 21:23
aklapper closed D26009: Remove orphan CSS selectors in phui/phui-action-panel.css.
Sun, May 18, 21:12
aklapper committed rP39216af0db7b: Remove orphan CSS selectors in phui/phui-action-panel.css.
Sun, May 18, 21:12
aklapper closed D26008: Remove orphan CSS selectors in phui/phui-header-view.css.
Sun, May 18, 21:11
aklapper committed rP4195c91af0fe: Remove orphan CSS selectors in phui/phui-header-view.css.
Sun, May 18, 21:11
aklapper updated the diff for D26008: Remove orphan CSS selectors in phui/phui-header-view.css.

git rebase master

Sun, May 18, 21:10
aklapper updated the diff for D26023: Ignore bogus cards parameter string values in Hovercards calls.

Sigh, I swear I grep'ed for isArray before but I was in a parallel CamelCase world in that moment

Sun, May 18, 21:05
aklapper requested review of D26023: Ignore bogus cards parameter string values in Hovercards calls.
Sun, May 18, 20:35
aklapper added a revision to T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php: D26023: Ignore bogus cards parameter string values in Hovercards calls.
Sun, May 18, 20:35
aklapper renamed T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php from TypeError) idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php to TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php.
Sun, May 18, 20:34
aklapper created T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php.
Sun, May 18, 20:29

Sat, May 17

aklapper requested review of D26022: Show image preview thumbnails on Authored Files.
Sat, May 17, 13:10
aklapper added a revision to T16039: Show image preview thumbnails on your Authored Files: D26022: Show image preview thumbnails on Authored Files.
Sat, May 17, 13:10 · Feature Requests
aklapper updated the diff for D26021: Make User-Agent regex detect Firefox on Android.

remove some unneeded brackets in regex

Sat, May 17, 09:33
aklapper closed D25997: Remove orphan CSS selectors for differential-haunt-mode.
Sat, May 17, 09:20
aklapper committed rP2ce25747851f: Remove orphan CSS selectors for differential-haunt-mode.
Sat, May 17, 09:20
aklapper added a comment to D26021: Make User-Agent regex detect Firefox on Android.

Right...hmm, now I also wonder. :)
Should probably be iPhone|iPod|Android.*(Chrome/[.0-9]* Mobile|Mobile.*Firefox/[.0-9]*) (it's still that Firefox on Android has that Android string first, thus the brackets).

or with slash and version:

We shall keep version. There"s a good number of user-agent strings out there concatenating random browser names while not being these browsers.

Sat, May 17, 02:46
aklapper updated the task description for T16072: Accessibility improvements (May 2025).
Sat, May 17, 02:29 · Accessibility
aklapper added a project to T16072: Accessibility improvements (May 2025): Accessibility.
Sat, May 17, 02:08 · Accessibility
aklapper claimed T16072: Accessibility improvements (May 2025).
Sat, May 17, 02:08 · Accessibility
aklapper created T16072: Accessibility improvements (May 2025).
Sat, May 17, 02:08 · Accessibility
aklapper edited the content of Next Up.
Sat, May 17, 01:29
aklapper closed T15689: built in exception display is missing top line as Resolved by committing rPb7ff9ba6f8ab: Unhandled Exception: Add last call to error message.
Sat, May 17, 01:29 · Wikimedia Hackathon 2025, Phorge Development Tools
aklapper closed D25955: Unhandled Exception: Add last call to error message.
Sat, May 17, 01:29
aklapper committed rPb7ff9ba6f8ab: Unhandled Exception: Add last call to error message.
Sat, May 17, 01:29
aklapper updated the diff for D25997: Remove orphan CSS selectors for differential-haunt-mode.

git rebase master

Sat, May 17, 01:22
aklapper added inline comments to D25997: Remove orphan CSS selectors for differential-haunt-mode.
Sat, May 17, 01:19
aklapper closed D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 17, 01:14
aklapper committed rP78f9c26dabc2: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 17, 01:14
aklapper updated the diff for D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.

git rebase master

Sat, May 17, 01:14
aklapper closed D25996: Remove unused CSS file differential/revision-list.css.
Sat, May 17, 01:12
aklapper committed rP9ce983391683: Remove unused CSS file differential/revision-list.css.
Sat, May 17, 01:12

Fri, May 16

aklapper updated the diff for D26021: Make User-Agent regex detect Firefox on Android.

wrap long string to make lint happy

Fri, May 16, 14:54
aklapper added a comment to D26021: Make User-Agent regex detect Firefox on Android.

but in Firefox seems easier, we can just match "Mobile.*Firefox" probably

Fri, May 16, 14:53
aklapper requested review of D26021: Make User-Agent regex detect Firefox on Android.
Fri, May 16, 13:19
aklapper added a revision to T16071: Avoid large layout shifts while page loading on mobile: D26021: Make User-Agent regex detect Firefox on Android.
Fri, May 16, 13:19
aklapper added a comment to T16071: Avoid large layout shifts while page loading on mobile.

Per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent/Firefox (and other pages like https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox ), the current regex check in Phorge requiring the string Chrome won't even try to match Firefox browsers on mobile (e.g. Mozilla/5.0 (Android 15; Mobile; rv:138.0) Gecko/138.0 Firefox/138.0).

Fri, May 16, 13:04
aklapper added a comment to T16065: PHP Deprecation warnings in STDERR can make arc fail.

Reverting rARC29575b4f91876bf0a95739eba50f792e2aa78c0c and rP6619fef2ff977ea81092b970e58abbb33e78f644 makes Phorge throw errors again:
Firefox says This page is in Quirks Mode. Page layout may be impacted.,
Chromium says net::ERR_CONTENT_DECODING_FAILED 200 (OK)),
both because the deprecation warning is added before the usual HTML header created by AphrontPageView, as curl shows:

[acko@foo phorge (master *$|u=)]$ curl 'http://phorge.localhost'
<br />
<b>Deprecated</b>:  Constant E_STRICT is deprecated in <b>/var/www/html/phorge/phorge/support/startup/PhabricatorStartup.php</b> on line <b>391</b><br />
<!DOCTYPE html><html data-developer-mode="1"><head><meta charset="UTF-8" /><title>Home</title><meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" /><link rel="mask-icon" color="#3D4B67" [...]

We don't end up calling PhutilErrorHandler::handleError() or PhutilErrorLog::onError() or PhutilSystem::writeStderr() here.

Fri, May 16, 12:14
aklapper updated the task description for T16071: Avoid large layout shifts while page loading on mobile.
Fri, May 16, 07:52
aklapper created T16071: Avoid large layout shifts while page loading on mobile.
Fri, May 16, 07:38
aklapper added a comment to T16070: Understand why Diffusion creates some orphan Files.

seems manually uploaded by an user, but it's not

Fri, May 16, 05:42 · User-valerio.bozzolan, Diffusion, Files

Thu, May 15

aklapper closed D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Thu, May 15, 06:47
aklapper committed rPb51f3657000c: Remove orphan CSS selectors in phui/phui-form-view.css.
Thu, May 15, 06:47
aklapper updated the summary of D25772: Projects: improve quality of destroy workflow.
Thu, May 15, 06:47 · Projects

Wed, May 14

aklapper updated the diff for D26011: Remove orphan CSS selectors in phui/phui-form-view.css.

git rebase master

Wed, May 14, 22:35
aklapper closed D26010: Remove orphan CSS selectors in core/z-index.css.
Wed, May 14, 22:34
aklapper committed rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css.
Wed, May 14, 22:34
aklapper updated the diff for D26010: Remove orphan CSS selectors in core/z-index.css.

git rebase master

Wed, May 14, 22:33
aklapper committed rP44b33e6345c6: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Wed, May 14, 22:20
aklapper closed D26012: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Wed, May 14, 22:20