Page MenuHomePhorge

tobiaswiese (Tobias Wiese)
User

Projects

User Details

User Since
Jun 10 2021, 19:42 (18 w, 6 d)

Recent Activity

Jun 20 2021

tobiaswiese updated the summary of D25005: Add HarbormasterHookController as an entry point for all Harbormaster hooks.
Jun 20 2021, 22:09
tobiaswiese added inline comments to D25009: Update arcanist readme to reference Phorge.
Jun 20 2021, 15:30
tobiaswiese added a comment to D25006: Add package.json for aphlict.

We should probably exclude the package-lock.json from linting rules, because it is auto generated.

Jun 20 2021, 15:29

Jun 18 2021

tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

I have some concerns regarding the new comment, as these files don't really belong to aphlict, but are npm npm artifcats. If node-ws is installed via e.g. the system package manager (which is probably the better idea anyway), these files/folders won't be created.

Jun 18 2021, 22:06 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

Will this cause a conflict? - I feel like it will..?

Jun 18 2021, 21:37 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

The problem with package-lock.json is, that it either generates noise in the working copy (it just changes its content a lot of times during normal operation). And it needs an update every time a dependency (even indirect) got an security related update because production installs will otherwise not pull the updated dependency in.

Jun 18 2021, 19:53 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

AFAIK package-lock.json is only used by npm itself, when deciding on which version to download. If no package-lock.json exists the version are taken to match package.json.

Jun 18 2021, 19:46 · Aphlict
tobiaswiese added a watcher for Drydock: tobiaswiese.
Jun 18 2021, 19:38
tobiaswiese added a watcher for Diffusion: tobiaswiese.
Jun 18 2021, 19:37
tobiaswiese added a watcher for Differential: tobiaswiese.
Jun 18 2021, 19:37
tobiaswiese added a watcher for Daemons: tobiaswiese.
Jun 18 2021, 19:37
tobiaswiese added a watcher for Audit: tobiaswiese.
Jun 18 2021, 19:37
tobiaswiese added a watcher for Mail: tobiaswiese.
Jun 18 2021, 19:36
tobiaswiese added a watcher for Harbormaster: tobiaswiese.
Jun 18 2021, 19:36
tobiaswiese accepted D25003: Arcanist Update .arcconfig to point to we.phorge.it.
Jun 18 2021, 18:18
tobiaswiese accepted D25001: T15006: Update .arcconfig to point to we.phorge.it.
Jun 18 2021, 16:22
tobiaswiese added a comment to T15006: Re-brand Phorge.

Emails have a bunch of X-Phabricator-* headers, for configuring rules in mail clients.

  • We may want to allow installs to keep it as Phabricator for compatibility
Jun 18 2021, 01:46 · Phorge

Jun 16 2021

tobiaswiese accepted D25000: Update Readme.
Jun 16 2021, 19:57
tobiaswiese added a comment to D25000: Update Readme.

Also for completeness the diff between the pre-deprecation README (from rP95662ae8f1) and the proposed version:

Jun 16 2021, 18:54
tobiaswiese requested changes to D25000: Update Readme.

Spotted a leftover Phabricator

Jun 16 2021, 18:50

Jun 11 2021

tobiaswiese updated the task description for T15000: Ad hoc setup tasks.
Jun 11 2021, 14:16 · Upstream General/Unknown
tobiaswiese added a comment to T15000: Ad hoc setup tasks.

Just my 2cts:

Jun 11 2021, 14:15 · Upstream General/Unknown