Page MenuHomePhorge

Remove unused keyboard shortcuts code
Needs ReviewPublic

Authored by aklapper on Fri, May 9, 10:57.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

PHUIPropertyListView defines setHasKeyboardShortcuts() using AphrontKeyboardShortcutsAvailableView setting the CSS class keyboard-shortcuts-available defined in phui-property-list-view.css and phui-property-list-view.css, the latter being the only consumer of the icon key_question.png.

Searching the codebase for asKeyboardShortcuts there are zero callers as src/applications/differential/view/DifferentialRevisionDetailView.php got deleted in https://we.phorge.it/rP148a50e48be146b88036032d1cad772d2627da28. Thus remove that unused code/files.

Note that this is unrelated to setEnableKeyboardShortcuts() in PHUIPagerView.

Test Plan

Grep the codebase for asKeyboardShortcuts

Diff Detail

Repository
rP Phorge
Branch
keyboardShortcuts (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1961
Build 1961: arc lint + arc unit