Conpherence message pane CSS: Fix typo in selector name
Needs ReviewPublic
Actions

Authored by aklapper on Tue, May 6, 20:06.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

Fix a typo.

Test Plan

Grep the codebase; look at surrounding selectors in CSS file.

Diff Detail

Repository

rP Phorge

Branch

cssConphTypo (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1939
Build 1939: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, May 6, 20:06

Owners added a reviewer: O1: Blessed Committers.Tue, May 6, 20:06

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, May 6, 20:06

aklapper requested review of this revision.Tue, May 6, 20:06

Harbormaster completed remote builds in B1939: Diff 2990.Tue, May 6, 20:06

The CSS rule has never been applied. After the change it will be. Please help by adding a line in the test plan about how to reproduce it if you have some time 🙏

Edited: I mean that the new CSS rule can cause an unwanted result, better to do not blindly approve

Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.