Differential D25992
Remove unused anchor-target CSS for Conpherence message pane Authored by aklapper on Tue, May 6, 20:06. Tags None Referenced Files
Subscribers
Details
Remove unused CSS selectors related to anchor-target which do not get applied due to missing a whitespace. See also https://we.phorge.it/D25992 for gory details. Go to a Conpherence chat via an anchor link like Z1#10, inspect HTML's CSS classes for messages at top of the room (setting policy etc) and also posted chat messages themselves. See no visual differences.
Diff Detail
Event TimelineComment Actions The CSS rule has never been applied. After the change it will be. Please help by adding a line in the test plan about how to reproduce it if you have some time 🙏 Edited: I mean that the new CSS rule can cause an unwanted result, better to do not blindly approve Comment Actions Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector. Comment Actions These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors. To make these selectors applied (including the one above about background: {$lightyellow};), they'd require an additional whitespace: .conpherence-transaction-view.conpherence-comment .anchor-target .conpherence-transaction-view.conpherence-edited .anchor-target which shows that they don't make much sense, so best to remove them (and yes there are many more unused selectors in Conpherence):    |