Make long phui-tag-view object titles wrap in Remarkup context
Needs ReviewPublic
Actions

Authored by aklapper on Mon, May 19, 11:54.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16077: Referenced long object titles ({X123}) should wrap in descriptions/comments

Summary

Make long referenced object titles (markup like {D1} or {T1} wrap in a Remarkup context (description section, comment preview, transaction comments) not to become unreadable.
Keep current white-space: nowrap for .phui-tag-view (introduced in rPce30f8c88bf6541ebbdfa1dd6920658a4cd0255f) for other contexts.

Closes T16077

Test Plan

Paste the monogram of an object with a long name in curly brackets in a task description and a task comment on a screen with low viewport width.
Create a project tag with a long name and associate it to a task, look at that task in a list of Maniphest query search results on a screen with low viewport width.

Diff Detail

Repository

rP Phorge

Branch

T16077wrapObjTitles (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1990
Build 1990: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, May 19, 11:54

Owners added a reviewer: O1: Blessed Committers.Mon, May 19, 11:54

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, May 19, 11:54

aklapper requested review of this revision.Mon, May 19, 11:54

Harbormaster completed remote builds in B1990: Diff 3067.Mon, May 19, 11:54

Seems very useful thanks, I would like to find small extra time to expand the test plan a bit more and run these extra tests, since this already-existing feature sounds very "core"

webroot/rsrc/css/phui/phui-tag-view.css
547	Let's omit the "div"for two small reasons: looking at the other selectors here, we usually omit "div", probably because this is always a div as far as I know, and we don't need to really limit this filter, and lastly it does not add much semantic value from remarkup.css the selector is just `.phabricator-remarkup` and not `div.phabricator-remarkup` and CSS is less weird if the parent matches (we avoid some corner cases, if in the future there will be a `white-space` also from that parent) The "a" instead should be kept since it adds the desired selection over other tags.