Countdown: add a capability to decide who can Create
Concern Raised7ed35123a347
Actions

Description

Countdown: add a capability to decide who can Create

Summary:
This change adds the countdown.create capability to
allow to limit countdown creation.

This change comes from the Wikimedia Phabricator and
was originally proposed by v.bozzolan and implemented
by the kind user 20after4.

https://phabricator.wikimedia.org/T258599

Closes T15208
Ref T15081

Test Plan:

go to the page /applications/view/PhabricatorCountdownApplication/
play a bit with the "Can Create Countdowns" option
note that it is respected

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Tags: #countdown, Policy (archived)

Maniphest Tasks: T15208, T15081

Differential Revision: https://we.phorge.it/D25101

Details

Auditors

valerio.bozzolan

Provenance

20after4	Authored on Apr 23 2023, 20:15
20after4	Pushed on Apr 23 2023, 20:17

Reviewer

O1: Blessed Committers

Differential Revision

D25101: Countdown: add a capability to decide who can Create

Parents

rP1ba5c8c26095: Fix some PHP 8.1 issues in Diviner generator

Branches

Unknown

Tags

Unknown

Tasks

T15208: Countdown: it's not possible to limit who can create a new Countdown
T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge

Event Timeline

20after4 committed rP7ed35123a347: Countdown: add a capability to decide who can Create (authored by 20after4).Apr 23 2023, 20:15

20after4 added tasks: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, T15208: Countdown: it's not possible to limit who can create a new Countdown.Apr 23 2023, 20:18

20after4 added a revision: D25101: Countdown: add a capability to decide who can Create.

Just to mention that this change probably forgot arc liberate.

And it would be nice to understand why unit/lint tests didn't highlight this problem.

D25133: Countdown: fix PhutilMissingSymbolException

Having said it honestly worked on my computer too.

This commit now has outstanding concerns.Apr 25 2023, 10:31

OK green light. The missing map has probably nothing to do with some reported issues.

All concerns with this commit have now been addressed.Apr 25 2023, 11:06

OK red light again. This specific commit now causes to me a PhutilMissingSymbolException when loading the home of Phorge.

Failed to load symbol "PhabricatorCountdownCreateCapability" (of type "class or interface").

I absolutely have no idea about why during the local test of the patch I hadn't had any issue at all, why the unit tests were OK, why the lints were OK, etc., but now we have definitely a clear problem here and the fix is: D25133: Countdown: fix PhutilMissingSymbolException

This commit now has outstanding concerns.Apr 25 2023, 11:11

valerio.bozzolan mentioned this in Z1: Phorge.Apr 25 2023, 11:15

valerio.bozzolan mentioned this in Next Up.Apr 25 2023, 13:15

avivey mentioned this in rP98c1267e5f16: Countdown: fix PhutilMissingSymbolException.Apr 25 2023, 13:37

valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 13:41