Differential D26022

Show image preview thumbnails on Authored Files
Needs ReviewPublic
Actions

Authored by aklapper on Sat, May 17, 13:10.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16039: Show image preview thumbnails on your Authored Files

Summary

When going through the list of image files which you yourself uploaded it is convenient to have a visual representation.
Users often do not spend time to enter descriptive filenames (which are not really used afterwards in the UI anyway) to differentiate.

As this can be a performance hole, limit to the viewer's authored files view only.

Closes T16039

Test Plan

Be logged in, upload some image files, go to http://phorge.localhost/file/query/authored/, see thumbnails
Go to http://phorge.localhost/file/query/all/ or be logged out and see no thumbnails

Diff Detail

Repository

Branch

T16039fileUploadImagePreviews (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1985
Build 1985: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, May 17, 13:10

Owners added a reviewer: O1: Blessed Committers.Sat, May 17, 13:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, May 17, 13:10

aklapper requested review of this revision.Sat, May 17, 13:10

Harbormaster completed remote builds in B1985: Diff 3059.Sat, May 17, 13:10

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

resources/

celerity/

100%

Loading...

O1: Blessed Committers

src/

applications/

files/

query/

PhabricatorFileSearchEngine.php

22 lines

2%

Loading...

O1: Blessed Committers

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-list-view.css

4 lines

-

-

O1: Blessed Committers

Diff 3059

resources/celerity/map.php

Loading...

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...