Page MenuHomePhorge

Remove orphan CSS selectors in calendar/phui-calendar.css
AcceptedPublic

Authored by aklapper on Thu, May 8, 13:49.
Tags
None
Referenced Files
F4405202: D26000.1748603254.diff
Thu, May 29, 11:07
F4397061: D26000.1748547325.diff
Wed, May 28, 19:35
F4397033: D26000.1748546645.diff
Wed, May 28, 19:24
F4396994: D26000.1748544699.diff
Wed, May 28, 18:51
F4396935: D26000.1748543537.diff
Wed, May 28, 18:32
Tokens
"Yellow Medal" token, awarded by valerio.bozzolan.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Summary
Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.
Optionally, play with calendar list view.

Create events in which you are:

  • Busy
  • Available
  • Away
  • Invited
  • Invited and Confirmed

No visible color regressions.

Diff Detail

Repository
rP Phorge
Branch
cssDead7 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1954
Build 1954: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.Thu, May 8, 13:49

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

If you had asked me ten years ago, maybe... but now it's all too late!!1
https://we.phorge.it/rPdbd7e3c56de4e2460b23debcd1ce8c8c1114b2c8

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

webroot/rsrc/css/phui/calendar/phui-calendar.css
26–28

Maybe .phui-calendar-viewer-invited can be removed also from phui-calendar-list.css and phui-calendar-month.css

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

In my understanding that's unrelated because the results of all calls to getDisplayIconColor() in src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php don't call functions which would concatenate some .phui-calendar- prefix? Hmm.

webroot/rsrc/css/phui/calendar/phui-calendar.css
26–28

Probably yes but I leave that to a future patch :)

valerio.bozzolan edited the test plan for this revision. (Show Details)

lgtm

Fingers crossed.

This revision is now accepted and ready to land.Wed, May 28, 16:48