Page MenuHomePhorge

PhorgeProject
ActivePublic

Subprojects

Watchers (2)

Details

Description

Work related to Phorge.

Recent Activity

Dec 13 2021

jeremy.norris added a comment to T15064: Make phorge compatible with PHP 8.1.

https://secure.phabricator.com/w/changelog/2021.50/

Dec 13 2021, 13:46 · Phorge

Dec 10 2021

austinsonger added a comment to T15009: Foundation.

501(c)(3) is extremely easy to set up.

Dec 10 2021, 19:26 · Phorge, Governance

Dec 9 2021

MacFan4000 added a comment to T15064: Make phorge compatible with PHP 8.1.

The fixes mentioned there would take a long time to implement, as things like strlen() are used in 900+ files.

Dec 9 2021, 22:26 · Phorge
speck added a comment to T15064: Make phorge compatible with PHP 8.1.

Evan just posted some comments regarding 8.1 compatibility (as well as building PHP binary to ship with Arcanist, for Mac systems at least)
https://secure.phabricator.com/T13588#256390

Dec 9 2021, 21:30 · Phorge
MacFan4000 added a comment to T15064: Make phorge compatible with PHP 8.1.

There were more upstream changes made a week ago, https://secure.phabricator.com/w/changelog/2021.49/, that included improved PHP8 compatibility...

That'll be changes for PHP 8.0 compatibility, but that's not the same as PHP 8.1 compatibility.

Dec 9 2021, 16:48 · Phorge
jeremy.norris added a comment to T15064: Make phorge compatible with PHP 8.1.

There were more upstream changes made a week ago, https://secure.phabricator.com/w/changelog/2021.49/, that included improved PHP8 compatibility...

Dec 9 2021, 16:07 · Phorge
MacFan4000 added a comment to T15064: Make phorge compatible with PHP 8.1.

Wouldn't a massive changeset like this greatly increase difficulty of performing future merges of upstream (secure.phabricator.com)?

Dec 9 2021, 15:55 · Phorge
jeremy.norris added a comment to T15064: Make phorge compatible with PHP 8.1.

Wouldn't a massive changeset like this greatly increase difficulty of performing future merges of upstream (secure.phabricator.com)?

Dec 9 2021, 15:31 · Phorge
golyalpha added a comment to T15060: Better Pirate English.

Well, there are inconsistencies. For example, subscribers are called "spies" in the task overview, but "subscribers" in the task history, and "spies" again in task actions.

Dec 9 2021, 12:44 · Localization, Phorge

Dec 7 2021

MacFan4000 added a comment to T15064: Make phorge compatible with PHP 8.1.

I have submitted patches to fix most of the issues. The following issues still remain.

Dec 7 2021, 14:48 · Phorge
MacFan4000 added a task to D25031: Fix most PHP 8.1 issues: T15064: Make phorge compatible with PHP 8.1.
Dec 7 2021, 14:40 · Phorge
MacFan4000 added revisions to T15064: Make phorge compatible with PHP 8.1: D25031: Fix most PHP 8.1 issues, D25030: Fix PHP 8.1 incompatibilities mostly.
Dec 7 2021, 14:40 · Phorge
MacFan4000 requested review of D25031: Fix most PHP 8.1 issues.
Dec 7 2021, 14:16 · Phorge

Dec 5 2021

20after4 added a parent task for T15006: Re-brand Phorge: T15055: Import translations from translatewiki.net.
Dec 5 2021, 19:40 · Phorge
20after4 added a subtask for T15055: Import translations from translatewiki.net: T15006: Re-brand Phorge.
Dec 5 2021, 19:40 · Phorge
20after4 added a comment to T15055: Import translations from translatewiki.net.

Once the rebranding is complete we can send updated strings to translatewiki so that everything remains in sync.

Dec 5 2021, 19:39 · Phorge

Dec 4 2021

Bukkit triaged T15066: Add reason for join if approval is required as Wishlist priority.
Dec 4 2021, 16:11 · Phorge
Bukkit created T15066: Add reason for join if approval is required.
Dec 4 2021, 16:11 · Phorge

Dec 3 2021

Ekubischta added a comment to T15065: Do not forbid "open_basedir".

Here is the commit that introduced this

Dec 3 2021, 18:05 · Phorge
valerio.bozzolan triaged T15065: Do not forbid "open_basedir" as Low priority.
Dec 3 2021, 10:27 · Phorge
valerio.bozzolan updated the task description for T15065: Do not forbid "open_basedir".
Dec 3 2021, 10:20 · Phorge
valerio.bozzolan created T15065: Do not forbid "open_basedir".
Dec 3 2021, 10:13 · Phorge
valerio.bozzolan added a comment to T15055: Import translations from translatewiki.net.
In T15055#1426, @speck wrote:

The effort to rebrand Phabricator is going to result in changes to a lot of text which would likely invalidate a large number of translation entries.

Dec 3 2021, 09:18 · Phorge
valerio.bozzolan added a comment to T15060: Better Pirate English.

It is not very clear to understand where the problem is and how to try to help improve it. I am not familiar with Pirate English. Other than adding "Arrr." I mean.

Dec 3 2021, 09:15 · Localization, Phorge

Dec 2 2021

chris updated subscribers of T15059: Phabricator doesn't email @outlook.com addresses.
In T15059#1654, @speck wrote:

I just checked the emails I receive to my gmail account and noticed that the emails seem to be from the secure.phorge.dev domain. Should those be received from we.phorge.it instead? I was in the process of filling out an issue form for Microsoft and noticed this discrepancy. Could that cause issues like this?

Dec 2 2021, 16:47 · Phorge
MacFan4000 edited the content of Welcome.
Dec 2 2021, 16:15 · Phorge
MacFan4000 added a comment to T15059: Phabricator doesn't email @outlook.com addresses.
In T15059#1654, @speck wrote:

I just checked the emails I receive to my gmail account and noticed that the emails seem to be from the secure.phorge.dev domain. Should those be received from we.phorge.it instead? I was in the process of filling out an issue form for Microsoft and noticed this discrepancy. Could that cause issues like this?

Dec 2 2021, 16:14 · Phorge
speck added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

I just checked the emails I receive to my gmail account and noticed that the emails seem to be from the secure.phorge.dev domain. Should those be received from we.phorge.it instead? I was in the process of filling out an issue form for Microsoft and noticed this discrepancy. Could that cause issues like this?

Dec 2 2021, 15:24 · Phorge

Dec 1 2021

MacFan4000 updated the task description for T15064: Make phorge compatible with PHP 8.1.
Dec 1 2021, 17:28 · Phorge
speck added a comment to T15064: Make phorge compatible with PHP 8.1.

I noticed this recently too. These PHP 8 updates have been frustrating because it breaks Arcanist for users as well...

Dec 1 2021, 17:07 · Phorge
speck added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

A few months back this story came up on hackernews which seems relevant. There might be things in there we can attempt to appeal to Microsoft to allow emails from this Phorge instance to go through

Dec 1 2021, 16:44 · Phorge
MacFan4000 added a comment to T15064: Make phorge compatible with PHP 8.1.

After making lots of changes in my clone to suppress deprecation warnings, I am stuck at the following error.
[Wed Dec 01 16:06:24.853494 2021] [proxy_fcgi:error] [pid 2472770:tid 139879417599744] [client <REDACTED>] AH01071: Got error 'PHP message: [2021-12-01 16:06:24] EXCEPTION: (Exception) Bad getter call: getPreferences at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1620]
PHP message: arcanist(head=master, ref.master=c53bb21bbd3e), phabricator(head=master, ref.master=4448a93a4067), testwiki-ext-misc(head=master, ref.master=c12e85d3a97a)
PHP message: #0 <#2> LiskDAO::call(string, array) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1598]
PHP message: #1 <#2> LiskDAO::call(string, array) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:446]
PHP message: #2 <#2> PhabricatorUser::loadGlobalSettings() called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:377]
PHP message: #3 <#2> PhabricatorUser::getUserSetting(string) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:428]
PHP message: #4 <#2> PhabricatorUser::getTranslation() called at [<phabricator>/src/applications/auth/engine/PhabricatorAuthSessionEngine.php:1127]
PHP message: #5 <#2> PhabricatorAuthSessionEngine::willServeRequestForUser(PhabricatorUser) called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:109]
PHP message: #6 <#2> PhabricatorController::willBeginExecution() called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:271]
PHP message: #7 phlog(Exception) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
PHP message: #8 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, Exception) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
PHP message: #9 AphrontApplicationConfiguration::handleThrowable(Exception) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
PHP message: #10 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message Log, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP messaghutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]PHP messaguration.php:204]
PHP messaglicationConfiguration.php:204]PHP messagont/configuration/AphrontApplicationConfiguration.php:204]
PHP messagd at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message aphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message: #11 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]PHP message: [2021-12-01 16:06:24] EXCEPTION: (PhutilAggregateException) Encountered a processing exception, then another exception when trying to build a response for the first exception.\n - Exception: Bad setter call: setUserPHID\n - Exception: Bad getter call: getPreferences at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:316]
PHP message: arcanist(head=master, ref.master=c53bb21bbd3e), phabricator(head=master, ref.master=4448a93a4067), testwiki-ext-misc(head=master, ref.master=c12e85d3a97a)
PHP message: #0 <#4> LiskDAO::call(string, array) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:446]
PHP message: #1 <#4> PhabricatorUser::loadGlobalSettings() called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:377]
PHP message: #2 <#4> PhabricatorUser::getUserSetting(string) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:428]
PHP message: #3 <#4> PhabricatorUser::getTranslation() called at [<phabricator>/src/applications/auth/engine/PhabricatorAuthSessionEngine.php:1127]
PHP message: #4 <#4> PhabricatorAuthSessionEngine::willServeRequestForUser(PhabricatorUser) called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:109]
PHP message: #5 <#4> PhabricatorController::willBeginExecution() called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:271]
PHP message: #6 <#3> LiskDAO::call(string, array) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1598]
PHP message: #7 <#3> LiskDAO::__call(string, array) called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:666]PHP message: #8 <#3> PhabricatorApplicationSearchEngine::getBuiltinQueries() called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:500]
PHP message: #9 <#3> PhabricatorApplicationSearchEngine::loadAllNamedQueries() called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:537]
PHP message: #10 <#3> PhabricatorApplicationSearchEngine::loadEnabledNamedQueries() called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:157]
PHP message: #11 <#3> PhabricatorMainMenuSearchView::getGlobalSearchScopeItems(PhabricatorUser, PhabricatorFlagsApplication) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:205]
PHP message: #12 <#3> PhabricatorMainMenuSearchView::buildModeSelector(string, string) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:89]
PHP message: #13 <#3> javelin_tag(string, array, array) called at [<phabricator>/src/view/phui/PHUIListItemView.php:426]
PHP message: #14 <#3> phutil_tag(string, array, array) called at [<phabricator>/src/infrastructure/javelin/markup.php:70]
PHP message: #15 <#3> javelin_tag(string, array, array) called at [<phabricator>/src/view/AphrontTagView.php:161]
PHP message: #16 <#3> AphrontTagView::render() called at [<phabricator>/src/view/AphrontView.php:222]
PHP message: #17 <#3> AphrontView::producePhutilSafeHTML() called at [<phabricator>/src/infrastructure/markup/render.php:111]
PHP message: #18 <#3> phutil_escape_html(PHUIListView) called at [<phabricator>/src/infrastructure/markup/render.php:135]
PHP message: #19 <#3> phutil_escape_html(array) called at [<phabricator>/src/infrastructure/markup/render.php:97]
PHP message: #20 <#3> phutil_tag(string, array, array) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuView.php:168]
PHP message: #21 <#3> PhabricatorMainMenuView::render() called at [<phabricator>/src/view/page/PhabricatorStandardPageView.php:374]
PHP message: #22 <#3> PhabricatorStandardPageView::willRenderPage() called at [<phabricator>/src/view/page/AphrontPageView.php:46]
PHP message: #23 <#3> AphrontPageView::render() called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:286]
PHP message: #24 <#3> PhabricatorController::willSendResponse(AphrontDialogResponse) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:300]
PHP message: #25 <#2> AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message: #26 <#2> AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]
PHP message: #27 phlog(PhutilAggregateException) called at [<phabricator>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
PHP message: #28 AphrontUnhandledExceptionResponse::setException(PhutilAggregateException) called at [<phabricator>/webroot/index.php:46]'

Dec 1 2021, 16:16 · Phorge

Nov 30 2021

MacFan4000 created T15064: Make phorge compatible with PHP 8.1.
Nov 30 2021, 23:39 · Phorge

Nov 29 2021

MacFan4000 published a new version of Welcome.
Nov 29 2021, 16:44 · Phorge
MacFan4000 edited the content of Welcome.
Nov 29 2021, 16:34 · Phorge

Nov 28 2021

Bukkit created T15063: Change Letter PFP Upon Rename.
Nov 28 2021, 00:50 · Phorge

Nov 3 2021

MacFan4000 added projects to T15060: Better Pirate English: Phorge, Localization.
Nov 3 2021, 15:24 · Localization, Phorge

Nov 2 2021

dbn added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

We had a similar issue with Microsoft email on our own custom mail server. Microsoft delivers mail for several domains from the same email service, so this similarly affects email from outlook.com, hotmail.com, live.com and msn.com. See https://postmaster.live.com/pm/policies.aspx for details.

Nov 2 2021, 15:47 · Phorge
codemouse92 added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

This is likely related more to the configuration of the email server. Outlook is very picky, and as far as I know, checks the headers for all of the following:

Nov 2 2021, 14:02 · Phorge

Oct 31 2021

Ekubischta added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

I can confirm as well that I have never received an email from phorge / phabricator on my email which isn't "outlook.com" but is an office 365 email account

Oct 31 2021, 02:09 · Phorge

Oct 30 2021

chris added a comment to T15059: Phabricator doesn't email @outlook.com addresses.

Do you have any additional repro steps? Mail config will be specific to the Phab/Phorge install. If this is specific to our Phorge installation, yeah... it's sucky. We self-host our email server and that means we're subject to all of the arcane and mystic requirements there. As far as we can tell, it's set up as correctly as is possible (SPF, DKIM, DMARC all configured correctly; domain is old enough that it doesn't negatively impact our trust scores; etc.). (A current spam test result for reference.)

Oct 30 2021, 22:42 · Phorge
Labricator added a comment to T15054: Improve Feed search filters to hide "minor activities".

@valerio.bozzolan Fancy seeing you here. I'm Void from your phabricator instance.

Oct 30 2021, 22:27 · Phorge
Labricator created T15059: Phabricator doesn't email @outlook.com addresses.
Oct 30 2021, 22:26 · Phorge
chris changed the edit policy for T15004: Decide who has admin/commit/security access.
Oct 30 2021, 16:26 · Governance, Phorge
Labricator added a comment to T15033: Add option for GDPR Warning Suggestion.

Yes, that's why I'm saying "yeah, great idea, let's do this, but let's also create a config toggle so that it can be disabled for people and orgs who don't need it".

Oct 30 2021, 16:21 · Phorge
chris renamed T15004: Decide who has admin/commit/security access from Nightster383Decide who has admin/commit/security access to Decide who has admin/commit/security access.
Oct 30 2021, 16:20 · Governance, Phorge

Oct 29 2021

golyalpha added a comment to T15033: Add option for GDPR Warning Suggestion.

@golyalpha As my current employer is one of the largish companies, (50,000+ international employees), but not primarily software focused we have all been given GDPR awareness training but do not have a general, all employees, GDPR statement available nor a standard text or set of texts to use.
When I was deploying a Phabricator instance I actually had to come up with the wording myself and then get it approved by the legal & compliance team - my biggest hurdle was convincing them of the required data retention period - they were much more used to systems such as payroll & HR where records are only retained for a fixed number of years after the period of employment as demanded by things like the local tax regulations and the idea that due to legal liability, etc., we needed to retain the information for the full life of the product being developed and possibly beyond if components were reused.

Oct 29 2021, 08:04 · Phorge
gadgetsteve added a comment to T15033: Add option for GDPR Warning Suggestion.

@dcog Just:

Oct 29 2021, 07:17 · Phorge
dcog added a comment to T15033: Add option for GDPR Warning Suggestion.

@golyalpha As my current employer is one of the largish companies, (50,000+ international employees), but not primarily software focused we have all been given GDPR awareness training but do not have a general, all employees, GDPR statement available nor a standard text or set of texts to use.
When I was deploying a Phabricator instance I actually had to come up with the wording myself and then get it approved by the legal & compliance team - my biggest hurdle was convincing them of the required data retention period - they were much more used to systems such as payroll & HR where records are only retained for a fixed number of years after the period of employment as demanded by things like the local tax regulations and the idea that due to legal liability, etc., we needed to retain the information for the full life of the product being developed and possibly beyond if components were reused.

Oct 29 2021, 06:55 · Phorge
gadgetsteve added a comment to T15033: Add option for GDPR Warning Suggestion.

@golyalpha As my current employer is one of the largish companies, (50,000+ international employees), but not primarily software focused we have all been given GDPR awareness training but do not have a general, all employees, GDPR statement available nor a standard text or set of texts to use.
When I was deploying a Phabricator instance I actually had to come up with the wording myself and then get it approved by the legal & compliance team - my biggest hurdle was convincing them of the required data retention period - they were much more used to systems such as payroll & HR where records are only retained for a fixed number of years after the period of employment as demanded by things like the local tax regulations and the idea that due to legal liability, etc., we needed to retain the information for the full life of the product being developed and possibly beyond if components were reused.

Oct 29 2021, 06:07 · Phorge