Is the extension still maintained? While there is no extension store yet, it's possible to host repositories here. https://we.phorge.it/w/docs/extensions/phactory/
Feed All Stories
Mon, Dec 2
Mon, Dec 2
valerio.bozzolan added a project to T15742: When creating a Diffusion Repo, add helpful text to each field: UX.
• l2dy added a comment to T15062: Introducing Phixator 2.
aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Open.
aklapper closed T15963: LDAP over TLS is broken as Resolved by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
aklapper committed rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…
Sun, Dec 1
Sun, Dec 1
pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Add the newlline
taavi added a comment to D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
this unfortunately caused T15963: LDAP over TLS is broken :/
valerio.bozzolan added a comment to D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)
Sat, Nov 30
Sat, Nov 30
Double slam accept
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.
Simplify return of validateRealName() as proposed by Valerio
Fri, Nov 29
Fri, Nov 29
valerio.bozzolan updated the task description for T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?
sgtm. Thanks :) just that comment
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.
Thanks for catching that! Amend in new PhutilNumber()
aklapper updated the summary of D25841: Account registration: Restrict Real Name length.
• l2dy added inline comments to D25841: Account registration: Restrict Real Name length.
aklapper requested review of D25841: Account registration: Restrict Real Name length.
aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Finally got a reproducer URI in downstream:
Siz3r303 awarded F2660661: profile a Pirate Logo token.
Thu, Nov 28
Thu, Nov 28
aklapper awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
valerio.bozzolan awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
aklapper committed rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Avoid "Unknown Object (????)" for custom Select field values in Herald editor
aklapper added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
valerio.bozzolan closed Q158: Is there a way to create a task in Maniphest via a webhook? as resolved.
arp awarded Q158: Is there a way to create a task in Maniphest via a webhook? a Like token.
20after4 added a comment to Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).
Yes maniphest.edit is the modern way to do it.
20after4 updated the task description for T15961: Should we adopt modern PHP type hints in Phorge source code?.
Nov 27 2024
Nov 27 2024
valerio.bozzolan added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.
valerio.bozzolan accepted D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Thanks for the comment
Nov 26 2024
Nov 26 2024
aklapper updated the task description for T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".
Works on my machine!
Validate some user provided calendar query range dates
Thanks :)
aklapper committed rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.
Also update the PhpDoc accordingly
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.
Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead
valerio.bozzolan accepted D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
aklapper requested review of D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Make maniphest.gettasktransactions include metadata and title
avivey awarded T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them a Burninate token.
aklapper closed T15945: Allow zooming Phorge pages on mobile as Resolved by committing rP828ea9bca030: Allow zooming on pages.
aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception
aklapper requested review of D25835: Strip surrounding whitespace from project and task titles.
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.
Handle whitespace-only task and project titles correctly
aklapper updated the test plan for D25835: Strip surrounding whitespace from project and task titles.
aklapper planned changes to D25835: Strip surrounding whitespace from project and task titles.
This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)
Fix a typo in documentation
Nov 25 2024
Nov 25 2024
Fix submitting forms in a new tab using Ctrl+Return
Nov 24 2024
Nov 24 2024
avivey accepted D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.
• l2dy edited the content of Organizations Using Phorge.
Nov 23 2024
Nov 23 2024
pppery added a comment to D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.
pppery renamed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing from RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing to RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
pppery updated the test plan for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Fix lint
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Step 2: Remove irrelevant character class exclusions: