Page MenuHomePhorge
Feed All Stories

Sun, Dec 8

taavi requested review of D25851: docs: Remove extra 'B' from PHP config value.
Sun, Dec 8, 11:31
taavi created T15971: Protect against duplicate form submission.
Sun, Dec 8, 11:03 · Feature Requests
taavi added inline comments to D25850: Allow customizing default Phurl view and edit policies.
Sun, Dec 8, 10:42
taavi updated the diff for D25850: Allow customizing default Phurl view and edit policies.

Fix my local unit test config

Sun, Dec 8, 10:40
taavi requested review of D25850: Allow customizing default Phurl view and edit policies.
Sun, Dec 8, 10:37
taavi added a revision to T15970: phurl: Allow setting default edit policy for URLs: D25850: Allow customizing default Phurl view and edit policies.
Sun, Dec 8, 10:37 · Policy, Feature Requests
valerio.bozzolan added a project to T15970: phurl: Allow setting default edit policy for URLs: Policy.

Thanks. I see, from this page is not possible:

Sun, Dec 8, 09:49 · Policy, Feature Requests

Sat, Dec 7

speck added a comment to T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns.

What can a malicious user accomplish by claiming unverified email for commits? The idea outlined here sounds right but I’d like to understand what potential harm could be done on its current state, and also whether there’s any legitimate use case for the current behavior.

Sat, Dec 7, 16:10 · Spam mitigation, Diffusion, Security
taavi created T15970: phurl: Allow setting default edit policy for URLs.
Sat, Dec 7, 11:26 · Policy, Feature Requests

Fri, Dec 6

aklapper closed T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fri, Dec 6, 12:17 · PHP 8 support
aklapper closed D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Fri, Dec 6, 12:17
aklapper closed T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails as Resolved by committing rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Fri, Dec 6, 12:17 · PHP 8 support
aklapper committed rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test
Fri, Dec 6, 12:17
valerio.bozzolan closed D25844: Add first unit test for mimemailparser headers.
Fri, Dec 6, 12:13
valerio.bozzolan committed rP9d3e25885335: Add first unit test for mimemailparser headers.
Add first unit test for mimemailparser headers
Fri, Dec 6, 12:12
valerio.bozzolan accepted D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Double slam-accept

Fri, Dec 6, 12:12
aklapper updated the diff for D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Right... one day I may get used to all those Phorge shortcuts, thanks

Fri, Dec 6, 11:58
aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Oops, no for real

Fri, Dec 6, 11:49
aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

Uhm, right, heh

Fri, Dec 6, 11:48

Thu, Dec 5

valerio.bozzolan accepted D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

...like line 105 :)

Thu, Dec 5, 22:57
valerio.bozzolan added a comment to D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

Thu, Dec 5, 22:40
aklapper added a revision to T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data: D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.
Thu, Dec 5, 22:38
aklapper requested review of D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.
Thu, Dec 5, 22:38
aklapper created T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data.
Thu, Dec 5, 22:28
valerio.bozzolan accepted D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

lgtm

Thu, Dec 5, 22:07
aklapper added a revision to T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails: D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Thu, Dec 5, 18:04 · PHP 8 support
aklapper requested review of D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Thu, Dec 5, 18:04
pppery closed D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Thu, Dec 5, 17:40
pppery closed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing as Resolved by committing rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.
Thu, Dec 5, 17:40 · Bug Reports, Remarkup, Affects-Wikimedia
pppery committed rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.
Rewrite regex for project names to be not prone to catastrophic backtracking
Thu, Dec 5, 17:40
pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Rebase

Thu, Dec 5, 17:39
aklapper accepted D25847: Fix regression in Remarkup unit tests and harden.

I applied this patch locally on top of git master and output does not complain anymore about 'link-brackets.txt' (thus it's correct) but fails in link-edge-cases.txt now (thus it's likely not complete):

Thu, Dec 5, 17:38
aklapper created T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails.
Thu, Dec 5, 17:25 · PHP 8 support
valerio.bozzolan added a revision to T15967: Fix unit test PhutilPygmentizeParserTestCase: D25847: Fix regression in Remarkup unit tests and harden.
Thu, Dec 5, 15:52 · Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan requested review of D25847: Fix regression in Remarkup unit tests and harden.
Thu, Dec 5, 15:52
valerio.bozzolan updated the task description for T15967: Fix unit test PhutilPygmentizeParserTestCase.
Thu, Dec 5, 15:50 · Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan created T15967: Fix unit test PhutilPygmentizeParserTestCase.
Thu, Dec 5, 15:48 · Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan moved T15966: Fix unit test PhabricatorChangeParserTestCase::testSubversionPartialParser for non-English terminals from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Thu, Dec 5, 15:44 · Bug Reports, User-valerio.bozzolan, Diffusion
valerio.bozzolan added a revision to T15966: Fix unit test PhabricatorChangeParserTestCase::testSubversionPartialParser for non-English terminals: D25846: Fix Diffusion commands in non-English environments.
Thu, Dec 5, 15:43 · Bug Reports, User-valerio.bozzolan, Diffusion
valerio.bozzolan requested review of D25846: Fix Diffusion commands in non-English environments.
Thu, Dec 5, 15:43
valerio.bozzolan updated the diff for D25845: Repository Identity "Automatically Detected User": don't trust unverified emails.

run unit test

Thu, Dec 5, 15:35
valerio.bozzolan created T15966: Fix unit test PhabricatorChangeParserTestCase::testSubversionPartialParser for non-English terminals.
Thu, Dec 5, 15:34 · Bug Reports, User-valerio.bozzolan, Diffusion
valerio.bozzolan claimed T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns.
Thu, Dec 5, 10:09 · Spam mitigation, Diffusion, Security
valerio.bozzolan changed the visibility for D25845: Repository Identity "Automatically Detected User": don't trust unverified emails.
Thu, Dec 5, 10:02
valerio.bozzolan updated subscribers of T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns.

Adding @aklapper as subscriber in this security issue since I trust this user (unclear if this should be flagged as security thought, feel free to open)

Thu, Dec 5, 10:01 · Spam mitigation, Diffusion, Security
valerio.bozzolan changed the edit policy for D25845: Repository Identity "Automatically Detected User": don't trust unverified emails.
Thu, Dec 5, 09:58
valerio.bozzolan requested review of D25845: Repository Identity "Automatically Detected User": don't trust unverified emails.
Thu, Dec 5, 09:58
valerio.bozzolan added a revision to T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns: D25845: Repository Identity "Automatically Detected User": don't trust unverified emails.
Thu, Dec 5, 09:58 · Spam mitigation, Diffusion, Security
valerio.bozzolan created T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns.
Thu, Dec 5, 09:57 · Spam mitigation, Diffusion, Security
valerio.bozzolan raised the priority of T15556: Improve Diffusion identity reassignment propagation from Low to Normal.
Thu, Dec 5, 08:21 · Bug Reports, Diffusion

Wed, Dec 4

valerio.bozzolan assigned T15412: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch to jkimbo.
Wed, Dec 4, 16:08 · PHP 8 support
l2dy added a comment to T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.

This seems to impact mail deliverability to @icloud.com addresses too.

Wed, Dec 4, 15:29 · phorge.it install
valerio.bozzolan added a member for Trusted Contributors: reet-.
Wed, Dec 4, 10:55
valerio.bozzolan awarded T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses a Cup of Joe token.
Wed, Dec 4, 08:06 · phorge.it install
avivey claimed T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.

Please "remind" me about this ticket as often as possible, so I will fix it. I have everything I need to actually fix this, except the willpower.

Wed, Dec 4, 08:05 · phorge.it install
valerio.bozzolan added a subtask for T15059: Phabricator doesn't email @outlook.com addresses: T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.
Wed, Dec 4, 07:50 · phorge.it install
valerio.bozzolan added a parent task for T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses: T15059: Phabricator doesn't email @outlook.com addresses.
Wed, Dec 4, 07:50 · phorge.it install
valerio.bozzolan added inline comments to D25844: Add first unit test for mimemailparser headers.
Wed, Dec 4, 07:49
valerio.bozzolan added inline comments to D25835: Strip surrounding whitespace from project and task titles.
Wed, Dec 4, 06:59
valerio.bozzolan closed T15964: "Delete Repository" button: it's a bit scaring (always active) as Resolved by committing rP48fd3f1c40de: Delete Repository button: disable if not admin, but show popup to all.
Wed, Dec 4, 06:52 · UX, Diffusion
valerio.bozzolan closed D25843: Delete Repository button: disable if not admin, but show popup to all.
Wed, Dec 4, 06:52
valerio.bozzolan committed rP48fd3f1c40de: Delete Repository button: disable if not admin, but show popup to all.
Delete Repository button: disable if not admin, but show popup to all
Wed, Dec 4, 06:51
valerio.bozzolan added a comment to T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.

We should maybe rewrite a bit the proposed solution, since ideally it's possible to use upstream.phorge.dev but it should be at least reachable to pass some anti-spam checkers I guess. At the moment it isn't:

Wed, Dec 4, 06:49 · phorge.it install

Tue, Dec 3

aklapper updated the test plan for D25790: Show table of contents by default on wide screens.
Tue, Dec 3, 23:07
aklapper accepted D25790: Show table of contents by default on wide screens.

@mturdus: Thanks! LGTM

Tue, Dec 3, 23:06
aklapper added a comment to D25835: Strip surrounding whitespace from project and task titles.

@valerio.bozzolan: Feel free to give this revised version another review :)

Tue, Dec 3, 23:02
aklapper accepted D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Big thanks for digging deep into that regex (on which I gave up).

Tue, Dec 3, 22:43
aklapper accepted D25844: Add first unit test for mimemailparser headers.

Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

Tue, Dec 3, 22:24
aklapper updated the test plan for D25844: Add first unit test for mimemailparser headers.
Tue, Dec 3, 21:20
taavi added a comment to D25844: Add first unit test for mimemailparser headers.

I hope you won't send me a lawyer

do you really think I could afford one

Tue, Dec 3, 17:18
MacFan4000 edited reviewers for D25839: Fix parsing of incoming mail with UTF-8 encoded headers, added: O1: Blessed Committers, taavi, valerio.bozzolan; removed: Blessed Committers.
Tue, Dec 3, 17:14
MacFan4000 edited reviewers for D25839: Fix parsing of incoming mail with UTF-8 encoded headers, added: Blessed Committers; removed: 3tayesh.
Tue, Dec 3, 17:13
MacFan4000 changed the author of D25839: Fix parsing of incoming mail with UTF-8 encoded headers from 3tayesh to aklapper.
Tue, Dec 3, 17:12
avivey changed the visibility for D25043: Upload compressed logo, update HTML.
Tue, Dec 3, 16:22
avivey changed the visibility for D25041: Home Page.
Tue, Dec 3, 16:21
avivey added a comment to D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

@3tayesh Please don't do that again.

Tue, Dec 3, 16:17
avivey changed the visibility for D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Dec 3, 16:17
Policy changed the edit policy for D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Dec 3, 16:16
Policy changed the visibility for D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Dec 3, 16:16
valerio.bozzolan updated the test plan for D25844: Add first unit test for mimemailparser headers.
Tue, Dec 3, 15:53
valerio.bozzolan updated the diff for D25844: Add first unit test for mimemailparser headers.

git rebase origin/master

Tue, Dec 3, 15:52
valerio.bozzolan added a comment to D25844: Add first unit test for mimemailparser headers.

lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer

Tue, Dec 3, 15:48
valerio.bozzolan updated the summary of D25844: Add first unit test for mimemailparser headers.
Tue, Dec 3, 15:47
valerio.bozzolan requested review of D25844: Add first unit test for mimemailparser headers.
Tue, Dec 3, 15:44
valerio.bozzolan added a revision to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them: D25844: Add first unit test for mimemailparser headers.
Tue, Dec 3, 15:44 · Bug Reports
3tayesh commandeered D25839: Fix parsing of incoming mail with UTF-8 encoded headers from aklapper.
Tue, Dec 3, 15:09
aklapper closed T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them as Resolved by committing rPc589529155d6: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Dec 3, 12:39 · Bug Reports
aklapper closed D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Dec 3, 12:39
aklapper committed rPc589529155d6: Fix parsing of incoming mail with UTF-8 encoded headers.
Fix parsing of incoming mail with UTF-8 encoded headers
Tue, Dec 3, 12:39
valerio.bozzolan accepted D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

I tried to prepare a unit test but it's not working. But yes it seems to work thanks

Tue, Dec 3, 12:01
valerio.bozzolan added a comment to D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

(Sorry I cannot test now) Does the test plan work with just this?

Tue, Dec 3, 11:24
valerio.bozzolan added a comment to D25843: Delete Repository button: disable if not admin, but show popup to all.

Nice question avivey. We could always disable this but maybe "newcomer admins" may not try to click it, so with more confusion from the other (Dark) Side.

Tue, Dec 3, 05:52

Mon, Dec 2

avivey accepted D25843: Delete Repository button: disable if not admin, but show popup to all.

Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.

Mon, Dec 2, 21:24
valerio.bozzolan requested review of D25843: Delete Repository button: disable if not admin, but show popup to all.
Mon, Dec 2, 20:19
valerio.bozzolan added a revision to T15964: "Delete Repository" button: it's a bit scaring (always active): D25843: Delete Repository button: disable if not admin, but show popup to all.
Mon, Dec 2, 20:19 · UX, Diffusion
valerio.bozzolan added a project to T15964: "Delete Repository" button: it's a bit scaring (always active): UX.
Mon, Dec 2, 20:15 · UX, Diffusion
valerio.bozzolan created T15964: "Delete Repository" button: it's a bit scaring (always active).
Mon, Dec 2, 20:13 · UX, Diffusion
aklapper closed D25841: Account registration: Restrict Real Name length.
Mon, Dec 2, 19:36
aklapper closed T15962: Account registration: Handle too long Real Name more gracefully as Resolved by committing rPeb380f922c9a: Account registration: Restrict Real Name length.
Mon, Dec 2, 19:36
aklapper committed rPeb380f922c9a: Account registration: Restrict Real Name length.
Account registration: Restrict Real Name length
Mon, Dec 2, 19:36