I also faced this, tested @ D25623, and found out git format-patch was emitting that result which causes git apply to fail. See this git format-patch example.

Yeah, on my todo list for the weekend.

And my spam filter says:

(Premising that this is an answer to your question. Please move this as comment to your question.)

Nice but please smaller :D

Thanks! I was able to test visiting a profile image, and inspecting phlog() in the webserver log.

Thanks. I was able to test that the thing is just a string, not an object with a toString(), so no nuclear implosions

Garrr I am so sure I had tested it this morning but maybe I was sleepwalking? Tested again now and seems to work, thanks

Giving a +1 as I had tested this in D25080#16527 but I would prefer to see the two strings adjusted in D25080#16549

I currently cannot think of other potential side effects (mail notifications about task creation seem to have had a [Created] prefix taking priority over other actions for years, and web notifications in the top bar also still behave as before), so I'll give my +1

(If it does not work you may still need to call .toString() before doing this)

The coffee on my desk doesn't seem to work yet - use a proper comparison.

Use standard JS string concatenation instead of shiny padStart() because better backwards compatibility

In D25630#17685, @valerio.bozzolan wrote:

I think somebody here would propose to avoid padStart() and be boring:

if (d_m.length < 2) {
  d_m = '0' + d_m;
}

For some reasons I cannot cleanly apply the patch anymore.

In T15820#17365, @valerio.bozzolan wrote:

Just because we can, right? Or any real concern?

Just because we can, right? Or any real concern?

✅ Number.prototype.toString() supported by all browser webs https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toString

This fix was super-interesting. Thanks again for the report.

Thanks again. My only concern is that, if somebody has a 1 trillion file(s) then the patch may lock the involved tables for an unexpected long amount of time, and you cannot really undo, without causing a massive implicit rollback.

The approach taken in D25621 is more wholesome and preferable thus abandoning this

It worked in line 109, it will work in line 154. Tested.

Cover more cases that require login:

Wow you are fast. I was going to create this :D I can reproduce

Commanding to set as abandoned. Thanks again! Well done for your original troubleshooting.

This makes sense.

git rebase master

Tested locally before and after applying this branch, with two users sending messages in a chat room after clicking the speechbubbles icon in top bar and selecting "Persistent Chat", both functionality wise (clicking the bar in the lower right corner) and by inspecting the element in the web browser's developer tools' inspector. Works as expected.

Just as clarification for myself (maybe already obvious to others):

Thanks for working on this! Works pretty well locally. From a quick test of this branch, while being logged out,

• Maniphest Advanced Search: Setting Assigned to to Current Viewer, I get a Login page.
• Diffusion Commits Advanced Search: Setting Authors to Current Viewer, I get a Login page.
• Differential Advanced Search: Setting both Authors and Reviewers to Current Viewer, I get a Login page.
• Differential Advanced Search: Setting Responsible Users to Current Viewer, I get an exception (DifferentialResponsibleDatasource - probably another source to cover here?)

Thanks again Roberto.