Page MenuHomePhorge

TransactionEditor: micro-optimize the "creation finder"
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 08:32.
Tags
None
Referenced Files
F3296363: D25627.1742972051.diff
Tue, Mar 25, 06:54
F3292880: D25627.1742902215.diff
Mon, Mar 24, 11:30
F3292817: D25627.1742901521.diff
Mon, Mar 24, 11:18
F3290211: D25627.1742861900.diff
Mon, Mar 24, 00:18
F3289999: D25627.1742857819.diff
Sun, Mar 23, 23:10
F3249490: D25627.1742286327.diff
Mon, Mar 17, 08:25
F3216817: D25627.1741716464.diff
Mon, Mar 10, 18:07
F3147995: D25627.1741216757.diff
Tue, Mar 4, 23:19

Details

Summary

The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.

When we have found that, let's stop that loop, so, we save some CPU cycles.

Test Plan

Note that getTransactionType() has not side-effects.

Test some applications - like Pholio - that use the TransactionEditor:

  • Create a new Pholio and Save
  • Save it again without changes.
  • Save it again with changes.

Everything still working normally.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable