Page MenuHomePhorge

TransactionEditor: micro-optimize the "creation finder"
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 08:32.
Tags
None
Referenced Files
F4074201: D25627.1746864220.diff
Fri, May 9, 08:03
F4046089: D25627.1746737112.diff
Wed, May 7, 20:45
F4016160: D25627.1746646343.diff
Tue, May 6, 19:32
F4015263: D25627.1746639715.diff
Tue, May 6, 17:41
F4011427: D25627.1746625943.diff
Tue, May 6, 13:52
F3992692: D25627.1746599190.diff
Tue, May 6, 06:26
F3961152: D25627.1746504020.diff
Mon, May 5, 04:00
F3927556: D25627.1746386646.diff
Sat, May 3, 19:24

Details

Summary

The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.

When we have found that, let's stop that loop, so, we save some CPU cycles.

Test Plan

Note that getTransactionType() has not side-effects.

Test some applications - like Pholio - that use the TransactionEditor:

  • Create a new Pholio and Save
  • Save it again without changes.
  • Save it again with changes.

Everything still working normally.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable