Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck
ClosedPublic

Authored by aklapper on May 10 2024, 10:22.
Tags
None
Referenced Files
F2979677: D25633.1739868591.diff
Mon, Feb 17, 08:49
F2965221: D25633.1739428453.diff
Wed, Feb 12, 06:34
F2959923: D25633.1739138698.diff
Sat, Feb 8, 22:04
F2957930: D25633.1739088286.diff
Sat, Feb 8, 08:04
F2949018: D25633.1738599753.diff
Sun, Feb 2, 16:22
F2943720: D25633.1738218859.diff
Wed, Jan 29, 06:34
F2938391: D25633.1737994435.diff
Sun, Jan 26, 16:13
F2937128: D25633.1737947761.diff
Sun, Jan 26, 03:16

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/config/check/PhabricatorSetupCheck.php:125]

Closes T15823

Test Plan

Run ./bin/cache purge --all, check any Phorge page in browser before and after applying this patch.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable