Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck
ClosedPublic

Authored by aklapper on Fri, May 10, 10:22.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 21, 00:41
Unknown Object (File)
Mon, May 20, 18:32
Unknown Object (File)
Mon, May 20, 11:04
Unknown Object (File)
Mon, May 20, 07:57
Unknown Object (File)
Sun, May 19, 22:29
Unknown Object (File)
Sun, May 19, 00:55
Unknown Object (File)
Sat, May 18, 03:08
Unknown Object (File)
Fri, May 17, 20:50

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/config/check/PhabricatorSetupCheck.php:125]

Closes T15823

Test Plan

Run ./bin/cache purge --all, check any Phorge page in browser before and after applying this patch.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable