Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck
ClosedPublic

Authored by aklapper on May 10 2024, 10:22.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 24, 06:43
Unknown Object (File)
Tue, Jul 23, 01:25
Unknown Object (File)
Sat, Jul 20, 21:14
Unknown Object (File)
Fri, Jul 19, 16:37
Unknown Object (File)
Fri, Jul 19, 16:37
Unknown Object (File)
Fri, Jul 19, 16:30
Unknown Object (File)
Fri, Jul 19, 15:08
Unknown Object (File)
Sat, Jul 13, 08:10

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/config/check/PhabricatorSetupCheck.php:125]

Closes T15823

Test Plan

Run ./bin/cache purge --all, check any Phorge page in browser before and after applying this patch.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable