Page MenuHomePhorge

Persistent Chat: fix de-minimize misclick
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 10:19.

Details

Summary

When the persistent chat is minimized to the bottom of your window, as mentioned in T15626,
the chat bar still has an invisible square area that does nothing if you click it by mistake:

Conpherence Settings Icon hidden.png (87×262 px, 13 KB)

That area was reserved for the Settings Icon, that appears only if you de-minimize the chat.

The Settings Icon was toggled incorrectly from CSS. It was just hiding the Font Awesome icon,
(.fa-gear), instead of hiding its clickable container.

After this change, chat can be de-minimized even if you click in that specific evil spot.

Original credit to @roberto.urbani for the original troubleshooting and original patch.

Follow-up from: D25428

Closes T15626

Test Plan

Show the Chat, then:

  • when the chat is de-collapsed:
    • you see the Settings icon (as before)
    • you can click on the Settings Icon (as before)
    • it shows the Settings menu (as before)
  • when the chat is collapsed:
    • you can click in whatever point, and it de-collapse (better than before)

Additionally, use the HTML inspector in your browser (F12 from Firefox),
to double-check that now that <li> has display: none when the chat is collapsed.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper subscribed.

Tested locally before and after applying this branch, with two users sending messages in a chat room after clicking the speechbubbles icon in top bar and selecting "Persistent Chat", both functionality wise (clicking the bar in the lower right corner) and by inspecting the element in the web browser's developer tools' inspector. Works as expected.

This revision is now accepted and ready to land.May 9 2024, 11:30