Persistent Chat: fix de-minimize misclick
ClosedPublic
Actions

Authored by valerio.bozzolan on Thu, May 9, 10:19.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized

Commits

rP5b90567f6453: Persistent Chat: fix de-minimize misclick

Summary

When the persistent chat is minimized to the bottom of your window, as mentioned in T15626,
the chat bar still has an invisible square area that does nothing if you click it by mistake:

That area was reserved for the Settings Icon, that appears only if you de-minimize the chat.

The Settings Icon was toggled incorrectly from CSS. It was just hiding the Font Awesome icon,
(.fa-gear), instead of hiding its clickable container.

After this change, chat can be de-minimized even if you click in that specific evil spot.

Original credit to @roberto.urbani for the original troubleshooting and original patch.

Follow-up from: D25428

Closes T15626

Test Plan

Show the Chat, then:

when the chat is de-collapsed:
- you see the Settings icon (as before)
- you can click on the Settings Icon (as before)
- it shows the Settings menu (as before)
when the chat is collapsed:
- you can click in whatever point, and it de-collapse (better than before)

Additionally, use the HTML inspector in your browser (F12 from Firefox),
to double-check that now that <li> has display: none when the chat is collapsed.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Thu, May 9, 10:19

Owners added a reviewer: O1: Blessed Committers.Thu, May 9, 10:19

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptThu, May 9, 10:19

valerio.bozzolan requested review of this revision.Thu, May 9, 10:19

Harbormaster completed remote builds in B1238: Diff 1956.Thu, May 9, 10:19

valerio.bozzolan edited the summary of this revision. (Show Details)Thu, May 9, 10:21

valerio.bozzolan mentioned this in D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

valerio.bozzolan edited the test plan for this revision. (Show Details)Thu, May 9, 10:26

Tested locally before and after applying this branch, with two users sending messages in a chat room after clicking the speechbubbles icon in top bar and selecting "Persistent Chat", both functionality wise (clicking the bar in the lower right corner) and by inspecting the element in the web browser's developer tools' inspector. Works as expected.

This revision is now accepted and ready to land.Thu, May 9, 11:30

Closed by commit rP5b90567f6453: Persistent Chat: fix de-minimize misclick. · Explain WhyThu, May 9, 11:56

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP5b90567f6453: Persistent Chat: fix de-minimize misclick.