Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results
ClosedPublic

Authored by aklapper on May 9 2024, 11:24.
Tags
None
Referenced Files
F2944562: D25629.1738273087.diff
Wed, Jan 29, 21:38
F2938389: D25629.1737994419.diff
Sun, Jan 26, 16:13
F2936931: D25629.1737943681.diff
Sun, Jan 26, 02:08
F2933525: D25629.1737773735.diff
Fri, Jan 24, 02:55
F2933524: D25629.1737773732.diff
Fri, Jan 24, 02:55
F2933510: D25629.1737773046.diff
Fri, Jan 24, 02:44
F2933458: D25629.1737770014.diff
Fri, Jan 24, 01:53
F2898350: D25629.1737253690.diff
Sat, Jan 18, 02:28

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:154]

See also similar rPe65ac7b8800d3397abfced7824a8d316ec573d8f

Closes T15818

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable