Page MenuHomePhorge
Feed All Stories

Apr 12 2025

bekay committed R5:3170bc15592e: Use more css and phorge standard elements for application view.
Apr 12 2025, 13:12
mainframe98 added a comment to D25900: Remove the onboard "mailKey" from Paste.

What is (or rather was, I guess) that mailKey thingie good for?

Apr 12 2025, 12:38
bekay added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.

@bekay: Would you like to merge this?

Apr 12 2025, 12:14
bekay closed T15809: Homepage will overflow on small screens when feed content is too long as Resolved by committing rPd3cbfd952e15: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav….
Apr 12 2025, 12:12 · Feed, UX
bekay closed D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
Apr 12 2025, 12:12
bekay committed rPd3cbfd952e15: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav….
Apr 12 2025, 12:12
bekay updated the task description for T16029: Hovercard trigger inside hovercard content closes hovercard.
Apr 12 2025, 11:39 · UX, Bug Reports
bekay claimed T16029: Hovercard trigger inside hovercard content closes hovercard.
Apr 12 2025, 11:37 · UX, Bug Reports
bekay created T16029: Hovercard trigger inside hovercard content closes hovercard.
Apr 12 2025, 11:37 · UX, Bug Reports
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

What is (or rather was, I guess) that mailKey thingie good for? Or more relevant, I assume it's intentional after performing the Test Plan steps above that creating a new Paste does not create a new row in phabricator_metamta.metamta_mailproperties?
Apart from that, seems to work as expected. :) Thanks!

Apr 12 2025, 11:06
aklapper updated the test plan for D25900: Remove the onboard "mailKey" from Paste.
Apr 12 2025, 11:01

Apr 11 2025

pppery updated the diff for D25959: Simplify project regex further.

Fix

Apr 11 2025, 17:41
pppery updated the diff for D25959: Simplify project regex further.

Add test

Apr 11 2025, 17:38
bekay awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
Apr 11 2025, 15:47 · Phorge Development Tools, Discussion Needed
valerio.bozzolan added a comment to D25959: Simplify project regex further.

Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Apr 11 2025, 15:33
pppery requested review of D25959: Simplify project regex further.
Apr 11 2025, 15:27
pppery added a revision to T16028: New project remarkup rule misses some project names: D25959: Simplify project regex further.
Apr 11 2025, 15:27 · Bug Reports, Remarkup
pppery added a comment to T16028: New project remarkup rule misses some project names.

That's true of all projects - Remarkup here for instance.

Apr 11 2025, 15:13 · Bug Reports, Remarkup
bekay added a comment to T16028: New project remarkup rule misses some project names.

{#js-draw-lib} does work.

Apr 11 2025, 15:12 · Bug Reports, Remarkup
pppery added a comment to T16028: New project remarkup rule misses some project names.

{#js-draw-lib} does work.

Apr 11 2025, 15:07 · Bug Reports, Remarkup
bekay added Q172: Hover items are blocking the view (Answer 218).
Apr 11 2025, 15:07
bekay updated subscribers of T16028: New project remarkup rule misses some project names.

@pppery I don't know if you wanna step in, since the change was introduced by you.

Apr 11 2025, 14:41 · Bug Reports, Remarkup
bekay created T16028: New project remarkup rule misses some project names.
Apr 11 2025, 14:37 · Bug Reports, Remarkup
aklapper requested review of D25958: PHPDoc: Fix @return string for methods which can also return null.
Apr 11 2025, 09:51
aklapper edited the content of Next Up.
Apr 11 2025, 08:55
aklapper closed T15985: Fix UX regression in Phame as Resolved by committing rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54 · Phame, Bug Reports, UX
aklapper closed T15985: Fix UX regression in Phame, a subtask of T15920: Make table of contents visible when using wide screens, as Resolved.
Apr 11 2025, 08:54 · UX, Feature Requests
aklapper closed D25873: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54
aklapper committed rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 08:54
aklapper updated the diff for D25873: Fix overlapping elements in Phame for >1791px width.

git rebase master

Apr 11 2025, 08:53
avivey accepted D25873: Fix overlapping elements in Phame for >1791px width.
Apr 11 2025, 07:55
mainframe98 accepted D25955: Unhandled Exception: Add last call to error message.

This is great.

Apr 11 2025, 07:03
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Strip proceeding slash of path; wrap error message in quotation marks

Apr 11 2025, 07:02

Apr 10 2025

mainframe98 added a comment to D25955: Unhandled Exception: Add last call to error message.

Much better, two nitpicks:

Apr 10 2025, 17:44
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Only expose last call location if phabricator.developer-mode is set

Apr 10 2025, 11:21
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Thanks! Indeed I should have tested this more.

Apr 10 2025, 11:17
valerio.bozzolan awarded T16027: People Search: Allow querying by project membership a Like token.
Apr 10 2025, 10:15 · Feature Requests
aklapper created T16027: People Search: Allow querying by project membership.
Apr 10 2025, 09:41 · Feature Requests
aklapper updated the task description for T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Apr 10 2025, 09:07 · Feature Requests
aklapper created T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Apr 10 2025, 09:06 · Feature Requests
valerio.bozzolan added a comment to Q167: Personal Herald rule for repository activity (Answer 217).

I don't know this detail my friend. Let's wait for other answers.

Apr 10 2025, 08:48
aklapper added a project to T15846: Show previous value in transaction title when removing points or a custom field value set at task initialization: Affects-Wikimedia.
Apr 10 2025, 08:31 · Affects-Wikimedia
reet- added a comment to Q167: Personal Herald rule for repository activity (Answer 217).

Thanks for this info. We configured permanent refs for all our repositories, but I'm not sure I'm getting e-mails for these.

Apr 10 2025, 08:25
valerio.bozzolan updated the answer details for Q167: Personal Herald rule for repository activity (Answer 217).
Apr 10 2025, 06:54
valerio.bozzolan updated the answer details for Q167: Personal Herald rule for repository activity (Answer 217).
Apr 10 2025, 06:54
valerio.bozzolan added Q167: Personal Herald rule for repository activity (Answer 217).
Apr 10 2025, 06:54

Apr 9 2025

mainframe98 requested review of D25957: Replace usages of PhutilProxyException.
Apr 9 2025, 18:20
mainframe98 added a revision to T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler: D25957: Replace usages of PhutilProxyException.
Apr 9 2025, 18:20
mainframe98 requested review of D25956: Replace usages of PhutilProxyException.
Apr 9 2025, 18:16
mainframe98 added a revision to T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler: D25956: Replace usages of PhutilProxyException.
Apr 9 2025, 18:16
mainframe98 requested changes to D25955: Unhandled Exception: Add last call to error message.
Apr 9 2025, 17:42
aklapper renamed T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler from Replace calls to PhutilProxyException with PhutilErrorHandler to Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler.
Apr 9 2025, 10:34
aklapper removed a parent task for T15354: Exception when trying to create Pholio mock without name: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Apr 9 2025, 08:38
aklapper removed a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15354: Exception when trying to create Pholio mock without name.
Apr 9 2025, 08:38 · PHP 8 support
mturdus closed T15536: PHP 8.1 bug reports from mturdus, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Apr 9 2025, 07:17 · PHP 8 support
mturdus closed D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.
Apr 9 2025, 07:17 · PHP 8 support
mturdus closed T15536: PHP 8.1 bug reports from mturdus as Resolved by committing rP99834dd061aa: Fix PHP 8.1 "strlen(null)" exception on auth email message body when….
Apr 9 2025, 07:17 · Bug Reports, PHP 8 support
mturdus committed rP99834dd061aa: Fix PHP 8.1 "strlen(null)" exception on auth email message body when….
Apr 9 2025, 07:17

Apr 8 2025

aklapper requested review of D25955: Unhandled Exception: Add last call to error message.
Apr 8 2025, 18:24
aklapper added a revision to T15689: built in exception display is missing top line: D25955: Unhandled Exception: Add last call to error message.
Apr 8 2025, 18:24 · Wikimedia Hackathon 2025, Phorge Development Tools
aklapper edited the content of Next Up.
Apr 8 2025, 17:17
mainframe98 closed T16024: Tech Debt: Remove PHP mysql extension related code as Resolved by committing rP0f7e76ffe4f2: Remove support for PHP mysql extension.
Apr 8 2025, 16:54
mainframe98 closed D25946: Remove support for PHP mysql extension.
Apr 8 2025, 16:54
mainframe98 committed rP0f7e76ffe4f2: Remove support for PHP mysql extension.
Apr 8 2025, 16:54
aklapper requested review of D25954: PHPDoc: Correct marker in one class header.
Apr 8 2025, 16:07
aklapper requested review of D25953: PHPDoc: Replace invalid "key" and "value" types.
Apr 8 2025, 15:49
aklapper requested review of D25952: PHPDoc: Replace invalid "obj" with "object".
Apr 8 2025, 15:44
aklapper requested review of D25951: PHPDoc: Replace invalid "obj" with "object".
Apr 8 2025, 15:36
aklapper closed D25937: PHPDoc: Make some parameter types match type in signatures.
Apr 8 2025, 09:00
aklapper committed rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures.
Apr 8 2025, 09:00
aklapper closed D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Apr 8 2025, 09:00
aklapper committed rPbf39f021d626: PhabricatorCustomField: Fix a typo in PHPDoc.
Apr 8 2025, 09:00
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Apr 8 2025, 08:59 · PHP 8 support
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider as Resolved by committing rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59 · Auth, PHP 8 support
aklapper closed D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59
aklapper committed rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 08:59
avivey accepted D25937: PHPDoc: Make some parameter types match type in signatures.
Apr 8 2025, 06:16
avivey accepted D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Apr 8 2025, 06:15
avivey accepted D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Apr 8 2025, 06:15

Apr 7 2025

nib added a comment to Q173: Why do Milestones in parent project's Workboard seemingly randomly hide tasks?.

I patched this in our local repo with a change to /src/applications/project/engine/PhabricatorBoardLayoutEngine.php, in the layoutBoard() method. Around line 520, inside if ($proxy_hits) block, you have array_slice() taking the first element of $proxy_hits, which seems random.

Apr 7 2025, 23:54
aklapper closed T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256 as Resolved by committing rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper closed D25949: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper committed rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 21:46
aklapper accepted D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.

@mturdus: Could you land this one please, or would you like any help? Thanks!

Apr 7 2025, 21:23 · PHP 8 support
aklapper accepted D25946: Remove support for PHP mysql extension.
  • Apply this patch on a Fedora 42 system with PHP 8.4.5. php -m listed mysqli, mysqlnd, pdo_mysql etc.
  • Uninstall php-mysqlnd package. After reboot, php -m does not list those three modules anymore, and Phorge complains Required PHP extensions are not installed: mysqli as expected.
  • Install package again, Phorge works: "Unresolved setup issues" still lists the same MySQL related stuff as before; /config/clusters/databases shows entry as usual; successfully filed a Maniphest task.
  • Open /etc/php.ini and set mysqli.allow_local_infile = On. Restart Apache HTTPD. "Unresolved setup issues" in Phorge shows Unsafe "MySQL "local_infile" Setting Enabled as expected.
Apr 7 2025, 21:13
aklapper updated the test plan for D25950: Remove PHP APC support and APC references.
Apr 7 2025, 20:47
aklapper updated the test plan for D25949: Complete session digest migration from SHA1 to SHA256.
Apr 7 2025, 20:43
aklapper updated the summary of D25942: Herald Transcripts: Use μs instead of us for microseconds.
Apr 7 2025, 20:15
aklapper closed D25933: Remove several unused private functions.
Apr 7 2025, 20:14
aklapper committed rPd5ade92fd0d4: Remove several unused private functions.
Apr 7 2025, 20:14
aklapper edited the content of Next Up.
Apr 7 2025, 20:13
aklapper closed D25947: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 20:12
aklapper committed rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 20:12
Siz3r303 awarded F2660603: profile a Evil Spooky Haunted Tree token.
Apr 7 2025, 15:50
Siz3r303 added a comment to F3363410: NEiN iN NiNE - created by SIMON BOSTON.

NEiN iN NiNE - created by SIMON BOSTON

Apr 7 2025, 15:48
avivey accepted D25947: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 06:08

Apr 6 2025

mainframe98 accepted D25947: Remove setup check for safe_mode removed in PHP 5.4.

Setup phorge, saw nothing unusual in the setup issues.

Apr 6 2025, 10:50
avivey accepted D25949: Complete session digest migration from SHA1 to SHA256.

Sure, 7 years is probably long enough to migrate cookies.

Apr 6 2025, 06:53

Apr 5 2025

20after4 added a comment to Q175: Instant messaging not working, disconnected.

One other thing to check: The chat uses wss (websocket) connection to communicate with aphlict. It's possible that a firewall or reverse proxy may be blocking the connection? Not all proxies support websockets in their default configuration. See verifying server status in the documentation for some tips, especially the part about load balancers and ssl.

Apr 5 2025, 18:22
valerio.bozzolan added a task to D25948: Remove setup check for PHP 7.0: T15047: Officially raise minimum required PHP version to 7.2.
Apr 5 2025, 17:31