Page MenuHomePhorge
Create Task
Maniphest T16028

New project remarkup rule misses some project names
Open, Needs TriagePublic
Actions

Description

I have updated to the newest version and there is a regression from rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking / T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing

We have a project called JS-Draw-Lib (hashtag #js-draw-lib). This project name isn't parsed anymore in Remarkup. I have played with some hashtags:

#js-draw-lib - ⛔
#js_draw-lib - ✅
#js-draw_lib - ⛔
#js-draw - ⛔
#jsdraw - ✅
#jsd-raw - ✅

When I reverse rP9c73d62c446613551fe5cbee4d618b982a7f5f0a, every hashtag works. The problem seems to be two letters followed by a hyphen.

Revisions and Commits

rP Phorge
Needs ReviewD25959 Simplify project regex further

Related Objects

Event Timeline

bekay created this task.Fri, Apr 11, 14:37
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptFri, Apr 11, 14:37
bekay added a subscriber: pppery.Fri, Apr 11, 14:41

@pppery I don't know if you wanna step in, since the change was introduced by you.

pppery added a comment.Fri, Apr 11, 15:07

{#js-draw-lib} does work.

bekay added a comment.Fri, Apr 11, 15:12
In T16028#21601, @pppery wrote:

{#js-draw-lib} does work.

But it only renders a grey all purpose link, not using the project color and icon. That doesn't feel right.

pppery added a comment.Fri, Apr 11, 15:13

That's true of all projects - Remarkup here for instance.

That comment was mostly just a note to myself when investigating the code.

pppery added a revision: D25959: Simplify project regex further.Fri, Apr 11, 15:27
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0