Need to go over the relevant code for deciding if a commit has an approved Revision - I think it looks mostly on the commit message.

I updated this revision so the title will only show the monogram if the user is logged in

• The title will only show the monogram when the post is public

have an approved Revision", but this too can be tricked by a sufficiently competent user

Hackerman meme

Don't find a problem with this at all.

Ahem...

I created D25895. Reviews welcome.

clarify how to run the command (last change promise)

Aldo I may need extra help from @waldyrious asdlol

aaand I go to bed :3

OK my friend, I've worked a lot to make it shorter... but still more dense of useful info, reducing jokes at minimum.

This is much better. A few spelling errors remain, plus two suggestions to make sentences read a little less awkward.

Dear friend @mainframe98 - I suggest to click the button Hide "Done" inlines in the top-right corner to easily do another reading

See also https://secure.phabricator.com/T1751 and rARC3116d3656ad017783e75df7e863368053d753e7f - looks like we had arc backout at some point for this, but it's no longer there.

Yeah, that would work too.

You mean a shorthand for git revert + arc diff? Sounds reasonable

Yes, I mean the way it works in Meta's Phabricator: it runs the equivalent of git revert + git push behind the scenes.

Potentially related to Herald. Adding Herald to raise more attention.

try now

Tried. I Shall Not Pass :O

@valerio.bozzolan go ahead and give it a try? I think you have access to create rules.

I'd be very much in favor and I'd be happy to contribute changes for this. I've added type hints in my local fork to assist in development. Especially for core utility functions like idx and id which otherwise completely hide type information.

The code to select which tests to run by default is in ArcanistWorkflow::selectPathsForWorkflow().

There is no Edit Task option in the Add Action... dropdown. What makes you think so?

I can't see an Edit Task option in the dropdown. What actually enables this?

@avivey what do you think about? Maybe we can test with some powerful clicks

git rebase master; ./bin/celerity map; shows no output

Thanks for the quick review. I'll refrain from touching JS and CSS files.

I confirm that ./bin/celerity map does nothing after this change

Oh boy. D25893 first, I guess.

This makes me and probably other people mad lol

Aaand last 48 lines checked. Differential is crashing in my laptop lol

(Review 3 of ?)

P.S. maybe nice to introduce in AphrontView a method like getUserRequired() or something similar to implement exactly this logic - so we avoid that scattered logic everywhere

(epic review part 1 of ?)

I wonder if shouldAllowPublic() was just forgotten or if the idea behind was to exclude web crawlers (as querying those lists en-masse could be expensive).

Most of these can be done by adding the following to controller files related to query, list, and view files:

and reviews love you too! (lol)

Do the easier and more obvious thing that Valerio proposed

Argh, right... That's why I love reviews! :D Thus also check for null.

In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

Hopefully the latest change will work for you. Now it checks existing git branches matching "T12345*" and if any exist, it will git checkout the first one, else it will create it from the task name.
So that should allow you to change the task title, and to use arc work T12345 as many times as you want without error.

• Fix indents, adds emoji support, improve REGEX
• Detect existing branch for task

• Handles existing branches
• Fixes indents, adds emoji support, improves REGEX

Fixes error when invoking arc work 2nd time on task id