With D25878 applied, dialog for folks who can use Herald:
Feed All Stories
Feb 15 2025
Feb 15 2025
mainframe98 requested review of D25881: Fix packages base uri and introduce a console for that base uri.
aklapper requested review of D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
aklapper updated the summary of D25879: Fix editing Conpherence rooms on mobile.
aklapper requested review of D25879: Fix editing Conpherence rooms on mobile.
mainframe98 awarded D25878: Project archival dialog: Mention affected Herald rule conditions a Like token.
aklapper added a comment to T15996: Notify about affected Herald rule conditions when archiving a project tag.
aklapper requested review of D25878: Project archival dialog: Mention affected Herald rule conditions.
avivey added a comment to D25877: Mention on landing page that Phorge is a community fork of Phabricator.
I've deployed it (https://www.phorge.it/)
Cigaryno updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
Cigaryno edited reviewers for D25877: Mention on landing page that Phorge is a community fork of Phabricator, added: Blessed Committers; removed: O1: Blessed Committers.
taavi moved T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) from Backlog to Deprecation Notices on the PHP 8 support board.
Cigaryno requested review of D25877: Mention on landing page that Phorge is a community fork of Phabricator.
Feb 14 2025
Feb 14 2025
Cigaryno added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
aklapper added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
Cigaryno added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
valerio.bozzolan accepted D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
You're fast. lol I approve because life is too short.
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
null as fast as possible
valerio.bozzolan awarded D25874: Update installation guide to point to GitHub mirrors a Manufacturing Defect? token.
I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Errm yes, now for real
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Short-circuit null check, as rightfully proposed by Valerio
valerio.bozzolan added a comment to D25873: Fix overlapping elements in Phame for >1791px width.
With this I have a regression in /w/. Do you have too?
aklapper requested review of D25876: People Profile Menu: Move "Badges" item lower in panel list.
aklapper added a comment to D25874: Update installation guide to point to GitHub mirrors.
No, because people do not read. The "read-only mirror" Wikimedia and GNOME code repos on GitHub regularly receive pull requests because people do not read anything.
Cigaryno added a comment to D25874: Update installation guide to point to GitHub mirrors.
aklapper added inline comments to D25872: Implements arc work for git workflow.
aklapper added a comment to D25874: Update installation guide to point to GitHub mirrors.
I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?
valerio.bozzolan added a comment to D25874: Update installation guide to point to GitHub mirrors.
Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.
Cigaryno updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Thanks. I'm curious if there's anything up that should not call this with null. Also I'm curious to test with a couple of date filters and custom date fields.
Feb 13 2025
Feb 13 2025
slip accepted D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
LGTM
slip added a comment to D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
I found this, which suggests that this shouldn't be used for headers. https://secure.phabricator.com/D21862
LGTM!
aklapper renamed T15994: PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time from PHP 8.1 ctype_digit/preg_split exceptions in Phrequent for no date/time to PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time.
aklapper renamed T15994: PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time from PHP 8.1 ctype_digit/preg_+split exceptions in Phrequent for no date/time to PHP 8.1 ctype_digit/preg_split exceptions in Phrequent for no date/time.
Cigaryno requested review of D25874: Update installation guide to point to GitHub mirrors.
aklapper updated the summary of D25873: Fix overlapping elements in Phame for >1791px width.
aklapper requested review of D25873: Fix overlapping elements in Phame for >1791px width.
aklapper updated the task description for T15985: Fix UX regression in Phame.
valerio.bozzolan accepted D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
Thanks! I'm sorry that the execute method has undocumented return.
valerio.bozzolan edited the content of Next Up.
valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.
Thanks! I share a comment on the fly, maybe more comment soon after a test :)
nib requested review of D25872: Implements arc work for git workflow.
Feb 12 2025
Feb 12 2025
taavi closed T15988: Allow filtering tokens given by list of token as Resolved by committing rP90d26167aad5: Allow filtering tokens given by type of token.
Feb 11 2025
Feb 11 2025
Cigaryno added a comment to T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider.
I think you are right for unnecessary catetorization and sending notifications.
valerio.bozzolan awarded D25870: Skip writing symbol cache to non-writable directories a Yellow Medal token.
xtex added a comment to D25870: Skip writing symbol cache to non-writable directories.
Running arc liberate before installing worked well for me. Thank you again!
xtex updated the test plan for D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
valerio.bozzolan requested changes to D25870: Skip writing symbol cache to non-writable directories.
OK super! <3
xtex added a comment to D25870: Skip writing symbol cache to non-writable directories.
( I was running arc lint in phorge.git and got the same error.
Thank u for your recommendation of running arc liberate. Will add that to packaging script :)
valerio.bozzolan updated the test plan for D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
Thaanks!
xtex updated the diff for D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
apply suggestions
valerio.bozzolan added a comment to D25870: Skip writing symbol cache to non-writable directories.
(1. Are you an heroic package manager? <3 nice to know!)
valerio.bozzolan requested changes to D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
valerio.bozzolan added inline comments to D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
I see the PHP approach is interestingly in line with stuff like line 11. wow lol. Thanks
xtex requested review of D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
xtex requested review of D25870: Skip writing symbol cache to non-writable directories.
xtex updated the diff for D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
none
xtex added a project to D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser: PHP 8 support.
xtex added a comment to D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
One test is failing for PHP 8 (:
Lints are skipped because the same problem make linting failed for me.
xtex requested review of D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
Feb 10 2025
Feb 10 2025
aklapper updated the summary of D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.