Page MenuHomePhorge

Notify about affected Herald rule conditions when archiving a project tag
Open, Needs TriagePublic

Description

In our downstream Phorge instance, a project maintainer archived a project tag.
That project tag was the only condition in an active Herald rule.
Ideally, someone would notice and disable the Herald rule.
Phorge could inform the acting user about affected Herald rules to allow checking (or even updating or archiving) them.

Upstreaming from https://phabricator.wikimedia.org/T386551

Event Timeline

With D25878 applied, dialog for folks who can use Herald:

Screenshot From 2025-02-15 13-22-08.png (748×795 px, 113 KB)

With D25878 applied, dialog for folks who cannot use Herald:

Screenshot From 2025-02-15 13-23-50.png (819×864 px, 119 KB)

A related task (maybe not a sub-task?) is probably that the advanced search of herald ( https://we.phorge.it/herald/ ) does not allow to find these by involved project(s).

So, we could expose the HeraldRuleQuery#withAffectedObjectPHIDs() to frontend.

So, in the future the proposed confirmation message could just report "there are NN Herald rules involved", plus a link to that advanced search, so, without manually building a massive list of H1, H2, H3, H4 etc.

So another task welcome I think (again, maybe not a sub-task? but still related)