Cigaryno moved this task from Backlog to PHP 8.1 on the PHP 8 support board.

Uhm, I realize this might not be a good idea because some might still be accessed by reflection.

Superseded by https://we.phorge.it/rPa4948ec800e9e385ecb519d86b40c5f13719fb53

I do not recommend, because https://phabricator.wikimedia.org/T293139 - Phorge displays whatever it gets, especially if the video got deleted in the meantime. Same behavior for Youtube.

Whopsie whopsie... you are now in the family of trusted contributors \o/

@valerio.bozzolan looks to not change behavior in mercurial at all :) I'm not in Trusted Contributors so I can't accept.

Do you think that this is wontfix? I think yes after https://we.phorge.it/T15281#10042

P.S. - finally a Mercurial user! Please try D25823 in Mercurial :D if it works for you, feel free to accept, or share any feedback

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

In D25865#23283, @valerio.bozzolan wrote:

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Rebase

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Thaaanks taavi! Known non-issue: somebody may wonder why in Maniphest the "Queries" are listed before other things. I may answer that in Phame the "Queries" are listed after other things. So this is consistent with Phame /phame/post/ page. lol

In D25863#23243, @valerio.bozzolan wrote:

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

Add searches to navigation menu

Yeah that makes sense, thanks!

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

OK probably just this is missing

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

Welcome PHP 8.4

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "🦊", forever - even if not available. So maybe the implementation is a bit simpler and efficient 👍 lol)

• rebase again

Double slam-sgtm

./bin/celerity/map

Remove newNoMenuItemsView() instead

https://secure.phabricator.com/T13105 is the relevant historical meta-task, I didn't find a matching one here.

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

Makes sense looking at

I find the current iteration too difficult to read, although that may be partially caused by the mutual language barrier.

It works on my computer. Thaaaanks \o/

A comment in two parts:
First and most relevant to this task: It certainly would be nice to get some of this into documentation! It took me quite awhile to figure this out when doing my own extension development.

Took some fiddling with VS2022 to find exactly what I needed to install, but worked like a charm afterwards.