The packages base uri is /packages/.
Previously, the base uri pointed to the packages search engine.
Because that prevents navigating to the publishers search engine
and the versions search engine and because the new base uri is a 404,
add a console, similar to Almanac or Nuance to link to these
endpoints. This makes the forms for publishers and versions
accessible without manually navigating there.
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Commits
- rP955ec7776064: Fix packages base uri and introduce a console for that base uri
- Clicked on the Packages application in Applications and saw a Console
- Clicked on the options in the console and saw all search engines
- Clicked on the packages crumb and got sent to the console
- Created a package and clicked on Edit Package and didn't see a 404
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks!
Beforehand,
- Created a publisher at http://phorge.localhost/packages/publisher/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/publisher/edit/1/ is a 404.
- Created a package at http://phorge.localhost/packages/package/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/package/edit/1/ is a 404.
- Created a version at http://phorge.localhost/packages/version/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/version/edit/1/ is a 404.
- Going to http://phorge.localhost/packages/ is a 404, had to go to http://phorge.localhost/packages/package/ instead.
After applying this patch locally, all these four URIs work as expected.
Comment Actions
@mainframe98's patch for fixing Packages makes me think about the current contribution policy for prototype applications. It currently states:
With rare exceptions, we do not accept patches for prototype applications for the same reasons that we don't accept feature requests or bug reports.
Maybe this is one obsolete Phabricator-specific contributing policy?
Comment Actions
@Cigaryno: Please provide references when you quote something from somewhere so others don't have to guess where to find things. Thanks!
Comment Actions
Sorry for forgetting to provide a reference, but here I have one: Contributing Code, section No Prototype Changes.
Comment Actions
Me too. Maybe this section should be removed?
There is one more Phabricator-era part in Contributing Code on section Writing and Submitting Patches:
When executed in these directories, arc should automatically talk to the upstream install. You can add #blessed_reviewers as a reviewer.
No one put to though replacing that with adding O1: Blessed Committers as a reviewer.
Comment Actions
Feel free to submit a patch, it has my vote.
There is one more Phabricator-era part in Contributing Code on section Writing and Submitting Patches:
When executed in these directories, arc should automatically talk to the upstream install. You can add #blessed_reviewers as a reviewer.
No one put to though replacing that with adding O1: Blessed Committers as a reviewer.
I'm pretty sure that beyond a few Phabricator -> Phorge search-and-replaces the rest of the documentation was left untouched.