Ah, I'm the author of this. Yes, let's abyss into decline. Thanks Andre

As a development software site, I don't think we need to support Google OAuth.

Yeah no problem.

It was my fault, I did not pay attention to the fact that in the right panel "list of added files" the files I add are marked with restricted access, with notification 'This file is referenced by this object, but not formally attached to it. Users who can see the object may not be able to see the file.' Can i adjust show my attached files all user by default .Thanks

Please answer my questions via text. The two images can only be seen by you.

{F2878762}
{F2878763}

Create a task in Phorge and attach a file (e.g., a screenshot or document).

Thanks revi. Dear @dereckson probably your nice installation is still on the legacy Phabricator? (or a Phorge before 2023 Week 17, accordingly to wiki search results)

Cannot repro on current stable (rPd3c0a7edc3fc and rARC05abd055019c as of today). Tested on local installation.

Mark as "oh noooo boring comments from bozz" :3

Uh there's also phid_group_by_type($type) for extra readability and less code. Also maybe more modular for future things.

All I did was look at the homepage and observe I saw "e. p. p" in the recent activity (and thus the translations somehow worked). That was more of a paranoia check for unintended side effects on other uses of the function, to make sure I didn't break date translation completely. You're welcome to test other UI things to make sure they're not affected if you wish.

Hi @jmeador would you appreciate an help to update this?

Double-slam-accept

Since init_metrics() is supposed to be never called, maybe we can continue to do not define it 🤔

Any additional tips for the test plan? Maybe hacker @20after4

Thanks! If you remember which parts of the interface you've already tested, feel free to mention in the Test Plan, so I can maybe help in testing other parts

Fix lint

In D25618#20068, @pppery wrote:

I think the behavior of not setting the timezone is probably correct, actually. GetFormattedDateFromParts below already constructs a date object again with the timezone set. So I think the timezone offset is being applied twice here.

(From reading the code, I don't have a means to test this)

And the date is read from the database so I don't think it can be malformed.

Interestingly, PhutilClassMapQuery supports a ->setFilterMethod('something'), but it seems over-complicated to me, since it's supposed to call $query->something() as filter using mfilter($query, 'something'). But, to do that in this way, we may want to add something in the parent class PhabricatorApplicationTransactionQuery - but this seems not needed at the moment and, moreover, I don't like its backend mfilter()...

Suggested meme for closing: "yesyes"