Page MenuHomePhorge
Feed All Stories

Nov 13 2024

valerio.bozzolan updated the summary of D25823: arc browse: add support to Subversion repos.
Nov 13 2024, 15:08
valerio.bozzolan updated the test plan for D25823: arc browse: add support to Subversion repos.
Nov 13 2024, 14:34
valerio.bozzolan updated the diff for D25823: arc browse: add support to Subversion repos.

found a corner case, fixed

Nov 13 2024, 14:27
valerio.bozzolan updated the test plan for D25823: arc browse: add support to Subversion repos.
Nov 13 2024, 14:26

Nov 12 2024

valerio.bozzolan added a comment to T15955: Comment anchor doesn't work properly due to loading of old comments.

I think that, after the hidden comment is loaded in its bulk, "some more comments" are loaded as context for the hidden comment 🤔 So I guess that extra loading is probably a feature and not a bug.

Nov 12 2024, 21:29 · Comments, Maniphest
valerio.bozzolan awarded T15955: Comment anchor doesn't work properly due to loading of old comments a Grey Medal token.
Nov 12 2024, 21:26 · Comments, Maniphest
Tgr created T15955: Comment anchor doesn't work properly due to loading of old comments.
Nov 12 2024, 19:50 · Comments, Maniphest
valerio.bozzolan accepted D25777: Make maniphest.gettasktransactions include metadata and title.

Wikimedia Foundation has this in production since years. I think it doesn't hurt.

Nov 12 2024, 15:11
valerio.bozzolan added a comment to D25823: arc browse: add support to Subversion repos.

Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?

Nov 12 2024, 15:08
valerio.bozzolan added inline comments to D25825: Validate some user provided calendar query range dates.
Nov 12 2024, 09:07
pppery added a project to T15931: All method search results in Diviner are 404 URIs: Diviner.
Nov 12 2024, 02:27 · Diviner
pppery added a project to T15932: All file search results in Diviner are 404 URIs: Diviner.
Nov 12 2024, 02:26 · Diviner
pppery added a project to T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime(): Calendar.
Nov 12 2024, 02:26 · Calendar
pppery added a project to T15903: Logged exceptions/errors should ignore user's language setting and be always in English: Localization.
Nov 12 2024, 02:25 · Localization

Nov 11 2024

NameNoQuality awarded rP7157dd96b34a: T15006: Update .arcconfig to point to we.phorge.it a Love token.
Nov 11 2024, 10:25

Nov 5 2024

valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Wontfix.
Nov 5 2024, 14:25 · PHP 8 support
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Wontfix.
Nov 5 2024, 14:25 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, a subtask of T15255: Fix Diviner generation in PHP 8, as Wontfix.
Nov 5 2024, 14:25 · User-valerio.bozzolan, Diviner, PHP 8 support
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies as Wontfix.

Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.

Nov 5 2024, 14:25 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, a subtask of T15198: PHP 8.2 deprecations fix strategies, as Wontfix.
Nov 5 2024, 14:25 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, a subtask of T15222: Fix arc unit--everything in PHP 8.2, as Wontfix.
Nov 5 2024, 14:25 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to D25772: Projects: improve quality of destroy workflow.

Any other test plan suggested? Current ones: delete simple milestone, delete project with milestone, delete a project with sub-projects, delete a sub-project, ecc.

Nov 5 2024, 09:00

Nov 2 2024

revi added a comment to T15952: IPv6 for we.phorge.it.

One weird observation:

Nov 2 2024, 23:35 · Phorge.it Systems
valerio.bozzolan created T15954: phabricator_feed.feed_storydata.transactionPHIDs: reduce storage space.
Nov 2 2024, 14:14 · Phorge
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

helping reviewers, adding comment on future export possibility

Nov 2 2024, 13:53
valerio.bozzolan updated the test plan for D25363: Calendar Import: calendar uploader is not anymore an alien.
Nov 2 2024, 13:40
valerio.bozzolan updated the name of F2599178: Calendar widget finally showing something.png from "image.png" to "Calendar widget finally showing something.png".
Nov 2 2024, 13:39
valerio.bozzolan moved T15941: Calendar Import: support Available/Busy from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Nov 2 2024, 13:33 · User-valerio.bozzolan, Calendar
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

fix lint, happy review

Nov 2 2024, 13:31
valerio.bozzolan updated the summary of D25363: Calendar Import: calendar uploader is not anymore an alien.
Nov 2 2024, 13:30
valerio.bozzolan changed the visibility for F2599125: Example_for_patch_D25363.ics.
Nov 2 2024, 13:09
Rexogamer awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Nov 2 2024, 12:58 · Comments
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

it works!

Nov 2 2024, 12:13
valerio.bozzolan added a revision to T15941: Calendar Import: support Available/Busy: D25363: Calendar Import: calendar uploader is not anymore an alien.
Nov 2 2024, 12:13 · User-valerio.bozzolan, Calendar
valerio.bozzolan updated the summary of D25363: Calendar Import: calendar uploader is not anymore an alien.
Nov 2 2024, 12:13

Nov 1 2024

valerio.bozzolan moved T15941: Calendar Import: support Available/Busy from PingDeath 🌚 to Code Sprint Candidate on the User-valerio.bozzolan board.
Nov 1 2024, 14:11 · User-valerio.bozzolan, Calendar
valerio.bozzolan added a project to T15941: Calendar Import: support Available/Busy: User-valerio.bozzolan.
Nov 1 2024, 14:11 · User-valerio.bozzolan, Calendar
aklapper edited the content of Next Up.
Nov 1 2024, 08:00
aklapper closed T15940: Update copy of external mimemailparser library as Resolved by committing rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4.
Nov 1 2024, 07:59
aklapper committed rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4.
Update mimemailparser from May 2011 version to 8.0.4
Nov 1 2024, 07:59
aklapper closed D25829: Update mimemailparser from May 2011 version to 8.0.4.
Nov 1 2024, 07:59
aklapper added a comment to D25829: Update mimemailparser from May 2011 version to 8.0.4.

This very patch got deployed on our rather active downstream instance 10 days ago. I have not heard complaints and I've seen tasks and task comments (replies) created via email, so I'm now pretty confident that it does what it should. Thus I'm going to merge it to reduce technical debt a bit more in Phorge.

Nov 1 2024, 07:59

Oct 31 2024

dereckson triaged T15953: `git format-patch` format not supported on differential web create form as Low priority.
Oct 31 2024, 18:53 · Differential, Phorge
dereckson created T15953: `git format-patch` format not supported on differential web create form.
Oct 31 2024, 18:24 · Differential, Phorge

Oct 30 2024

valerio.bozzolan updated the diff for D25823: arc browse: add support to Subversion repos.

add extra escape

Oct 30 2024, 16:13
valerio.bozzolan updated the diff for D25823: arc browse: add support to Subversion repos.

OMG IT WORKS

Oct 30 2024, 15:57
nemoralis awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Oct 30 2024, 07:21 · Comments

Oct 29 2024

aklapper added a revision to T15950: Update copy of external xhprof library: D25836: Update xhprof to latest upstream version 2.3.10.
Oct 29 2024, 14:42
aklapper requested review of D25836: Update xhprof to latest upstream version 2.3.10.
Oct 29 2024, 14:42
aklapper updated the task description for T15950: Update copy of external xhprof library.
Oct 29 2024, 14:31
valerio.bozzolan accepted D25835: Strip surrounding whitespace from project and task titles.

Thanks. Seems good to me since trim($new) does not receive null so cannot create PHP 8.1 problems, since we already execute strlen($new) and mb_strlen($new) and that was not reporting errors in your updated install

Oct 29 2024, 12:11
aklapper added a comment to D25743: Fix stripping headers from proxy requests to other cluster nodes.

@avivey: Would you like to give this another review, once you find some spare time? TIA!

Oct 29 2024, 11:11
aklapper updated the test plan for D25835: Strip surrounding whitespace from project and task titles.
Oct 29 2024, 10:40
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

Restore an empty line

Oct 29 2024, 10:38
aklapper requested review of D25835: Strip surrounding whitespace from project and task titles.
Oct 29 2024, 10:34
valerio.bozzolan added a comment to Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).

I see the API maniphest.createtask is frozen, maybe this can also create tasks: https://we.phorge.it/conduit/method/maniphest.edit/

Oct 29 2024, 07:58
avivey added Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).
Oct 29 2024, 07:48

Oct 28 2024

arp asked Q158: Is there a way to create a task in Maniphest via a webhook?.
Oct 28 2024, 23:27 · Maniphest
s.quinn closed Q153: php-fpm memory leak as resolved.
Oct 28 2024, 09:23
mainframe98 closed D25834: DarkConsole: Fix "strlen(null)" but for the "tab" query parameter.
Oct 28 2024, 08:26
mainframe98 committed rPddf26e89c873: DarkConsole: Fix "strlen(null)" but for the "tab" query parameter.
DarkConsole: Fix "strlen(null)" but for the "tab" query parameter
Oct 28 2024, 08:26

Oct 27 2024

aklapper accepted D25834: DarkConsole: Fix "strlen(null)" but for the "tab" query parameter.
Oct 27 2024, 22:12
mainframe98 requested review of D25834: DarkConsole: Fix "strlen(null)" but for the "tab" query parameter.
Oct 27 2024, 18:49
mainframe98 closed D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 14:12
mainframe98 committed rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given.
APC: Set ttl to 0 when ttl is not given
Oct 27 2024, 14:12
avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 14:06
mainframe98 added inline comments to D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 14:03
mainframe98 updated the diff for D25833: APC: Set ttl to 0 when ttl is not given.
  • APC: Change the setKeys $ttl parameter default to 0
Oct 27 2024, 14:03
avivey added inline comments to D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 13:13
avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 13:13
mainframe98 requested review of D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 13:00

Oct 26 2024

valerio.bozzolan awarded T15952: IPv6 for we.phorge.it a Love token.
Oct 26 2024, 15:23 · Phorge.it Systems
taavi created T15952: IPv6 for we.phorge.it.
Oct 26 2024, 07:10 · Phorge.it Systems

Oct 25 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Oct 25 2024, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Oct 24 2024

aklapper closed D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Oct 24 2024, 15:33
aklapper committed rPd643ca4c4c53: ManiphestReportController: Separate legacy and synthetic data handling.
ManiphestReportController: Separate legacy and synthetic data handling
Oct 24 2024, 15:33
aklapper closed D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 15:19
aklapper committed rP5f4587bb88dd: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Oct 24 2024, 15:19
aklapper committed rARC29ca3df1122b: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Oct 24 2024, 15:16
aklapper closed D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 15:16
s.quinn added a comment to Q153: php-fpm memory leak.

Think I may have found what is causing this. We had a few repositories that auto download/sync from github. The user's key who connects to github was missing so the downloads were giving errors. I think this triggers a memory leak for the php process. Now that I've fixed the key issue no errors now appear and phorge looks to be happier, i.e. memory usage looks minimal all the time (i.e. php-fpm processes using ~100MBytes).
I'm going to keep monitoring for a few weeks.
Here's an example from the log:

Oct 24 2024, 13:39
avivey accepted D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 09:56
avivey accepted D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 09:55

Oct 23 2024

aklapper closed T15949: Herald comment attributed to the wrong user in email notifications as Invalid.
Oct 23 2024, 14:09 · Herald, Maniphest
aklapper requested review of D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 23 2024, 10:14
aklapper requested review of D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 23 2024, 09:57
aklapper closed D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 23 2024, 09:10
aklapper committed rPf3d49f740737: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Oct 23 2024, 09:10
aklapper closed D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 23 2024, 09:09
aklapper committed rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Oct 23 2024, 09:09
aklapper closed D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 23 2024, 09:08
aklapper committed rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Oct 23 2024, 09:08
avivey added a comment to D25823: arc browse: add support to Subversion repos.

(The Arguments have a supports feature for these cases - like https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 . Not sure what it actually does, but 🤷🏻‍♂️)

Oct 23 2024, 07:22
keithzg added a comment to D25823: arc browse: add support to Subversion repos.

What if the user used the svn checkout svn+ssh://phab@phorge.example.com/source/myrepo/trunk myRepoOnlyTrunk form - are we still able to find the right target when arc browse lol.txt? Is it a common use-case?

Oct 23 2024, 00:43

Oct 22 2024

valerio.bozzolan planned changes to D25823: arc browse: add support to Subversion repos.

I will add a warning about --branch and better management

Oct 22 2024, 19:56
aklapper added a comment to D25829: Update mimemailparser from May 2011 version to 8.0.4.

For testing, I deployed the latest revision of this proposed patch in our downstream instance and created a task via incoming plain text mail with attachments - seems to still work as expected so no obvious breakage (yet): https://phabricator.wikimedia.org/T377859

Oct 22 2024, 15:16
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

Fix typo

Oct 22 2024, 11:51
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

mimemailparser: Check that PHP mailparse extension is installed

Oct 22 2024, 11:50
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Oct 22 2024, 08:35 · PHP 8 support
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter as Resolved by committing rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 22 2024, 08:35 · PHP 8 support