Page MenuHomePhorge

APC: Set ttl to 0 when ttl is not given
ClosedPublic

Authored by mainframe98 on Oct 27 2024, 12:59.
Tags
None
Referenced Files
F3852863: D25833.1746139945.diff
Wed, Apr 30, 22:52
F3762298: D25833.1745833121.diff
Sun, Apr 27, 09:38
F3747404: D25833.1745772427.diff
Sat, Apr 26, 16:47
F3734254: D25833.1745759303.diff
Sat, Apr 26, 13:08
F3733957: D25833.1745753096.diff
Sat, Apr 26, 11:24
F3733496: D25833.1745747886.diff
Sat, Apr 26, 09:58
F3733153: D25833.1745745181.diff
Sat, Apr 26, 09:13
F3712059: D25833.1745669313.diff
Fri, Apr 25, 12:08

Details

Summary

Passing null as a value for parameter $ttl is deprecated.
Omitting the parameter is considered to be equivalent to 0.

Bug: T15064

Test Plan
  • Looked in the deprecation log and did not see a deprecation message from apc.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 27 2024, 13:13
src/infrastructure/cache/PhutilAPCKeyValueCache.php
41

let's also default to 0 here?

  • APC: Change the setKeys $ttl parameter default to 0
mainframe98 added inline comments.
src/infrastructure/cache/PhutilAPCKeyValueCache.php
41

I was concerned that that might cause a deprecation warning about non-matching signatures, so I kept this change small.

This revision was automatically updated to reflect the committed changes.
mainframe98 marked an inline comment as done.