Differential D25832 Authored by aklapper on Oct 23 2024, 10:14.
Tags None Referenced Files None Subscribers
Details
Summary Followup to rPdb61eb20 and rPf3d49f74. This patch should cover all remaining issues now that PHPStan covers it (instead of the previous trial-and-error approach). Implicitly nullable parameter declarations are deprecated in PHP 8.4: The proposed syntax was introduced in PHP 7.1 and Phorge requires PHP 7.2 now. Test Plan Run static code analysis.
Diff Detail
Event TimelineHerald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 23 2024, 10:142024-10-23 10:14:02 (UTC+0) Harbormaster completed remote builds in B1611: Diff 2506.Oct 23 2024, 10:142024-10-23 10:14:05 (UTC+0) This revision is now accepted and ready to land.Oct 24 2024, 09:562024-10-24 09:56:33 (UTC+0) Closed by commit rP5f4587bb88dd: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain WhyOct 24 2024, 15:192024-10-24 15:19:48 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 2508 Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0 |