Page MenuHomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic

Authored by aklapper on Oct 23 2024, 09:57.
Tags
None
Referenced Files
F3801199: D25831.1745942463.diff
Mon, Apr 28, 16:01
F3764397: D25831.1745842927.diff
Sun, Apr 27, 12:22
F3764339: D25831.1745842592.diff
Sun, Apr 27, 12:16
F3731712: D25831.1745742061.diff
Sat, Apr 26, 08:21
F3731393: D25831.1745740957.diff
Sat, Apr 26, 08:02
F3587159: D25831.1745141264.diff
Sat, Apr 19, 09:27
F3576781: D25831.1745070240.diff
Fri, Apr 18, 13:44
F3494066: D25831.1744786893.diff
Tue, Apr 15, 07:01

Details

Summary

Followup to rARC99e57a70. This patch should cover all remaining issues now that PHPStan covers it (instead of the previous trial-and-error approach).

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1 and Phorge requires PHP 7.2 now.

Test Plan

Run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable