Page MenuHomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic

Authored by aklapper on Oct 23 2024, 09:57.
Tags
None
Referenced Files
F3317944: D25831.1743269951.diff
Fri, Mar 28, 17:39
F3308526: D25831.1743168673.diff
Thu, Mar 27, 13:31
F3308522: D25831.1743168433.diff
Thu, Mar 27, 13:27
F3304797: D25831.1743105391.diff
Wed, Mar 26, 19:56
F3302456: D25831.1743067176.diff
Wed, Mar 26, 09:19
F3297269: D25831.1742983487.diff
Tue, Mar 25, 10:04
F3294019: D25831.1742927565.diff
Mon, Mar 24, 18:32
F3288450: D25831.1742828454.diff
Sun, Mar 23, 15:00

Details

Summary

Followup to rARC99e57a70. This patch should cover all remaining issues now that PHPStan covers it (instead of the previous trial-and-error approach).

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1 and Phorge requires PHP 7.2 now.

Test Plan

Run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable