Page MenuHomePhorge
Create Task
Maniphest T15949

Herald comment attributed to the wrong user in email notifications
Closed, InvalidPublic
Actions

Description

Wikimedia T376897#10226175 and T376897#10226178 gets collapsed into a single, confusing notification email:

Screenshot Capture - 2024-10-14 - 21-07-03.png (803×2 px, 399 KB)
Screenshot Capture - 2024-10-14 - 21-07-36.png (871×2 px, 300 KB)
WebEmail

I would expect the email sender to be the comment author.

Event Timeline

Tgr created this task.Mon, Oct 14, 19:09
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptMon, Oct 14, 19:09
Tgr updated the task description. (Show Details)Mon, Oct 14, 19:10
valerio.bozzolan subscribed.Tue, Oct 15, 06:52

Uh! Out of curiosity, what does the notification look like in your web notifications?

aklapper subscribed.Mon, Oct 21, 16:50

The email body says Herald added a comment.
The email subject line header says [Changed Project Column] (not [Commented On]).
So I wouldn't say it is incorrectly attributed.
AFAIK there are no Herald rules which trigger a separate email notification on its own (but I agree that the described behavior also has confused me in the past) as Herald rules are always triggered by some other previous action.

In my opinion this is not something to change. If someone wanted to look into this, then getTitle() in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransaction.php could likely check if ($this->getMetadataValue('herald:transcriptID')), as a condition to start with

aklapper closed this task as Invalid.Wed, Oct 23, 14:09
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0