Wikimedia T376897#10226175 and T376897#10226178 gets collapsed into a single, confusing notification email:
Web | |
I would expect the email sender to be the comment author.
Tgr | |
Oct 14 2024, 19:09 |
F2559027: Screenshot Capture - 2024-10-14 - 21-07-36.png | |
Oct 14 2024, 19:09 |
F2559025: Screenshot Capture - 2024-10-14 - 21-07-03.png | |
Oct 14 2024, 19:09 |
Wikimedia T376897#10226175 and T376897#10226178 gets collapsed into a single, confusing notification email:
Web | |
I would expect the email sender to be the comment author.
Uh! Out of curiosity, what does the notification look like in your web notifications?
The email body says Herald added a comment.
The email subject line header says [Changed Project Column] (not [Commented On]).
So I wouldn't say it is incorrectly attributed.
AFAIK there are no Herald rules which trigger a separate email notification on its own (but I agree that the described behavior also has confused me in the past) as Herald rules are always triggered by some other previous action.
In my opinion this is not something to change. If someone wanted to look into this, then getTitle() in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransaction.php could likely check if ($this->getMetadataValue('herald:transcriptID')), as a condition to start with