(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl

This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.

Leave out special case src/workflow/ArcanistWorkflow.php for now

I'd prefer not to increase the diff to upstream (as a side effect of this very task) but instead to pull a more recent upstream version - see T15940.

fix typos in documentation

add a bit of documentation - just because we can

Right, should have probably also covered that line in D25186 which is more or less the same...

In D25535#15480, @avivey wrote:

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?

Ty. I’m still confused how “limit” is required but doesn’t throw an error when not specified. Can address that later if needed.

Thanks. Premising that $body can be null and that's a feature

Not before time!

In D25731#21672, @aklapper wrote:

I don't favor implementing non-obvious behavior ("why does it sometimes do this but not always"). :)

In D25731#21664, @valerio.bozzolan wrote:

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

An additional check to make milestone owners happy might be: look to see if the board shows at least one task. If not, proceed.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Thanks aklapper. Seems good from our side @speck?

It seems to me that in general more information should be added to the main page: screenshots, main features, as is usually done in other large projects.

Supporting PHP 8.4 (currently planned for 2024-11-21) will require PHP syntax introduced in PHP 7.1 per T15935.

Note that above two patches only allow passing ./bin/storage upgrade but not to run Phorge. That would be a followup once these initial patches got in.