Page MenuHomePhorge
Feed All Stories

Sep 4 2024

valerio.bozzolan added a parent task for T15803: Calendar Import: add field "Default Invitees": T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · User-valerio.bozzolan, Calendar
valerio.bozzolan added subtasks for T15939: Calendar Import Invitees 2.0: T15938: Understand if Diffusion public identities could be used to expand Calendar invitees, T15803: Calendar Import: add field "Default Invitees", T15564: Allow yourself to be Invited in Imported Events.
Sep 4 2024, 17:59 · Calendar
valerio.bozzolan added a parent task for T15938: Understand if Diffusion public identities could be used to expand Calendar invitees: T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · Discussion Needed, Calendar
valerio.bozzolan created T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · Calendar
valerio.bozzolan updated the task description for T15938: Understand if Diffusion public identities could be used to expand Calendar invitees.
Sep 4 2024, 17:57 · Discussion Needed, Calendar
valerio.bozzolan created T15938: Understand if Diffusion public identities could be used to expand Calendar invitees.
Sep 4 2024, 17:56 · Discussion Needed, Calendar
THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: THYDUX.
Sep 4 2024, 16:20
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

fix typos in documentation

Sep 4 2024, 14:54 · Projects
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

add a bit of documentation - just because we can

Sep 4 2024, 14:40 · Projects
THYDUX awarded rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator. a Manufacturing Defect? token.
Sep 4 2024, 10:19
aklapper edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: THYDUX; added 1: Cigaryno.
Sep 4 2024, 10:19
THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: THYDUX.
Sep 4 2024, 10:17
aklapper closed D25802: Remove trivial cases of unreachable code.
Sep 4 2024, 10:17
aklapper committed rP43539b220ce2: Remove trivial cases of unreachable code.
Remove trivial cases of unreachable code
Sep 4 2024, 10:17
aklapper closed D25803: Remove trivial cases of unreachable code.
Sep 4 2024, 10:16
aklapper committed rARCb888963f6ff5: Remove trivial cases of unreachable code.
Remove trivial cases of unreachable code
Sep 4 2024, 10:16
aklapper closed D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 10:14
aklapper committed rP8c3a62d6afd0: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
Sep 4 2024, 10:14
aklapper closed D25804: Correct parameter name of PhpunitTestEngine::parseTestResults().
Sep 4 2024, 09:46
aklapper committed rARC201fc1d981a9: Correct parameter name of PhpunitTestEngine::parseTestResults().
Correct parameter name of PhpunitTestEngine::parseTestResults()
Sep 4 2024, 09:46
aklapper closed D25782: Remove unused PhutilConsoleProgressSink::getWidth().
Sep 4 2024, 09:46
aklapper committed rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().
Remove unused PhutilConsoleProgressSink::getWidth()
Sep 4 2024, 09:46
valerio.bozzolan accepted D25782: Remove unused PhutilConsoleProgressSink::getWidth().
Sep 4 2024, 09:37
valerio.bozzolan accepted D25804: Correct parameter name of PhpunitTestEngine::parseTestResults().

yesyes

Sep 4 2024, 09:33
valerio.bozzolan accepted D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.

sgtm

Sep 4 2024, 09:33
aklapper requested review of D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 08:13
aklapper added a revision to T15936: PHP8.1 strlen(): Passing null to parameter is deprecated: D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 08:13 · PHP 8 support
aklapper added a comment to T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.

Right, should have probably also covered that line in D25186 which is more or less the same...

Sep 4 2024, 08:02 · PHP 8 support
aklapper added a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 4 2024, 08:01 · PHP 8 support
aklapper added a parent task for T15936: PHP8.1 strlen(): Passing null to parameter is deprecated: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Sep 4 2024, 08:01 · PHP 8 support
aklapper merged T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Sep 4 2024, 07:51 · Bug Reports, Differential
aklapper merged task T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Sep 4 2024, 07:51 · Phorge
speck added a comment to D25535: T15011: Update support for XHPast on Windows.

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?

Sep 4 2024, 02:07
speck updated the task description for T15937: Exception when viewing diff while not logged in.
Sep 4 2024, 02:04 · Phorge
speck created T15937: Exception when viewing diff while not logged in.
Sep 4 2024, 02:03 · Phorge

Sep 3 2024

speck accepted D25673: Fix error in Mercurial when no offset is specified.

Ty. I’m still confused how “limit” is required but doesn’t throw an error when not specified. Can address that later if needed.

Sep 3 2024, 21:53
Universal-Omega updated the task description for T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 3 2024, 20:28 · PHP 8 support
Universal-Omega created T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 3 2024, 20:27 · PHP 8 support
RhinosF1 added a member for Trusted Contributors: Universal-Omega.
Sep 3 2024, 20:24
THYDUX awarded Welcome to the Phorge Wiki a Yellow Medal token.
Sep 3 2024, 18:30 · Phorge
valerio.bozzolan renamed Next Up from 2024.35 to Next Up.
Sep 3 2024, 15:12
valerio.bozzolan edited the content of Next Up.
Sep 3 2024, 15:12
valerio.bozzolan edited the content of Next Up.
Sep 3 2024, 14:50
valerio.bozzolan renamed Welcome to the Phorge Wiki from Welcome to Welcome to the Phorge Wiki.
Sep 3 2024, 10:25 · Phorge
aklapper closed D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.
Sep 3 2024, 10:08
aklapper committed rARCf9749273778b: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.
Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
Sep 3 2024, 10:08
avivey accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Sep 3 2024, 07:57
valerio.bozzolan added inline comments to D25805: Correct PHPDoc @return value of methods that can return null.
Sep 3 2024, 05:26
valerio.bozzolan accepted D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.

sgtm

Sep 3 2024, 05:13
valerio.bozzolan added a comment to D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

Thanks. Premising that $body can be null and that's a feature

Sep 3 2024, 05:12

Sep 2 2024

Sten accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.

Not before time!

Sep 2 2024, 10:56
valerio.bozzolan added a comment to D25731: Set default menu item to Project Details when archiving a project.

I don't favor implementing non-obvious behavior ("why does it sometimes do this but not always"). :)

Sep 2 2024, 08:55
aklapper added a comment to D25731: Set default menu item to Project Details when archiving a project.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Sep 2 2024, 08:37
aklapper closed D25783: Remove unused ArcanistGitLocalState::getDisplayStashRef().
Sep 2 2024, 06:55
aklapper committed rARC995072b31fff: Remove unused ArcanistGitLocalState::getDisplayStashRef().
Remove unused ArcanistGitLocalState::getDisplayStashRef()
Sep 2 2024, 06:55

Sep 1 2024

valerio.bozzolan added a comment to D25731: Set default menu item to Project Details when archiving a project.

An additional check to make milestone owners happy might be: look to see if the board shows at least one task. If not, proceed.

Sep 1 2024, 22:12
valerio.bozzolan resigned from D25731: Set default menu item to Project Details when archiving a project.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Sep 1 2024, 22:10
valerio.bozzolan added a comment to D25673: Fix error in Mercurial when no offset is specified.

Thanks aklapper. Seems good from our side @speck?

Sep 1 2024, 22:07
valerio.bozzolan accepted D25783: Remove unused ArcanistGitLocalState::getDisplayStashRef().

yesyes

Sep 1 2024, 21:20
valerio.bozzolan edited the content of 2024 week 35.
Sep 1 2024, 07:40

Aug 31 2024

aklapper updated the summary of D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:44
aklapper requested review of D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:43
aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:43 · PHP 8 support
Iniquity awarded T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. a Love token.
Aug 31 2024, 09:48 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard
Iniquity added a comment to T15801: Mention on landing page that Phorge is a community fork of Phabricator.

It seems to me that in general more information should be added to the main page: screenshots, main features, as is usually done in other large projects.

Aug 31 2024, 09:37 · Phorge
aklapper added a revision to T15047: Officially raise minimum required PHP version to 7.2: D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Aug 31 2024, 08:21 · Phorge
aklapper requested review of D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Aug 31 2024, 08:21
aklapper added a comment to T15047: Officially raise minimum required PHP version to 7.2.

Supporting PHP 8.4 (currently planned for 2024-11-21) will require PHP syntax introduced in PHP 7.1 per T15935.

Aug 31 2024, 08:20 · Phorge
aklapper added a parent task for T15047: Officially raise minimum required PHP version to 7.2: T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.
Aug 31 2024, 07:48 · Phorge
aklapper added a subtask for T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: T15047: Officially raise minimum required PHP version to 7.2.
Aug 31 2024, 07:48 · PHP 8 support

Aug 30 2024

aklapper updated the task description for T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.
Aug 30 2024, 15:19 · PHP 8 support
aklapper updated the summary of D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:57
valerio.bozzolan updated the summary of D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:57
aklapper updated the summary of D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:42
aklapper added a comment to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.

Note that above two patches only allow passing ./bin/storage upgrade but not to run Phorge. That would be a followup once these initial patches got in.

Aug 30 2024, 14:41 · PHP 8 support
aklapper requested review of D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:40
aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:40 · PHP 8 support
aklapper requested review of D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:37
aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:37 · PHP 8 support
aklapper created T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.
Aug 30 2024, 14:29 · PHP 8 support
valerio.bozzolan awarded T15933: Support side-by-side diffs for task description changes a Doubloon token.
Aug 30 2024, 06:16 · Maniphest
Tgr added a comment to T15933: Support side-by-side diffs for task description changes.

The hacky solution would be to duplicate the current diff block, and then hide the green text on one side and the red text on the other side.

Aug 30 2024, 06:15 · Maniphest

Aug 29 2024

revi added projects to T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16: Deprecation Notice, PHP 8 support, Arcanist.
Aug 29 2024, 15:34 · Arcanist, PHP 8 support, Deprecation Notice
revi created T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16.
Aug 29 2024, 15:21 · Arcanist, PHP 8 support, Deprecation Notice
revi updated the title for P46 arc download from untitled to arc download.
Aug 29 2024, 15:16
revi created P46 arc download.
Aug 29 2024, 15:13
valerio.bozzolan added a comment to T15933: Support side-by-side diffs for task description changes.

Agree. But the best I can do is... adding a slider that, the more you scroll it, the more it hides the red text/green text... LOL

Aug 29 2024, 14:57 · Maniphest
Tgr created T15933: Support side-by-side diffs for task description changes.
Aug 29 2024, 14:33 · Maniphest
aklapper closed D25786: Remove unused shouldUse* functions from PhabricatorRepository.
Aug 29 2024, 08:26
aklapper committed rP24ebac8ad734: Remove unused shouldUse* functions from PhabricatorRepository.
Remove unused shouldUse* functions from PhabricatorRepository
Aug 29 2024, 08:26
valerio.bozzolan added a comment to D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

Untested but seems good to me, maybe nice to add a couple of

Aug 29 2024, 05:28 · Remarkup
valerio.bozzolan accepted D25786: Remove unused shouldUse* functions from PhabricatorRepository.

sgtm

Aug 29 2024, 05:22
valerio.bozzolan accepted D25803: Remove trivial cases of unreachable code.

sgtm

Aug 29 2024, 05:20
valerio.bozzolan accepted D25802: Remove trivial cases of unreachable code.

sgtm

Aug 29 2024, 05:19

Aug 28 2024

valerio.bozzolan edited the content of 2024 week 35.
Aug 28 2024, 14:56
valerio.bozzolan edited the content of 2024 week 35.
Aug 28 2024, 10:19
avivey edited the content of Change Log.
Aug 28 2024, 09:28
avivey renamed Next Up from Next Up to 2024.35.
Aug 28 2024, 09:27
valerio.bozzolan added inline comments to D25363: Calendar Import: calendar uploader is not anymore an alien.
Aug 28 2024, 07:37
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

git rebase master

Aug 28 2024, 07:35