Page MenuHomePhorge
Feed All Stories

Fri, May 10

aklapper closed T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24 as Resolved by committing rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 16:13 · Arcanist, Deprecation Notice
aklapper closed D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 16:13
aklapper committed rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type
Fri, May 10, 16:13
valerio.bozzolan added a comment to Q125: "Not In" query operator and searching for project milestones (Answer 158).

(Premising that this is an answer to your question. Please move this as comment to your question.)

Fri, May 10, 15:39
valerio.bozzolan added a member for Trusted Contributors: LSobanski.
Fri, May 10, 15:38
valerio.bozzolan added a comment to Image Macro "hammerfix".

Nice but please smaller :D

Fri, May 10, 15:27
revi created Image Macro "hammerfix".
Fri, May 10, 13:07
valerio.bozzolan updated the test plan for D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 12:59
valerio.bozzolan accepted D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.

Thanks! I was able to test visiting a profile image, and inspecting phlog() in the webserver log.

Fri, May 10, 12:58
valerio.bozzolan accepted D25633: Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck.

Thanks. I was able to test that the thing is just a string, not an object with a toString(), so no nuclear implosions

Fri, May 10, 12:52
aklapper requested review of D25633: Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck.
Fri, May 10, 10:22
aklapper added a revision to T15823: PHP 8.1 "strlen(null)" exception checking for open setup issues: D25633: Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck.
Fri, May 10, 10:22 · PHP 8 support
aklapper created T15823: PHP 8.1 "strlen(null)" exception checking for open setup issues.
Fri, May 10, 10:20 · PHP 8 support
aklapper requested review of D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 10:04
aklapper added a revision to T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24: D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 10:04 · Arcanist, Deprecation Notice
aklapper updated the summary of D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Fri, May 10, 09:23
aklapper updated the diff for D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

Garrr I am so sure I had tested it this morning but maybe I was sleepwalking? Tested again now and seems to work, thanks

Fri, May 10, 09:20
aklapper accepted D25080: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Giving a +1 as I had tested this in D25080#16527 but I would prefer to see the two strings adjusted in D25080#16549

Fri, May 10, 09:11 · Workboard
aklapper accepted D25626: The feed "created this task" should be the first one.

I currently cannot think of other potential side effects (mail notifications about task creation seem to have had a [Created] prefix taking priority over other actions for years, and web notifications in the top bar also still behave as before), so I'll give my +1

Fri, May 10, 09:05
valerio.bozzolan added a comment to D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

(If it does not work you may still need to call .toString() before doing this)

Fri, May 10, 08:16
aklapper updated the diff for D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

The coffee on my desk doesn't seem to work yet - use a proper comparison.

Fri, May 10, 07:47
aklapper updated the diff for D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

Use standard JS string concatenation instead of shiny padStart() because better backwards compatibility

Fri, May 10, 07:46
revi created T15822: When a phriction page is moved, history should follow the page move.
Fri, May 10, 07:45 · Feature Requests, Phorge
revi created T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24.
Fri, May 10, 07:27 · Arcanist, Deprecation Notice
revi created P37 error.php.
Fri, May 10, 07:21
valerio.bozzolan edited the content of Next Up.
Fri, May 10, 05:49
valerio.bozzolan added projects to T15575: Moving a Phriction page does not move its Tags: Bug Reports, User-valerio.bozzolan.
Fri, May 10, 05:39 · User-valerio.bozzolan, Bug Reports
valerio.bozzolan added projects to T15453: Diffusion: Create Identity form is incomplete: Diffusion, Bug Reports.
Fri, May 10, 05:38 · Bug Reports, Diffusion

Thu, May 9

aklapper added a comment to D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

I think somebody here would propose to avoid padStart() and be boring:

if (d_m.length < 2) {
  d_m = '0' + d_m;
}
Thu, May 9, 22:12
valerio.bozzolan moved T15816: The feed "created this task" should be the first one from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Thu, May 9, 19:51 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan awarded D25626: The feed "created this task" should be the first one a Like token.
Thu, May 9, 19:51
valerio.bozzolan added a comment to D25549: Add Standard Custom Fields to Item List.

For some reasons I cannot cleanly apply the patch anymore.

Thu, May 9, 19:48
valerio.bozzolan awarded T15820: Update d3 from version 5.9.2 to 6.7.0 a Grey Medal token.
Thu, May 9, 17:30
aklapper added a comment to T15820: Update d3 from version 5.9.2 to 6.7.0.

Just because we can, right? Or any real concern?

Thu, May 9, 17:00
valerio.bozzolan closed D25627: TransactionEditor: micro-optimize the "creation finder".
Thu, May 9, 16:40
valerio.bozzolan committed rPb6f132f04f06: TransactionEditor: micro-optimize the "creation finder".
TransactionEditor: micro-optimize the "creation finder"
Thu, May 9, 16:40
valerio.bozzolan closed T15817: Dashboard Text Panel: Incomplete Transaction "text.text" when changing Description as Resolved by committing rP6514598f6635: Dashboard Text Panel: improve feed when changing Description.
Thu, May 9, 16:40 · User-valerio.bozzolan, Dashboards
valerio.bozzolan closed D25625: Dashboard Text Panel: improve feed when changing Description.
Thu, May 9, 16:40
valerio.bozzolan committed rP6514598f6635: Dashboard Text Panel: improve feed when changing Description.
Dashboard Text Panel: improve feed when changing Description
Thu, May 9, 16:40
valerio.bozzolan added a comment to T15820: Update d3 from version 5.9.2 to 6.7.0.

Just because we can, right? Or any real concern?

Thu, May 9, 16:37
valerio.bozzolan accepted D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

✅ Number.prototype.toString() supported by all browser webs https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toString

Thu, May 9, 16:29
valerio.bozzolan claimed T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out.

This fix was super-interesting. Thanks again for the report.

Thu, May 9, 16:05 · User-valerio.bozzolan
valerio.bozzolan updated the test plan for D25621: Show login page if a search token requires a valid viewer.
Thu, May 9, 16:04
valerio.bozzolan updated the test plan for D25621: Show login page if a search token requires a valid viewer.
Thu, May 9, 15:53
valerio.bozzolan accepted D25051: Destroy file attachments when file is deleted, or object is deleted.

Thanks again. My only concern is that, if somebody has a 1 trillion file(s) then the patch may lock the involved tables for an unexpected long amount of time, and you cannot really undo, without causing a massive implicit rollback.

Thu, May 9, 15:40 · Files
aklapper requested review of D25631: Update d3 from version 5.9.2 to 6.7.0.
Thu, May 9, 15:21
aklapper added a revision to T15820: Update d3 from version 5.9.2 to 6.7.0: D25631: Update d3 from version 5.9.2 to 6.7.0.
Thu, May 9, 15:21
valerio.bozzolan retitled D25051: Destroy file attachments when file is deleted, or object is deleted from Destroy file attachments when file is deleted
Thu, May 9, 15:21 · Files
aklapper created T15820: Update d3 from version 5.9.2 to 6.7.0.
Thu, May 9, 15:20
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Thu, May 9, 15:04 · Files
aklapper updated the summary of D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Thu, May 9, 13:54
aklapper requested review of D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Thu, May 9, 13:50
aklapper added a revision to T15819: Facts: Burndown Charts should render YYYY-MM-DD with eight digits: D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Thu, May 9, 13:50
aklapper created T15819: Facts: Burndown Charts should render YYYY-MM-DD with eight digits.
Thu, May 9, 13:50
aklapper abandoned D25505: Improve handling queries with "Current Viewer" set while not logged in.

The approach taken in D25621 is more wholesome and preferable thus abandoning this

Thu, May 9, 12:54
aklapper closed T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Thu, May 9, 12:42 · PHP 8 support
aklapper closed T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results as Resolved by committing rP61c953268ecd: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Thu, May 9, 12:42 · PHP 8 support
aklapper closed D25629: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Thu, May 9, 12:42
aklapper committed rP61c953268ecd: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results
Thu, May 9, 12:42
valerio.bozzolan accepted D25629: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.

It worked in line 109, it will work in line 154. Tested.

Thu, May 9, 12:24
valerio.bozzolan updated the diff for D25621: Show login page if a search token requires a valid viewer.

Cover more cases that require login:

Thu, May 9, 12:23
valerio.bozzolan added a comment to T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results.

Wow you are fast. I was going to create this :D I can reproduce

Thu, May 9, 12:21 · PHP 8 support
valerio.bozzolan abandoned D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Thu, May 9, 11:58
valerio.bozzolan commandeered D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

Commanding to set as abandoned. Thanks again! Well done for your original troubleshooting.

Thu, May 9, 11:57
valerio.bozzolan closed T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized as Resolved by committing rP5b90567f6453: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 11:56 · Bug Reports
valerio.bozzolan closed D25628: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 11:56
valerio.bozzolan committed rP5b90567f6453: Persistent Chat: fix de-minimize misclick.
Persistent Chat: fix de-minimize misclick
Thu, May 9, 11:56
aklapper accepted D25627: TransactionEditor: micro-optimize the "creation finder".

This makes sense.

Thu, May 9, 11:46
valerio.bozzolan updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

git rebase master

Thu, May 9, 11:32 · Files
aklapper accepted D25628: Persistent Chat: fix de-minimize misclick.

Tested locally before and after applying this branch, with two users sending messages in a chat room after clicking the speechbubbles icon in top bar and selecting "Persistent Chat", both functionality wise (clicking the bar in the lower right corner) and by inspecting the element in the web browser's developer tools' inspector. Works as expected.

Thu, May 9, 11:30
valerio.bozzolan added a comment to D25051: Destroy file attachments when file is deleted, or object is deleted.

Just as clarification for myself (maybe already obvious to others):

Thu, May 9, 11:27 · Files
aklapper requested review of D25629: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Thu, May 9, 11:24
aklapper added a revision to T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results: D25629: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Thu, May 9, 11:24 · PHP 8 support
aklapper created T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results.
Thu, May 9, 11:23 · PHP 8 support
aklapper added a comment to D25621: Show login page if a search token requires a valid viewer.

Thanks for working on this! Works pretty well locally. From a quick test of this branch, while being logged out,

  • Maniphest Advanced Search: Setting Assigned to to Current Viewer, I get a Login page.
  • Diffusion Commits Advanced Search: Setting Authors to Current Viewer, I get a Login page.
  • Differential Advanced Search: Setting both Authors and Reviewers to Current Viewer, I get a Login page.
  • Differential Advanced Search: Setting Responsible Users to Current Viewer, I get an exception (DifferentialResponsibleDatasource - probably another source to cover here?)
Thu, May 9, 11:08
valerio.bozzolan retitled D25622: Transformed Pictures: make them non-orphan from People Profile Picture: make image transform non-orphan
Thu, May 9, 10:45
valerio.bozzolan updated the test plan for D25628: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 10:26
valerio.bozzolan claimed T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.
Thu, May 9, 10:25 · Bug Reports
valerio.bozzolan added a comment to D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

Thanks again Roberto.

Thu, May 9, 10:22
valerio.bozzolan updated the summary of D25628: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 10:21
valerio.bozzolan changed the visibility for F2184778: Conpherence Settings Icon hidden.png.
Thu, May 9, 10:20
valerio.bozzolan requested review of D25628: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 10:19
valerio.bozzolan added a revision to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized: D25628: Persistent Chat: fix de-minimize misclick.
Thu, May 9, 10:19 · Bug Reports
aklapper closed T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Thu, May 9, 09:04 · PHP 8 support
aklapper closed T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314 as Resolved by committing rPaad704d0fce5: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Thu, May 9, 09:04 · PHP 8 support
aklapper closed D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Thu, May 9, 09:04
aklapper committed rPaad704d0fce5: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Mark created Pholio mockups as new objects to fix empty Feed transaction entries
Thu, May 9, 09:04
valerio.bozzolan added a comment to D25569: Avoid separate per-line URIs in line number column.

My last comment is also because the W3C does not allow to start an identifier with a number:

Thu, May 9, 09:02
aklapper added a comment to T15815: Make i18n string extraction ignore strings in test cases.

Should somebody file a ticket for that?

Thu, May 9, 09:01 · Localization
valerio.bozzolan accepted D25602: Do not hardcode default Priority names in Project Reports tooltip.

Please evaluate extended names:

Thu, May 9, 08:57
valerio.bozzolan added a comment to D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.

Unrelated but, thanks to your patch, we catched a possible micro-optimization. Here that unrelated change:

Thu, May 9, 08:33
valerio.bozzolan requested review of D25627: TransactionEditor: micro-optimize the "creation finder".
Thu, May 9, 08:32
valerio.bozzolan accepted D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.

Thanks again! This looks perfect in the current state of PholioMockEditor, since it's not an EditEngine and since this is not an appropriate moment to learn all the differences between an "Editor" and an "EditEngine" and/or it's not an appropriate moment to do that kind of migration here now (if ever needed).

Thu, May 9, 08:21
valerio.bozzolan added a comment to D25619: Fixes overflowing of AphrontSideNavFilterView on small screens and tidies up nav bar styles.

Maybe "feature" but note the left sidebar, is not anymore connected to the end of the viewport:

Thu, May 9, 08:05
valerio.bozzolan changed the visibility for F2184698: Maniphest list after.png.
Thu, May 9, 08:03
valerio.bozzolan changed the visibility for F2184696: Maniphest list before.png.
Thu, May 9, 08:02
valerio.bozzolan updated the summary of D25619: Fixes overflowing of AphrontSideNavFilterView on small screens and tidies up nav bar styles.
Thu, May 9, 08:01
valerio.bozzolan added a comment to D25621: Show login page if a search token requires a valid viewer.

Sharing some comments

Thu, May 9, 07:26
avivey edited the content of Next Up.
Thu, May 9, 06:16

Wed, May 8

pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

Wed, May 8, 23:57 · Localization