Has anyone experimented with using arcanist in a docker container? I see two people have published these on dockerhub:

• https://hub.docker.com/r/nasqueron/arcanist
• https://hub.docker.com/r/adlogix/arcanist

It's all a matter of risks after all. Keeping everything as-is ("all rights reserved") just increases risks for every contributor, including Administrators.

yeah, well, we still can't afford legal advice. If some funded organization is willing to donate some, we'll appreciate it.

At the moment, if somebody makes a comment in the website with a creative snippet, that is "all rights reserved" from that author. Same on Differential, since volatile patches can be somehow considered as out of the repository.

@valerio.bozzolan I think you're confusing this task ("website content") and T15121 (contributor agreement).

Since I am not currently authorized to make changes on other people's code from comments or Differential and I don't want to be vulnerable to copyright trolling.

In D25323#9739, @Sten wrote:

Could we have a lint rule to catch forbidden newlines?

Tested, thanks! I was able to debug both NULL, empty string, and a populated string, just putting some stuff in the fields.

Where exactly are you seeing this error? what page exactly?

Thank you, I created T15533.

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan), and it technically can't delete the branch (it can prevent it from being created, but that shows up as an error in the user-side).
But it should be able to at least trigger the flow and provide a URL for the user to click on.

Ok, the discussion here got a little out of focus. Maybe some parts of this can be extracted to their own discussion.

Could this be solved with a Herald action?

In T15498#11487, @valerio.bozzolan wrote:

OK I can reproduce now. I was missing the php-gd extension for some reasons.

I suspect there's also a problem of motivation: These things are lots of work, and the people who are capable of performing them - people who are comfortable with working with these tools - will not personally benefit from this stuff. The people who would benefit the most are people who are not involved in the project at all...

Wouldn't want to deny you your '0' comments!

Update empty string check to === '' as per review

Could we have a lint rule to catch forbidden newlines?

Interesting point about the array return.

Interestingly, it seems to me that, before, the result always has been an array since it passes through explode().

coalesce - I like that. It's going to see some use!

Soft +1 but we need some other opinions here

Tested uploading a diff via the web interface, and it's fine with and without this patch.

Pesky newline removed :-)

I think we can save at least 1 CPU cycle in avoiding strlen() all the time and just using other things, but this is the minimal change to avoid such crash. Thanks!

Hard +1 if that extra newline disappears :)

In D25296#9660, @avivey wrote:

To prevent --start and --stop from being used together, you should be able to add conflicts to one of the argument definitions. Could be named something else, I don't remember exactly. Search for it in other flows (including arcanist flows).

Currently, only Commits show anything like "description" (commit hovercard shows the commit message.

Yep thanks but can you please also try uploading a Diff from the web interface (without and with this patch)? think your patch fixes 2 bugs in one shot.

Just as clarification do you have any other Hovercard in mind that has a description?

It is possible to encounter a couple of problems but that plague any other Hovercard. Thanks! This is useful.

I triggered the exceptions just by running 'arc diff'. Visiting a diff on the web interface was fine. Please see T15530 for the exception stack trace.

What do you think about the test plan here? Is this relevant also to the online web interface (Diff paste) or just to running arc diff? or visiting a Diff is enough (visiting stuff I think it's not relevant)?

Nice - complete removal of that strlen as suggested.

A person enters in a bar and

In D25296#9658, @valerio.bozzolan wrote:

Hi @avivey what do you think about this legacy possible situation?

$ ./bin/repository maintenance --stop --start "" R9
Took repository "R9" out of maintenance mode.

Maybe this Diff is a good moment to introduce a fix also to that, with a dedicated message

Hi @avivey what do you think about this legacy possible situation?

a bit more readable

I tested all the cases locally, seems good to me. I will just amend the small proposed thing for better readability.

Please also rebase with master branch