Sorry about the delay on this. I think the emails didn't go out until later and I've not had much time to dedicate to this project as expected. As of today's meeting the current plan is for @avivey to do the merge with latest updates from upstream and push, sans review.

Per discussion during {E9}

New certificate issued.

https://we.phorge.it/phame/blog/view/3/ - Security Announcements
https://we.phorge.it/phame/blog/view/4/ - Release Announcements

@20after4 Hey, this does not appear to be working. T15101 was created by a user who was not a member of Trusted Contributors

Please do not triage tasks yourself, we will integrate it into the roadmap as we go.

There should be a systemd service for managing the daemons, I'll check tonight what's wrong with it and why it isn't correctly starting daemons on reboot

Somehow this work ok with standard web serving but when trying run form phd daemon I'm getting:

@speck What is the status of this change?

@speck I think we're sort of good to go here? maybe update?

@avivey has fixed this on the upstream install.

Hit esc today - Lost lots of typing

In T15096#2333, @sario528 wrote:

Allowing a user to make quick simple changes with nothing but a web browser is IMO the single best way to encourage new contributors.

In T15096#2329, @avivey wrote:

For new users, support the the magic-ref style of gerrit, but with a web-UI Wizard based next steps, where we walk her through creating/updating the right revision, maybe explain what happens to all the commits and what other users will experience. Treat this as an onboarding experience - with the expectation that full-time contributors will eventually switch to Arcanist.
Maybe upsell Arcanist at this point.

I'd point out that Gerrit was originally intended to work with a client-side tool called repo (Which also manages multi-repo code trees).
The git push ... <magic ref> is kind of a workaround for users that found having a client-side tool annoying to use :)

epriestly pushed basically-identical but cleaner fixes for these in https://secure.phabricator.com/D21849

To be fair, I wouldn't discount already needing access as a viable attack vector, even on private installations.

It sounds specific to people who already have access, thank you -- do very much need to pull in latest

The disclosed issue is that someone can gain access to Files objects they don't have access to by, for example, getting someone with permissions to edit a task they wrote (by including a reference to that file which gets "activated" when the person with permissions to view it saves the edit), which makes the file accessible via the task description.

Thanks -- Offhand do you know if this is related to login in that a malicious actor can gain access to source code when unpatched?

Upstream-T13683

IMPORTANT: This release mitigates a severe security issue which allows attackers with few permission to gain access to files they can not otherwise see. All installs are strongly advised to upgrade.

FYI today's release (2022 week 21 stable) has a some pretty serious security content

@dcog I think the differences with the Harbormaster changes are due to the different approach taken. We planned to do the approach which you took in D25036 which re-played the Phorge diffs on top of phabricator, however in D25040 I just did a merge of the phab/master branch into phorge/master where the Harbormaster changes already existed. Since upstream didn't modify the same Harbormaster files there were no conflicts and things merged appropriately. I did a sanity check of files changed on D25005 with the files changed on D25040.

Do we even have servers to run the tests on?

In T15094#2292, @speck wrote:

I did not think we had Harbormaster set up to run unit tests - I think that involves configuring both Harbormaster and Drydock, and possibly Almanac which I don't think anyone has done.

I'll go back and review those Harbormaster file changes. Thanks for pointing that out!

In T15094#2281, @dcog wrote:

This would be a legitimately good exercise to try and do "properly"... although, the thought of not doing it optimally can be a bit of a barrier to starting..

Given the edge cases outlined in T15094#2279, would there be cases in step 2 (or 1?) from T15094#2259 that might benefit from Git cherry-picking? @golyalpha, any thoughts on that? I nearly never have to use cherry-picking, or maybe I should, but either way I'm not very familiar with it other than I'm wondering if it may be relevant

After some reading I'm finding that, as far as I can tell, it's not designed to pick/integrate *specific lines* from a diff, but rather a specific whole commit (from any local or remote branch most likely).. if I'm understanding it correctly

But, perhaps, it could still have the same effect as removing lines from one, and keeping lines from the other when grabbing specific whole commits

The more I think about this the more I'm confusing myself, but hopefully some fraction of this makes sense

I did not think we had Harbormaster set up to run unit tests - I think that involves configuring both Harbormaster and Drydock, and possibly Almanac which I don't think anyone has done.

I would think that your method produced the results we want... though I was noticing this:

I see it looks Harbormaster itself does the testing?

My vote is that if tests pass we go ahead and do the thing.... More changes in upstream seems fine, and moving forward if we keep up it should get easier and easier hopefully

Oh nice!!

Though it does appear additional work has been landing upstream today

Any concerns about landing those changes? Once I land I'll see about updating this instance which should make accessing the repositories possible again.

I had to skip unit tests because phabricator/phorge unit tests require a local database to test against which I don't have setup. The lint failures are either pre-existing TODO's being flagged or the newest lint which catches product name literals. We should fix the literals but I don't want to fix that as part of the merge -- would rather do that in a separate change.

Unit tests all pass. For the two lint errors, one is erroneous checking characters used in a non-code file, the other is pre-existing and fine to leave alone.

Merged the arcanist repository in D25039

This would be a legitimately good exercise to try and do "properly"... although, the thought of not doing it optimally can be a bit of a barrier to starting..

@dtf Pointed out that this thread on secure is highly relevant:

Thinking that based on the first item in (2) Rebrand here: https://we.phorge.it/w/planning_meetings/2022-05-03/#agenda-items-and-notes

Here is one thing I noticed... In at least a couple of the files, there may be changes that:

Referencing a comment from the earlier document:

I inspected the code in some detail and i figured out how to get the default value of a custom field. In a first attempt to solve my issue i tried to only show a field value in the property list of a Task if its value differs from the field default value but this does not work because i can not get the current field value this way: