Page MenuHomePhorge

Add HarbormasterHookController as an entry point for all Harbormaster hooks
ClosedPublic

Authored by deadalnix on Jun 19 2021, 14:55.

Details

Summary

This makes the set of hooks easily extensible, as a first step toward integrating more 3rd party CI in phorge.

Test Plan

Send requests to /harbormaster/hook/circleci/ and /harbormaster/hook/buildkite/ and check they run the proper handler.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 19 2021, 14:55
Matthew added a subscriber: Matthew.

Looks good to me.

I've created a task to track these changes, by the way.

This revision is now accepted and ready to land.Jun 20 2021, 21:37
src/applications/harbormaster/integration/HarbormasterHookHandler.php
23–25

Could we add documentation to these for future implementations know what's expected? I think in particular getName() actually affects the expected URL to be hit from an external CI, correct? Would a UT be appropriate to ensure that implementations of HarbormasterHookHandler don't overlap their names?

This change looks solid but I am a little concerned about pushing up feature/functional changes prior to getting all the branding work done for T15006: Re-brand Phorge. I haven't been able to spend as much time on that recently as I'd like and would appreciate any assistance on it. I'll update the task to clarify the strategy/approaches that I think we need to address.