- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 25 2023
remote: This push was rejected by Herald push rule H8. remote: Change: commit/ remote: Rule: Guard Arcanist Repo with Blessed Committers remote: Reason: Commit is not approved by Blessed Committers remote: Transcript: https://we.phorge.it/herald/transcript/4967/
In T15178#4406, @dcog wrote:$1.25USD bet says @valerio.bozzolan or @Cigaryno has some weird connection to Salesforce or Jira or Mantis
Thank you for your review
simplified inline comment
make the damn linter happy
Mar 24 2023
@Matthew thank you in the other Diff
Hi @Matthew please undo your -1 so the author can land
Hi @Cigaryno - I will offer you an authentic Phorge doublon for your review here
Do you want an hand to land this nice feature?
try to make a review even more simple
Damn Arcanist.
Interestingly, this modification also brings a performance improvement on calculating the length of multiple strings.
By the way, Rector.php was able to do this replacement automatically:
adopt mb_strlen() that is optimized to do exactly this if you tell that you want an UTF-8
simplification
fix inline comment
add inline comment
Hi @ollehar, if you want, join next meeting:
Thank you for this question
rebase, and celerity map
rebase from master
Mar 23 2023
The strange part is that much older versions are cited as problems elsewhere.
I have tested this locally, it works, it has sense, I also trust Dylsss, so, in good faith I accept as O1 (note: this is my very first time I approve something with such level)