Description

It seems these files and maybe others:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php

They executes similar stuff:

git cat-file -t -- <hash>:<file>

But it seems this cannot work in git version 1.8.3.1, since git thinks that "--" is a normal value.

It seems this error causes a series of weird assumptions and so it generates this misleading frontend warning:

This path was a submodule at R123:5378198ea123asdlol

To fix, we can:

Identify when support to "--" was introduced in git cat-file
- → git 2.5 (May 2015)
- details: https://unix.stackexchange.com/a/740621/85666
Add a compatibility patch for previous versions, or just mention this as minimum git version and wontfix

Related discussion:

https://unix.stackexchange.com/questions/740615/git-cat-file-when-was-introduced-the-escape-parameter

Revisions and Commits

rP Phorge
	D25089	rP1b9da964e970 Add setup check to avoid git version 2.5.0 and below (May 2015)
	D25081	rPf0618d54e8b5 Installation Guide: mention that git 2.5.0 (2015) is needed server-side

Related Objects

Mentioned In: 2023 Week 17
2023 Week 2

Event Timeline

valerio.bozzolan created this task.Mar 22 2023, 15:27

valerio.bozzolan triaged this task as Normal priority.

valerio.bozzolan created this object in space S1 Public.

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMar 22 2023, 15:27

valerio.bozzolan renamed this task from Diffusion: fix support for git version 1.8.3.1 to Diffusion: fix support for git version 1.8.3.1 ("This path was a submodule at ...").Mar 22 2023, 15:40

valerio.bozzolan updated the task description. (Show Details)

valerio.bozzolan updated the task description. (Show Details)Mar 22 2023, 15:53

valerio.bozzolan updated the task description. (Show Details)Mar 22 2023, 16:01

The user Stephen Kitt says that this option was not available before git 2.5.0 - that was released in May 2015.

https://unix.stackexchange.com/a/740621/85666

https://github.com/git/git/blob/6f9504c48ea59951a2aa3ee17e7c7fc36285e225/Documentation/RelNotes/2.5.0.txt

valerio.bozzolan updated the task description. (Show Details)Mar 22 2023, 16:08

valerio.bozzolan added a revision: D25081: Installation Guide: mention that git 2.5.0 (2015) is needed server-side.Mar 22 2023, 18:58

valerio.bozzolan renamed this task from Diffusion: fix support for git version 1.8.3.1 ("This path was a submodule at ...") to Diffusion: fix support for git version 1.8.3.1 ("This path was a submodule at ...") - probably since git < 2.5.0.Mar 23 2023, 22:06

valerio.bozzolan added a revision: D25089: Add setup check to avoid git version 2.5.0 and below (May 2015).Mar 23 2023, 23:00

The strange part is that much older versions are cited as problems elsewhere.

In any case, I merely pointed this out in a way that is simply ignorable by the user, and with enough information to form their own opinion and come here and say something to the contrary.

valerio.bozzolan closed this task as Wontfix by committing rPf0618d54e8b5: Installation Guide: mention that git 2.5.0 (2015) is needed server-side.Mar 27 2023, 18:51

valerio.bozzolan claimed this task.

valerio.bozzolan added a commit: rPf0618d54e8b5: Installation Guide: mention that git 2.5.0 (2015) is needed server-side.

valerio.bozzolan added a project: Documentation.Mar 27 2023, 20:27

valerio.bozzolan mentioned this in 2023 Week 2.

valerio.bozzolan added a project: User-valerio.bozzolan.Mar 28 2023, 09:03

avivey edited projects, added Diffusion; removed Diffusion (archived).Apr 6 2023, 10:46

valerio.bozzolan added a commit: rP1b9da964e970: Add setup check to avoid git version 2.5.0 and below (May 2015).Apr 10 2023, 09:17

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54