Page MenuHomePhorge

Fix information page about Read-only status
ClosedPublic

Authored by valerio.bozzolan on Mar 24 2023, 08:41.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 03:05
Unknown Object (File)
Wed, Mar 27, 01:48
Unknown Object (File)
Sun, Mar 24, 05:58
Unknown Object (File)
Thu, Mar 21, 12:57
Unknown Object (File)
Thu, Mar 21, 06:07
Unknown Object (File)
Thu, Mar 21, 01:38
Unknown Object (File)
Wed, Mar 20, 10:07
Unknown Object (File)
Feb 25 2024, 07:33

Details

Summary

This change fixes the following page on your Phorge/Phabricator:

/readonly/config/

If you visit that page (with or without read-only mode), the
following crash will happen:

Call to undefined method PlatformSymbols::getPlatformServerSymbol()

Fixes T15185

Probably the regression was introduced in this point:

rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c

This change also renamed "administrator" to "Administrator" in the messages
from that specific page, both because I have great respect for Administrators
and also because that is how this word is spelled in most other places in Phorge.

Test Plan
  • Visit the page /readonly/config/
  • It does not crash anymore and you can see that beautiful message that - it seems - no person in the world has ever seen since a whole year. Take a good look at this page: it is a precious treasure.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 25 2023, 09:42

Thank you for your review

Note that I use to mention the Task URL in the commit body since I like to have a human description accessible from your local git, or any other mirror (local, or GitHub, etc.); and, have Diffusion actions in the footer with short "Ref .." stuff for machines.

If you want, I can avoid my behavior, even if I think it's reasonable.

Since the context of these changes is all localized here, I think it's reasonable to use the short names (T1234), because we expect most users will see it in the context of this site. I just find the full addresses to be harder to read (I need to stop and actually read the URI to understand if this is an "internal" or "external" link).

I don't mind if you want to have both, I just think it's redundant.