Fix information page about Read-only status
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 24 2023, 08:41.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15185: Crash on "Readonly" Config page: call to undefined method PlatformSymbols::getPlatformServerSymbol()

Commits

rP9bc3c16b6e75: Fix information page about Read-only status

Summary

This change fixes the following page on your Phorge/Phabricator:

/readonly/config/

If you visit that page (with or without read-only mode), the
following crash will happen:

Call to undefined method PlatformSymbols::getPlatformServerSymbol()

Fixes T15185

Probably the regression was introduced in this point:

rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c

This change also renamed "administrator" to "Administrator" in the messages
from that specific page, both because I have great respect for Administrators
and also because that is how this word is spelled in most other places in Phorge.

Test Plan

Visit the page /readonly/config/
It does not crash anymore and you can see that beautiful message that - it seems - no person in the world has ever seen since a whole year. Take a good look at this page: it is a precious treasure.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Mar 24 2023, 08:41

Owners added a reviewer: O1: Blessed Committers.Mar 24 2023, 08:41

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 24 2023, 08:41

valerio.bozzolan requested review of this revision.Mar 24 2023, 08:41

Harbormaster completed remote builds in B168: Diff 380.Mar 24 2023, 08:41

valerio.bozzolan edited the summary of this revision. (Show Details)Mar 24 2023, 08:44

valerio.bozzolan mentioned this in D25090: Fix information page about Read-only status.Mar 24 2023, 19:06

valerio.bozzolan mentioned this in Z1: Phorge.Mar 24 2023, 22:56

avivey accepted this revision.Mar 25 2023, 09:41

avivey edited the summary of this revision. (Show Details)

avivey added a task: T15185: Crash on "Readonly" Config page: call to undefined method PlatformSymbols::getPlatformServerSymbol().

This revision is now accepted and ready to land.Mar 25 2023, 09:42

Thank you for your review

Note that I use to mention the Task URL in the commit body since I like to have a human description accessible from your local git, or any other mirror (local, or GitHub, etc.); and, have Diffusion actions in the footer with short "Ref .." stuff for machines.

If you want, I can avoid my behavior, even if I think it's reasonable.

Closed by commit rP9bc3c16b6e75: Fix information page about Read-only status. · Explain WhyMar 25 2023, 11:06

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP9bc3c16b6e75: Fix information page about Read-only status.

valerio.bozzolan mentioned this in 2023 Week 2.Mar 25 2023, 11:07

Since the context of these changes is all localized here, I think it's reasonable to use the short names (T1234), because we expect most users will see it in the context of this site. I just find the full addresses to be harder to read (I need to stop and actually read the URI to understand if this is an "internal" or "external" link).

I don't mind if you want to have both, I just think it's redundant.

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54