Page MenuHomePhorge

Fix information page about Read-only status

Authored by valerio.bozzolan on Mar 24 2023, 08:41.
Referenced Files
Unknown Object (File)
Wed, May 31, 06:09
Unknown Object (File)
Wed, May 10, 16:25
Unknown Object (File)
Apr 30 2023, 19:49
Unknown Object (File)
Apr 7 2023, 00:42
Unknown Object (File)
Apr 6 2023, 19:50
Unknown Object (File)
Apr 6 2023, 18:05
Unknown Object (File)
Apr 4 2023, 00:30
Unknown Object (File)
Mar 30 2023, 11:26



This change fixes the following page on your Phorge/Phabricator:


If you visit that page (with or without read-only mode), the
following crash will happen:

Call to undefined method PlatformSymbols::getPlatformServerSymbol()

Fixes T15185

Probably the regression was introduced in this point:


This change also renamed "administrator" to "Administrator" in the messages
from that specific page, both because I have great respect for Administrators
and also because that is how this word is spelled in most other places in Phorge.

Test Plan
  • Visit the page /readonly/config/
  • It does not crash anymore and you can see that beautiful message that - it seems - no person in the world has ever seen since a whole year. Take a good look at this page: it is a precious treasure.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 25 2023, 09:42

Thank you for your review

Note that I use to mention the Task URL in the commit body since I like to have a human description accessible from your local git, or any other mirror (local, or GitHub, etc.); and, have Diffusion actions in the footer with short "Ref .." stuff for machines.

If you want, I can avoid my behavior, even if I think it's reasonable.

Since the context of these changes is all localized here, I think it's reasonable to use the short names (T1234), because we expect most users will see it in the context of this site. I just find the full addresses to be harder to read (I need to stop and actually read the URI to understand if this is an "internal" or "external" link).

I don't mind if you want to have both, I just think it's redundant.