Page MenuHomePhorge

Fix information page about Read-only status
AbandonedPublic

Authored by valerio.bozzolan on Mar 24 2023, 08:41.
Tags
None
Referenced Files
F3968773: D25090.1746520177.diff
Mon, May 5, 08:29
F3945686: D25090.1746445249.diff
Sun, May 4, 11:40
F3942218: D25090.1746440043.diff
Sun, May 4, 10:14
F3754577: D25090.1745819907.diff
Sun, Apr 27, 05:58
F3527540: D25090.1744841146.diff
Tue, Apr 15, 22:05
F3422206: D25090.1744633860.diff
Sun, Apr 13, 12:31
F3399513: D25090.1744548605.diff
Sat, Apr 12, 12:50
F3374654: D25090.1744293952.diff
Apr 9 2025, 14:05

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

This change fixes the following page on your Phorge/Phabricator:

/readonly/config/

If you visit that page (with or without read-only mode), the
following crash will happen:

Call to undefined method PlatformSymbols::getPlatformServerSymbol()

For more information:

https://we.phorge.it/T15185

Probably the regression was introduced in this point:

https://secure.phabricator.com/rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c

https://we.phorge.it/rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c

Test Plan
  • Visit the page /readonly/config/
  • It does not crash anymore and you can see that beautiful message that - it seems - no person in the world has ever seen since a whole year. Take a good look at this page: it is a precious treasure.

Diff Detail

Repository
rP Phorge
Branch
config-readonly
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 167
Build 167: arc lint + arc unit

Unit TestsFailed

TimeTest
829 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
898 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
226 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
222 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
1 assertion passed.
1,306 msPhabricatorLibraryTestCase::testEverythingImplemented
1 assertion passed.
View Full Test Results (1 Failed · 6 Passed)