Paths

Table of Contentst

Differential D25088

Workboard: in some cases, increase menu opacity (accessibility)
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 18:08.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 7, 05:57

	Unknown Object (File)
	Tue, Apr 2, 15:53

	Unknown Object (File)
	Mon, Apr 1, 00:59

	Unknown Object (File)
	Mon, Apr 1, 00:59

	Unknown Object (File)
	Mon, Apr 1, 00:59

	Unknown Object (File)
	Sat, Mar 30, 06:03

	Unknown Object (File)
	Thu, Mar 28, 06:58

	Unknown Object (File)
	Sun, Mar 24, 05:57

View All 85 Files

Subscribers

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15186: Colorized Workboards: Increase contrast of menus (increase opacity)

Commits

rP38e3692d7bda: Workboard: in some cases, increase menu opacity (accessibility)

Summary

This change contains a very minimal graphical change for Workboards
with a custom background.

https://we.phorge.it/T15186

After this change, if your Workboard has a custom background color,
the opacity of the floating menu of the Column is not 0.9 but 0.95,
so it's increased a bit. The problem with the previous value, is that
when you open the menu, you see too much text underneath, and this
could worsen the readability. Now also probably, but less I hope.

Closes T15186

Test Plan

Workboard > Change Background Color > Pick a nice color
Backlog > Edit
Enjoy the extra 0.05 of opacity of that menu
NEVER ACCEPT IF YOUR EYES DETECT JUST A 0.04999998 OF EXTRA OPACITY

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Mar 23 2023, 18:08

Owners added a reviewer: O1: Blessed Committers.Mar 23 2023, 18:08

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 23 2023, 18:08

Harbormaster completed remote builds in B165: Diff 377.Mar 23 2023, 18:08

valerio.bozzolan requested review of this revision.Mar 23 2023, 18:08

Hi @Cigaryno - I will offer you an authentic Phorge doublon for your review here

avivey accepted this revision.Mar 27 2023, 18:40

This revision is now accepted and ready to land.Mar 27 2023, 18:40

You need to run the Celerity scripts!

Closed by commit rP38e3692d7bda: Workboard: in some cases, increase menu opacity (accessibility). · Explain WhyMar 27 2023, 18:51

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP38e3692d7bda: Workboard: in some cases, increase menu opacity (accessibility).

valerio.bozzolan mentioned this in T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.Mar 27 2023, 19:40

valerio.bozzolan mentioned this in 2023 Week 2.Mar 27 2023, 19:55

In D25088#3046, @avivey wrote:

You need to run the Celerity scripts!

jackie_chan_wtf

Whops :O I misunderstood in Jitsi. I was blinded by the green light.

Maybe we can land this:

D25025: Unify user-select CSS directives

That now has the celerity map up to date with webroot/rsrc/css/phui/workboards/phui-workboard-color.css

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

Path

Size

Packages

webroot/

rsrc/

css/

phui/

workboards/

phui-workboard-color.css

2 lines

O1: Blessed Committers

Diff 414

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...