Page MenuHomePhorge
Feed Advanced Search

May 23 2023

valerio.bozzolan moved T15182: Simplify the way "internal links" are identified from Backlog to PingDeath 馃寶 on the User-valerio.bozzolan board.
May 23 2023, 09:53User-valerio.bozzolan, Remarkup

May 22 2023

valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.

Premising I am trying to make few variations to the current behavior implemented by Evan

May 22 2023, 20:29User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed Q42: How to put a line break in a Remarkup cell? as resolved.
May 22 2023, 12:58Remarkup
valerio.bozzolan added a comment to Q42: How to put a line break in a Remarkup cell?.

You are the best, thanks for this tip

May 22 2023, 12:58Remarkup
smith added a comment to Q42: How to put a line break in a Remarkup cell?.

Thanks a lot!

May 22 2023, 12:58Remarkup
valerio.bozzolan added a comment to Q42: How to put a line break in a Remarkup cell?.

By the way you are now a Trusted Contributors :) Thanks

May 22 2023, 12:36Remarkup
valerio.bozzolan added a comment to Q42: How to put a line break in a Remarkup cell?.

Ah nice thanks @smith - feel free to move that as Answer

May 22 2023, 12:35Remarkup
smith added a comment to Q42: How to put a line break in a Remarkup cell?.

You can do it using HTML tags and literal line breaks, like this:

1122
AAB
B

But you probably already know that, given that the task you quoted was closed by committing this revision.
(<br> doesn't work here, but I think it should, even if it's ignored in plain Remarkup.)

May 22 2023, 09:45Remarkup

May 18 2023

speck added a comment to T15401: Make the Remarkup Help Page Extensible.

There鈥檚 possibly other reasons why they left it undocumented but it was a while back and I haven鈥檛 gone digging in the upstream for details.

May 18 2023, 21:42Documentation, Remarkup
speck added a comment to T15401: Make the Remarkup Help Page Extensible.

Historically the reason why these aren鈥檛 documented is that they originally required installing 3rd party tools on the server. They were documented in tasks upstream but there was a security issue found with using graphviz so at that time out of caution they reimplemented figlet and cowsay in php rather than passing arguments to a 3rd party executable. After the implementation change documentation was never updated.

May 18 2023, 21:40Documentation, Remarkup
valerio.bozzolan updated the task description for T15401: Make the Remarkup Help Page Extensible.
May 18 2023, 21:03Documentation, Remarkup
valerio.bozzolan added a comment to T15401: Make the Remarkup Help Page Extensible.

Discovered from D25142

May 18 2023, 20:59Documentation, Remarkup
valerio.bozzolan triaged T15401: Make the Remarkup Help Page Extensible as Wishlist priority.
May 18 2023, 20:58Documentation, Remarkup

May 9 2023

avivey added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Bug Reports.
May 9 2023, 15:19Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Remarkup.

(Sorry for the ping poing, re-adding Remarkup hoping to be useful since this seems an issue in Remarkup itself, but last word to avivey)

May 9 2023, 14:09Bug Reports, Remarkup, Affects-Wikimedia
avivey removed a project from T15203: Remarkup: allow to mention a Slowvote (without embedding): Slowvote.
May 9 2023, 10:53User-valerio.bozzolan, Remarkup
valerio.bozzolan added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

Premising that very probably a fix there would not 100% resolve that upstream issue but surely this deserves a fix :D

May 9 2023, 08:05Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Remarkup.
May 9 2023, 08:03Bug Reports, Remarkup, Affects-Wikimedia

May 4 2023

valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
May 4 2023, 16:38Files, Remarkup
valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
May 4 2023, 15:48Files, Remarkup
valerio.bozzolan updated the task description for T15106: "Upload file" in remarkup text fields should attach by default .
May 4 2023, 15:18Files, Remarkup

May 3 2023

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
May 3 2023, 13:22User-valerio.bozzolan, Discussion Needed, Remarkup

May 1 2023

valerio.bozzolan added a project to T15323: Add support for embedding Videos from Wikimedia Commons into Remarkup: Remarkup.
May 1 2023, 21:05Remarkup, Affects-Wikimedia

Apr 29 2023

valerio.bozzolan updated subscribers of T15293: Try to avoid message: Transaction (of type "core:file") has no effect.

Hi @Dylsss thanks again for your improvement. Have you any idea about why that message happens?

Apr 29 2023, 09:58Files, Remarkup
valerio.bozzolan triaged T15293: Try to avoid message: Transaction (of type "core:file") has no effect as Normal priority.
Apr 29 2023, 09:57Files, Remarkup

Apr 26 2023

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Apr 26 2023, 18:44User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()! as Resolved by committing rP7bd4089a2694: Drag & Drop: fix JavaScript error related to JX.$(undefined).
Apr 26 2023, 07:51Files, Remarkup
valerio.bozzolan closed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!, a subtask of T15106: "Upload file" in remarkup text fields should attach by default , as Resolved.
Apr 26 2023, 07:51Files, Remarkup

Apr 25 2023

valerio.bozzolan claimed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!.
Apr 25 2023, 14:51Files, Remarkup
valerio.bozzolan added a revision to T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!: D25134: Drag & Drop: fix JavaScript error related to JX.$(undefined).
Apr 25 2023, 14:24Files, Remarkup
valerio.bozzolan updated the task description for T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!.
Apr 25 2023, 14:12Files, Remarkup
valerio.bozzolan renamed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()! from Error: Empty ID passed to JX.$()! to RemarkupMetadata.js - Error: Empty ID passed to JX.$()!.
Apr 25 2023, 14:05Files, Remarkup
valerio.bozzolan triaged T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()! as High priority.
Apr 25 2023, 14:00Files, Remarkup

Apr 24 2023

Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.

(Ignored unrelated build failures, see fix: D25133)

Apr 24 2023, 01:57Remarkup
Restricted Repository Identity closed D25052: Add and use new RemarkupMetadata class.
Apr 24 2023, 01:53Remarkup
Dylsss updated the diff for D25052: Add and use new RemarkupMetadata class.

Rebased and applied suggested changes

Apr 24 2023, 00:27Remarkup
Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#4102, @Dylsss wrote:

I reverted to a previous commit (36dba82224de1b64bf571ebae5e944ce8a02e7c2) and still get this error when uploading from the remarkup toolbar upload button. So I don't think it is related to this change.

Apr 24 2023, 00:05Remarkup

Apr 23 2023

Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean
Apr 23 2023, 23:33Remarkup

Apr 21 2023

valerio.bozzolan added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#4020, @MCPCN wrote:

I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.

Apr 21 2023, 13:24Remarkup

Apr 20 2023

valerio.bozzolan added a comment to D25052: Add and use new RemarkupMetadata class.
WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean
Apr 20 2023, 20:03Remarkup
valerio.bozzolan updated the test plan for D25052: Add and use new RemarkupMetadata class.
Apr 20 2023, 20:00Remarkup
valerio.bozzolan added a comment to D25052: Add and use new RemarkupMetadata class.

Amazing @Dylsss you have green light here. Feel free to land.

Apr 20 2023, 19:15Remarkup
valerio.bozzolan added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#4020, @MCPCN wrote:

I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.

Using the upload button has different behaviour to drag&drop - files uploaded using the upload button need to be manually attached to the object which is a bit of a faff (not sure if there's a way to automatically do this?):

image.png (241脳558 px, 24 KB)

Apr 20 2023, 19:13Remarkup
Matthew accepted D25052: Add and use new RemarkupMetadata class.
Apr 20 2023, 15:58Remarkup
MCPCN added a comment to D25052: Add and use new RemarkupMetadata class.

I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.

Apr 20 2023, 15:21Remarkup
valerio.bozzolan triaged T15106: "Upload file" in remarkup text fields should attach by default as Normal priority.

I start triaging this to Normal priority since this problem creates situations that don't happen with many proprietary weird alternatives like Trello, Asana etc., where their Drag & Drop "just works" since their file are always visible to all members and so it's considered as "working" for their end-users (well, thanks to the fact that Trello etc. have a terrible permission management system, thousand years back from Phorge, and they really have no concept of "single file permission", and so they win easy in these confrontations where the user expects something basic and it doesn't happen as default by some of our "attach to something" corner cases).

Apr 20 2023, 13:55Files, Remarkup
valerio.bozzolan updated the summary of D25052: Add and use new RemarkupMetadata class.
Apr 20 2023, 13:50Remarkup
valerio.bozzolan added inline comments to D25052: Add and use new RemarkupMetadata class.
Apr 20 2023, 13:48Remarkup
valerio.bozzolan updated the test plan for D25052: Add and use new RemarkupMetadata class.
Apr 20 2023, 13:47Remarkup

Apr 19 2023

Bukkit added a project to T15245: Continue bulleted/numbered list during new line: Feature Requests.
Apr 19 2023, 18:25UX, Feature Requests, Remarkup

Apr 12 2023

Bukkit triaged T15245: Continue bulleted/numbered list during new line as Wishlist priority.
Apr 12 2023, 18:21UX, Feature Requests, Remarkup
Bukkit created T15245: Continue bulleted/numbered list during new line.
Apr 12 2023, 17:21UX, Feature Requests, Remarkup

Apr 7 2023

valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25118: Remarkup: make less internal links open in new tabs.
Apr 7 2023, 21:14User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15182: Simplify the way "internal links" are identified: D25118: Remarkup: make less internal links open in new tabs.
Apr 7 2023, 21:14User-valerio.bozzolan, Remarkup

Apr 6 2023

valerio.bozzolan edited projects for T15106: "Upload file" in remarkup text fields should attach by default , added: Files; removed Files (archived).
Apr 6 2023, 11:59Files, Remarkup
avivey edited projects for T15075: Add support for @link in diviner, added: Diviner; removed Diviner (archived).
Apr 6 2023, 10:19Diviner, Remarkup

Apr 5 2023

avivey triaged T15132: Support monospaced links in remarkup as High priority.
Apr 5 2023, 12:04Remarkup

Apr 4 2023

valerio.bozzolan removed a revision from T15132: Support monospaced links in remarkup: D25110: Fix "Search" Application description.
Apr 4 2023, 23:31Remarkup
valerio.bozzolan added a revision to T15132: Support monospaced links in remarkup: D25110: Fix "Search" Application description.
Apr 4 2023, 23:27Remarkup
valerio.bozzolan added a parent task for T15132: Support monospaced links in remarkup: T15230: Fix Search Application description.
Apr 4 2023, 23:22Remarkup
valerio.bozzolan added a comment to T15132: Support monospaced links in remarkup.

(I just added in the description the keyword "backtick" so I can easily find this)

Apr 4 2023, 23:13Remarkup
valerio.bozzolan updated the task description for T15132: Support monospaced links in remarkup.
Apr 4 2023, 23:09Remarkup

Apr 2 2023

Cigaryno added a project to T15075: Add support for @link in diviner: Remarkup.
Apr 2 2023, 07:28Diviner, Remarkup

Mar 29 2023

valerio.bozzolan closed T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine, a subtask of T15161: Internal resources should avoid to become external links, as default, as Wontfix.
Mar 29 2023, 17:46User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine as Wontfix.

By mistake I thought it was a formal global configuration but it seems it's not. So, I don't think it deserves a dedicated documentation.

Mar 29 2023, 17:46User-valerio.bozzolan, Remarkup

Mar 28 2023

valerio.bozzolan added a project to T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine: User-valerio.bozzolan.
Mar 28 2023, 09:04User-valerio.bozzolan, Remarkup
valerio.bozzolan added a project to T15203: Remarkup: allow to mention a Slowvote (without embedding): User-valerio.bozzolan.
Mar 28 2023, 09:04User-valerio.bozzolan, Remarkup
valerio.bozzolan added a project to T15161: Internal resources should avoid to become external links, as default: User-valerio.bozzolan.
Mar 28 2023, 09:03User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a project to T15182: Simplify the way "internal links" are identified: User-valerio.bozzolan.
Mar 28 2023, 09:03User-valerio.bozzolan, Remarkup

Mar 27 2023

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 27 2023, 15:08User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 27 2023, 15:07User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan renamed T15203: Remarkup: allow to mention a Slowvote (without embedding) from Slowvote Remarkup: add support for layout link to Remarkup: allow to mention a Slowvote (without embedding).
Mar 27 2023, 10:36User-valerio.bozzolan, Remarkup
valerio.bozzolan updated the task description for T15203: Remarkup: allow to mention a Slowvote (without embedding).
Mar 27 2023, 10:19User-valerio.bozzolan, Remarkup
valerio.bozzolan triaged T15203: Remarkup: allow to mention a Slowvote (without embedding) as Wishlist priority.
Mar 27 2023, 10:19User-valerio.bozzolan, Remarkup
Cigaryno added a project to T15106: "Upload file" in remarkup text fields should attach by default : Files (archived).
Mar 27 2023, 08:38Files, Remarkup

Mar 25 2023

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 25 2023, 21:38User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.

I agree. Having said that I'm not bold enough to propose a "default: open in same tab" since at the moment we have the exact contrary. That is why I proposed this compromise based on the destination.

Mar 25 2023, 13:30User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan renamed T15161: Internal resources should avoid to become external links, as default from Internal pages should open in the same tab as default to Internal resources should avoid to become external links, as default.
Mar 25 2023, 11:11User-valerio.bozzolan, Discussion Needed, Remarkup
avivey added a project to T15161: Internal resources should avoid to become external links, as default: Discussion Needed.
Mar 25 2023, 10:23User-valerio.bozzolan, Discussion Needed, Remarkup
avivey added a comment to T15161: Internal resources should avoid to become external links, as default.

I agree with this, but I think we should let this wait for broader discussion - there maybe good counter-arguments.

Mar 25 2023, 10:22User-valerio.bozzolan, Discussion Needed, Remarkup

Mar 24 2023

valerio.bozzolan added a comment to D25052: Add and use new RemarkupMetadata class.
Mar 24 2023, 23:07Remarkup

Mar 23 2023

valerio.bozzolan lowered the priority of T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine from Low to Wishlist.
Mar 23 2023, 11:01User-valerio.bozzolan, Remarkup
valerio.bozzolan removed a revision from T15161: Internal resources should avoid to become external links, as default: D25083: Remarkup: simplify the way "internal links" could be identified.
Mar 23 2023, 10:50User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25084: Remarkup: avoid to open internal pages as external links (as default).
Mar 23 2023, 10:49User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan renamed T15161: Internal resources should avoid to become external links, as default from Internal links should open in the same tab as default to Internal pages should open in the same tab as default.
Mar 23 2023, 10:33User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25083: Remarkup: simplify the way "internal links" could be identified.
Mar 23 2023, 10:23User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan removed a revision from T15161: Internal resources should avoid to become external links, as default: D25082: Remarkup: minor refactor to identify anchor and relative URIs.
Mar 23 2023, 10:17User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 23 2023, 10:16User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15182: Simplify the way "internal links" are identified.
Mar 23 2023, 10:11User-valerio.bozzolan, Remarkup
valerio.bozzolan removed a revision from T15161: Internal resources should avoid to become external links, as default: D25083: Remarkup: simplify the way "internal links" could be identified.
Mar 23 2023, 10:09User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15182: Simplify the way "internal links" are identified: D25083: Remarkup: simplify the way "internal links" could be identified.
Mar 23 2023, 10:09User-valerio.bozzolan, Remarkup
valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25083: Remarkup: simplify the way "internal links" could be identified.
Mar 23 2023, 10:08User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25082: Remarkup: minor refactor to identify anchor and relative URIs.
Mar 23 2023, 09:22User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan removed a revision from T15161: Internal resources should avoid to become external links, as default: D25082: Remarkup: minor refactor to identify anchor and relative URIs.
Mar 23 2023, 09:21User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan added a revision to T15182: Simplify the way "internal links" are identified: D25082: Remarkup: minor refactor to identify anchor and relative URIs.
Mar 23 2023, 09:20User-valerio.bozzolan, Remarkup
valerio.bozzolan added a revision to T15161: Internal resources should avoid to become external links, as default: D25082: Remarkup: minor refactor to identify anchor and relative URIs.
Mar 23 2023, 09:20User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15182: Simplify the way "internal links" are identified.
Mar 23 2023, 09:16User-valerio.bozzolan, Remarkup
valerio.bozzolan triaged T15182: Simplify the way "internal links" are identified as Low priority.
Mar 23 2023, 09:09User-valerio.bozzolan, Remarkup
valerio.bozzolan added a parent task for T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine: T15161: Internal resources should avoid to become external links, as default.
Mar 23 2023, 08:53User-valerio.bozzolan, Remarkup
valerio.bozzolan added a subtask for T15161: Internal resources should avoid to become external links, as default: T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine.
Mar 23 2023, 08:53User-valerio.bozzolan, Discussion Needed, Remarkup