Page MenuHomePhorge
Feed Advanced Search

Mon, Dec 9

valerio.bozzolan added a revision to T15974: Do not consider emails and custom protocols as internal links: D25847: Fix regression in Remarkup unit tests and harden.
Mon, Dec 9, 11:42 · User-valerio.bozzolan, Remarkup
valerio.bozzolan removed a revision from T15974: Do not consider emails and custom protocols as internal links: D25847: Fix regression in Remarkup unit tests and harden.
Mon, Dec 9, 11:21 · User-valerio.bozzolan, Remarkup
valerio.bozzolan added a revision to T15974: Do not consider emails and custom protocols as internal links: D25847: Fix regression in Remarkup unit tests and harden.
Mon, Dec 9, 11:21 · User-valerio.bozzolan, Remarkup
valerio.bozzolan created T15974: Do not consider emails and custom protocols as internal links.
Mon, Dec 9, 11:10 · User-valerio.bozzolan, Remarkup
valerio.bozzolan added a revision to T15973: Fix unit test PhutilRemarkupEngineTestCase: D25847: Fix regression in Remarkup unit tests and harden.
Mon, Dec 9, 09:52 · User-valerio.bozzolan, Remarkup
valerio.bozzolan created T15973: Fix unit test PhutilRemarkupEngineTestCase.
Mon, Dec 9, 09:43 · User-valerio.bozzolan, Remarkup

Thu, Dec 5

pppery closed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing as Resolved by committing rP9c73d62c4466: Rewrite regex for project names to be not prone to catastrophic backtracking.
Thu, Dec 5, 17:40 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a revision to T15967: Fix unit test PhutilPygmentizeParserTestCase: D25847: Fix regression in Remarkup unit tests and harden.
Thu, Dec 5, 15:52 · Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan updated the task description for T15967: Fix unit test PhutilPygmentizeParserTestCase.
Thu, Dec 5, 15:50 · Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan created T15967: Fix unit test PhutilPygmentizeParserTestCase.
Thu, Dec 5, 15:48 · Bug Reports, User-valerio.bozzolan, Remarkup

Sat, Nov 23

pppery claimed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Sat, Nov 23, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery renamed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing from RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing to RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Sat, Nov 23, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a revision to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Sat, Nov 23, 21:08 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Sat, Nov 23, 20:45 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Step 2: Remove irrelevant character class exclusions:

Sat, Nov 23, 20:33 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Disentangling that monster regex, step 1:

Sat, Nov 23, 20:30 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

Sat, Nov 23, 20:20 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

Sat, Nov 23, 20:18 · Bug Reports, Remarkup, Affects-Wikimedia

Oct 25 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Oct 25 2024, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Sep 16 2024

valerio.bozzolan added a comment to T15075: Add support for @link in diviner.

Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?

Sep 16 2024, 14:45 · Diviner, Remarkup

Aug 5 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 4 2024

avivey raised the priority of T15401: Make the Remarkup Help Page Extensible from Wishlist to Low.
Aug 4 2024, 07:54 · Documentation, Remarkup

Jul 29 2024

valerio.bozzolan closed T15161: Internal resources should avoid to become external links, as default as Resolved by committing rP349f006904fa: Remarkup: make less internal links open in new tabs.
Jul 29 2024, 10:42 · User-valerio.bozzolan, Discussion Needed, Remarkup

Jul 1 2024

valerio.bozzolan removed a revision from T15106: "Upload file" in remarkup text fields should attach by default : D25710: [STUB] Fix missing file attachment in Conpherence.
Jul 1 2024, 12:14 · Files, Remarkup
valerio.bozzolan added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25710: [STUB] Fix missing file attachment in Conpherence.
Jul 1 2024, 12:07 · Files, Remarkup
valerio.bozzolan added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25709: Fix missing file attachment in Conpherence.
Jul 1 2024, 11:58 · Files, Remarkup
valerio.bozzolan updated the task description for T15744: Render html color codes in remarkup.
Jul 1 2024, 07:00 · Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

I think GitHub allows that syntax only in comments 🤔

Jul 1 2024, 06:50 · Discussion Needed, Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

I was unaware of `#0969DA` syntax from github/gitlab.

Jul 1 2024, 02:55 · Discussion Needed, Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

I was unaware of #0969DA syntax from github/gitlab. I'm not sure if I like that syntax better than {} but I am generally in favor of using the same syntax as other systems in order to converge towards defacto standardization.

Jul 1 2024, 02:46 · Discussion Needed, Remarkup

Jun 30 2024

valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

Thanks again @20after4 for the efforts.

Jun 30 2024, 13:23 · Discussion Needed, Remarkup
valerio.bozzolan added a project to T15744: Render html color codes in remarkup: Discussion Needed.
Jun 30 2024, 13:14 · Discussion Needed, Remarkup
valerio.bozzolan merged T15871: Remarkup rule to show colors into T15744: Render html color codes in remarkup.
Jun 30 2024, 13:12 · Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15744: Render html color codes in remarkup.
Jun 30 2024, 13:12 · Discussion Needed, Remarkup

Jun 29 2024

mturdus added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25705: Fix missing file attachment in Phriction.
Jun 29 2024, 18:11 · Files, Remarkup

Jun 27 2024

avivey reopened T15401: Make the Remarkup Help Page Extensible as "Open".

(re-opening, there's more work left here)

Jun 27 2024, 06:27 · Documentation, Remarkup

Jun 26 2024

mturdus closed T15401: Make the Remarkup Help Page Extensible as Resolved by committing rPf52bc073216e: Make the Remarkup Help Page Extensible.
Jun 26 2024, 20:11 · Documentation, Remarkup

Jun 23 2024

mturdus added a revision to T15401: Make the Remarkup Help Page Extensible: D25698: Make the Remarkup Help Page Extensible.
Jun 23 2024, 20:10 · Documentation, Remarkup

May 2 2024

valerio.bozzolan added a comment to T15643: Support marking text with <ins> in Remarkup.

To implement this, you may want to start from this 🌈

May 2 2024, 18:09 · Feature Requests, Remarkup
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

Anyway, even with this fix, for some reasons I can't still use this feature with a comment like {#0000ff} in my local installation 🤔 I'm confused since the unit test works.

May 2 2024, 10:34 · Discussion Needed, Remarkup
zajdee added a comment to T15744: Render html color codes in remarkup.

@valerio.bozzolan yes, just now. I have only realized that there is a fix already after opening the ticket raised as a concern. Hadn't checked this in the past few days, so here I am, finally with my account approved and the issue is fixed. Thank you. :)

May 2 2024, 08:56 · Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

@zajdee have you already tried to update to latest master? After 6ab2b56a1a4a6 I mean. Thanks for this confirmation

May 2 2024, 08:54 · Discussion Needed, Remarkup
zajdee added a comment to T15744: Render html color codes in remarkup.

EDIT: This was already reported and resolved in T15802: Regression: HTML entities rendered as plain text in config option descriptions, I'm keeping the comment just to track this.

May 2 2024, 08:51 · Discussion Needed, Remarkup

Apr 30 2024

revi added a comment to T15744: Render html color codes in remarkup.

Or wrap a text with a background color - (something like What if I can change the background color here (and no italics)?)

Apr 30 2024, 15:40 · Discussion Needed, Remarkup

Apr 29 2024

valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

I'm somehow even more inclined to propose to base this feature on a new custom parser, like cowsay {{{ asd }}}

Apr 29 2024, 13:52 · Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

Minor clarification.

Apr 29 2024, 05:48 · Files, Remarkup

Apr 11 2024

avivey raised the priority of T15106: "Upload file" in remarkup text fields should attach by default from Normal to High.
Apr 11 2024, 10:41 · Files, Remarkup

Apr 2 2024

bekay added a comment to T15744: Render html color codes in remarkup.

Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

Apr 2 2024, 09:12 · Discussion Needed, Remarkup

Apr 1 2024

20after4 added a comment to T15744: Render html color codes in remarkup.

This D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes should be ready to merge now, if someone wouldn't mind reviewing it.

Apr 1 2024, 18:14 · Discussion Needed, Remarkup

Mar 26 2024

valerio.bozzolan closed T15729: Remarkup code blocks: guess the language from the "name" (if available) as Resolved by committing rPb1ae1b1a6789: Remarkup code blocks: guess language from "name=".
Mar 26 2024, 10:20 · User-valerio.bozzolan, Remarkup

Mar 25 2024

valerio.bozzolan claimed T15729: Remarkup code blocks: guess the language from the "name" (if available).
Mar 25 2024, 07:44 · User-valerio.bozzolan, Remarkup
valerio.bozzolan added a revision to T15729: Remarkup code blocks: guess the language from the "name" (if available): D25560: Remarkup code blocks: guess language from "name=".
Mar 25 2024, 07:42 · User-valerio.bozzolan, Remarkup

Mar 19 2024

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 19 2024, 16:41 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15182: Simplify the way "internal links" are identified, a subtask of T15161: Internal resources should avoid to become external links, as default, as Resolved.
Mar 19 2024, 16:34 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15182: Simplify the way "internal links" are identified as Resolved by committing rP328aee033fbd: isSelfURI: fix anchors and relative URIs (that are "self" indeed).
Mar 19 2024, 16:34 · User-valerio.bozzolan, Remarkup

Mar 15 2024

avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

(I've put a note in Dependencies for now)

Mar 15 2024, 18:23 · Remarkup
avivey renamed T15756: Rendering remarkup with many embedded code blocks is very slow from Parsing for a fairly reasonable sized remarkup text takes too long to Rendering remarkup with many embedded code blocks is very slow.
Mar 15 2024, 09:17 · Remarkup
bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Updated Pygments with pip to 2.17.2 und cut the time in half. So yeah, that's already an improvement.

Mar 15 2024, 09:08 · Remarkup
avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

I guess we could also try to cache the individual rendered code-blocks.

Mar 15 2024, 09:08 · Remarkup
bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Well, good to know that it is not something in the phorge codebase. Our server has pygmentize 2.14.0 - but the server itself is really not the best, so that could be an explanation. Maybe we could make some remarks about performance and keeping the versions fresh on the diviner page...

Mar 15 2024, 08:14 · Remarkup

Mar 14 2024

avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Update: I've installed pygments (2.15.1), and it took about 3 seconds to render. It takes about 14 seconds here (with pygments 2.3.1).

Mar 14 2024, 17:46 · Remarkup
avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

mm, dumping this file in my dev env renders pretty much immediately; that's a good sign that it's the code blocks, because (1) pygments is known to be slow and (2) I don't have it installed.

Mar 14 2024, 17:38 · Remarkup
valerio.bozzolan added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

I'm quite sure the problem is limited on repeated code blocks.

Mar 14 2024, 17:03 · Remarkup
avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

"slow remarkup" often boils down to 1-2 inefficient regexp in a rule somewhere.

Mar 14 2024, 16:47 · Remarkup
valerio.bozzolan triaged T15756: Rendering remarkup with many embedded code blocks is very slow as High priority.

Can reproduce

Mar 14 2024, 15:17 · Remarkup
bekay created T15756: Rendering remarkup with many embedded code blocks is very slow.
Mar 14 2024, 14:46 · Remarkup

Mar 9 2024

valerio.bozzolan added a revision to T15182: Simplify the way "internal links" are identified: D25555: isSelfURI: fix anchors and relative URIs (that are "self" indeed).
Mar 9 2024, 22:30 · User-valerio.bozzolan, Remarkup

Feb 29 2024

20after4 added a comment to T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

Added documentation in D25547: Diviner: Improve documentation for remarkup code blocks

Feb 29 2024, 17:36 · Remarkup
valerio.bozzolan added a comment to T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

Yeah enjoy this feature! Already part of our glorious 2023 Week 32

Feb 29 2024, 08:31 · Remarkup
valerio.bozzolan merged T15747: Support short language specifier in code blocks: ```php instead of ```lang=php into T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Feb 29 2024, 08:30 · Feature Requests, Remarkup
valerio.bozzolan merged task T15747: Support short language specifier in code blocks: ```php instead of ```lang=php into T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Feb 29 2024, 08:30 · Remarkup
valerio.bozzolan closed T15293: Try to avoid message: Transaction (of type "core:file") has no effect as Resolved by committing rP6df26b98c104: Comments: avoid confusing warning about "core:file".
Feb 29 2024, 08:17 · Files, Remarkup
valerio.bozzolan closed T15293: Try to avoid message: Transaction (of type "core:file") has no effect, a subtask of T15106: "Upload file" in remarkup text fields should attach by default , as Resolved.
Feb 29 2024, 08:17 · Files, Remarkup
20after4 closed T15747: Support short language specifier in code blocks: ```php instead of ```lang=php as Invalid.
Feb 29 2024, 06:34 · Remarkup
20after4 added a comment to T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

Hahah I guess I could have tested it first.

Feb 29 2024, 06:33 · Remarkup
avivey updated subscribers of T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

I think we already did - @valerio.bozzolan ?

Feb 29 2024, 05:28 · Remarkup

Feb 28 2024

20after4 created T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.
Feb 28 2024, 18:35 · Remarkup
valerio.bozzolan added a revision to T15293: Try to avoid message: Transaction (of type "core:file") has no effect: D25544: Comments: avoid confusing warning about "core:file".
Feb 28 2024, 15:49 · Files, Remarkup
valerio.bozzolan claimed T15293: Try to avoid message: Transaction (of type "core:file") has no effect.

Gotcha. Probably this is generating the attachment transactions but should be "ignored on no effects":

Feb 28 2024, 15:23 · Files, Remarkup
valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

This feature is not complete also for Conpherence AFAIK

Feb 28 2024, 15:02 · Files, Remarkup

Feb 27 2024

20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.
Feb 27 2024, 01:21 · Remarkup

Feb 26 2024

20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.

Interestingly, I just discovered Wikimedia has a pretty cool project to render math on the server side, by transpiling some js into php:

Feb 26 2024, 19:18 · Remarkup
20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.

There is also MathJax, a subset of LaTex that only covers the mathematical notation without the page layout functionality.

Feb 26 2024, 17:42 · Remarkup

Feb 25 2024

valerio.bozzolan added a comment to T15743: Support for math (LaTeX) in Remarkup.

I see that it depends on a NodeJS external script (server-side).

Feb 25 2024, 15:34 · Remarkup
20after4 claimed T15744: Render html color codes in remarkup.
Feb 25 2024, 04:14 · Discussion Needed, Remarkup
20after4 triaged T15744: Render html color codes in remarkup as Normal priority.
Feb 25 2024, 04:14 · Discussion Needed, Remarkup
20after4 added a revision to T15744: Render html color codes in remarkup: D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
Feb 25 2024, 04:10 · Discussion Needed, Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

This would be useful for discussions about design, specifically I wished for this feature while reviewing D25491: Improve contrast of Links in Dark Mode

Feb 25 2024, 00:53 · Discussion Needed, Remarkup
20after4 created T15744: Render html color codes in remarkup.
Feb 25 2024, 00:48 · Discussion Needed, Remarkup
20after4 created T15743: Support for math (LaTeX) in Remarkup.
Feb 25 2024, 00:40 · Remarkup

Feb 7 2024

revi attached a referenced file: F1263882: image.png.
Feb 7 2024, 11:03 · Remarkup, Bug Reports
revi created T15733: IDN not in a punycode format is not recognized as a link.
Feb 7 2024, 11:03 · Remarkup, Bug Reports

Jan 31 2024

valerio.bozzolan triaged T15729: Remarkup code blocks: guess the language from the "name" (if available) as Low priority.
Jan 31 2024, 17:16 · User-valerio.bozzolan, Remarkup

Jan 28 2024

bekay closed T15716: Remarkup header have a fixed line height and are less readable with increased size as Resolved by committing rPf8db94f2bfbe: Add flexible line height to remarkup headers.
Jan 28 2024, 11:45 · Discussion Needed, Remarkup

Jan 22 2024

bekay added a revision to T15716: Remarkup header have a fixed line height and are less readable with increased size: D25523: Add flexible line height to remarkup headers.
Jan 22 2024, 16:57 · Discussion Needed, Remarkup

Jan 19 2024

avivey added a comment to T15716: Remarkup header have a fixed line height and are less readable with increased size.

Values given in em units may produce unexpected results...

Jan 19 2024, 10:32 · Discussion Needed, Remarkup

Jan 18 2024

bekay created T15716: Remarkup header have a fixed line height and are less readable with increased size.
Jan 18 2024, 18:33 · Discussion Needed, Remarkup

Jan 17 2024

avivey added a comment to T15712: Support Literal Blocks Syntax Inline.

If it's only for a small number of such words, they should probably just be added to the blacklist remarkup.ignored-object-names - in fact, we should probably add S3 at least as a default; And probably find a way to expose this config option. Maybe a button on the Remarkup box that will help adding things to the blacklist?

Jan 17 2024, 14:56 · Remarkup

Jan 16 2024

Ekubischta added a comment to T15712: Support Literal Blocks Syntax Inline.

Is the motivation only to allow not-magicking things like "S3" and "F1", or is there more?

Looks like the tickets end in a Wontfix in https://secure.phabricator.com/T5301; I didn't follow the whole thing, but often the reasoning in Remarkup boils down to performance.

Jan 16 2024, 20:27 · Remarkup
avivey added a comment to T15712: Support Literal Blocks Syntax Inline.

mm, see this one: https://secure.phabricator.com/T5301#211340

Jan 16 2024, 20:11 · Remarkup