PhabricatorFileImageTransform defines getTransformedDimensions(). There is no such method existing for video files as videos have no transforms.
The transform dimensions for image files are defined (and hardcoded) in its child class https://we.phorge.it/source/phorge/browse/master/src/applications/files/transform/PhabricatorFileThumbnailTransform.php$73-76. There is no way to reuse them anyway - 220px feels small.

In D25847#26647, @aklapper wrote:

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

add a potential performance TODO in legacy code: T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs

Avoid $array[$key]=1 and use $array[$key]=$key as suggested

drop newline

add some inline documentation about $array[$v] = 1

I need to sleep

transaction.search: handle unmanaged exception when objectType is not supported

add more edge cases in unit tests

P.S. I wonder... what happens if we expose the width/height here. But probably just touching that would be enough. Still, patch welcome 👍

Thanks. Yes. I can reproduce. Relevant documentation:

Thanks. I also encourage in not following the mentioned implementation, and not only because they have problems with deleted files (interesting) but also because that solution is verticalized on Wikimedia Commons, and nowadays a "modern" embedder system should probably just use the OEmbed protocol that is quite flexible and would support out of the box an incredible amount of websites, potentially including Wikimedia Commons, with relatively few amount of code, than supporting every single website in the universe.

That's true of all projects - Remarkup here for instance.

In T16028#21601, @pppery wrote:

{#js-draw-lib} does work.

{#js-draw-lib} does work.

@pppery I don't know if you wanna step in, since the change was introduced by you.

In T15203#21226, @valerio.bozzolan wrote:

(M is short for Mockup probably)

(M is short for Mockup probably)

On this server, we changed the config to /^(Q|V|M)\d$/ because we don't have P1 tickets.
I'm also not sure what M is short for.

In T15203#21219, @avivey wrote:

The V123 syntax is disabled by remarkup.ignored-object-names config by default; The default is /^(Q|V|M|P)\d$/ (basically anything starting with Q, V, M, or P), for "Q1" (biz-talk for April), "V1" (for versions), "M1" (for ?????) and "P1" (Jira for "important bug").

I'm honestly surprised about layout=inline working for {T123} - I thought is only works for images. But it can probably be made to work for Votes (or rather, all objects) like it does for tasks.

The V123 syntax is disabled by remarkup.ignored-object-names config by default; The default is /^(Q|V|M|P)\d$/ (basically anything starting with Q, V, M, or P and only having one digit), for "Q1" (biz-talk for April), "V1" (for versions), "M1" (for ?????) and "P1" (Jira for "important bug").

git rebase master

./bin/celerity map as this touches a JS file

I do not recommend, because https://phabricator.wikimedia.org/T293139 - Phorge displays whatever it gets, especially if the video got deleted in the meantime. Same behavior for Youtube.

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

It works on my computer. Thaaaanks \o/

If the goal is to make it denote "inserted text", I think it should be visually different to "underline" - something more similar to the green we use for actual diff views, maybe more subtle. Will need special handling in the color-blindness themes.

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Step 2: Remove irrelevant character class exclusions:

Disentangling that monster regex, step 1:

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.