Fix "Search" Application description
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 4 2023, 23:27.

Details

Reviewers

Cigaryno
avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15230: Fix Search Application description

Commits

rP306ce1c0b71a: Fix "Search" Application description

Summary

This description was somehow broken since 2019:

Phabricator Search Application - Remarkup issue.png (705×1 px, 88 KB)

Probably this was caused by a Remarkup breaking change introduced by this
specific XSS security fix:

rP54bcbdaba94a: Fix an XSS issue with certain high-priority remarkup rules embedded inside…

Maybe in the future the backtick operator will be supported again
in Remarkup. Or, maybe not. So, let's just workaround to make that
specific page "less exploded" again.

Closes T15230

Test Plan

visit the page /applications/view/PhabricatorSearchApplication/
check that now the Remarkup is rendered perfectly

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Apr 4 2023, 23:27

Owners added a reviewer: O1: Blessed Committers.Apr 4 2023, 23:27

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 4 2023, 23:27

valerio.bozzolan requested review of this revision.Apr 4 2023, 23:27

Harbormaster completed remote builds in B222: Diff 450.Apr 4 2023, 23:27

valerio.bozzolan mentioned this in Z1: Phorge.Apr 4 2023, 23:29

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added a task: T15230: Fix Search Application description.

valerio.bozzolan removed a task: T15132: Support monospaced links in remarkup.

Cigaryno accepted this revision.Apr 5 2023, 08:44

This revision is now accepted and ready to land.Apr 5 2023, 12:00

valerio.bozzolan retitled this revision from This is a small fix in the "Search" Application description. to Fix "Search" Application description.Apr 5 2023, 13:36

valerio.bozzolan edited the summary of this revision. (Show Details)

Closed by commit rP306ce1c0b71a: Fix "Search" Application description. · Explain WhyApr 5 2023, 13:37

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP306ce1c0b71a: Fix "Search" Application description.

valerio.bozzolan mentioned this in 2023 Week 2.Apr 5 2023, 13:41

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54