Page MenuHomePhorge

Try to avoid message: Transaction (of type "core:file") has no effect
Closed, ResolvedPublic

Description

Steps to reproduce

In whatever application with comments, like a Maniphest Task:

  1. Create a comment pasting F270656
  2. Create another comment pasting F270656

What happens

Visual message:

Comment Post confirmation message.png (183×582 px, 16 KB)

Text:

Action With No Effect
One of your actions has no effect:

Transaction (of type "core:file") has no effect.

Apply remaining actions?

What should happen instead

No weird confirmation message.

Why that happens

It seems this source code generates the "file reference":

https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php;ac99285c57a06ed5699b69242fd6588edd950112$2288-2291

Probably, if the file is already referenced, it tries to generate another file reference.

Possible solutions? (one of them)

  1. Probably, something should ignore this redundant transaction
  2. Probably, this transaction should not be generated

Event Timeline

valerio.bozzolan triaged this task as Normal priority.
valerio.bozzolan created this object in space S1 Public.

Hi @Dylsss thanks again for your improvement. Have you any idea about why that message happens?